From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59B1DC47259 for ; Tue, 5 May 2020 11:49:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F118206B8 for ; Tue, 5 May 2020 11:49:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="E0QLbflm"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="HvPZq82y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F118206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bT7+lF7nqL8yxclZ4kd2fERTj3wb3X5SQEjbUqv3EBI=; b=E0QLbflmlf/L8v Ri7a4BV6cyoyO7d9FMgU5v09pJapo+C1yRvIBg3CmK4tYGy6HrfL98hwO2HRuemdq8DW7v/MCdY33 6t92EOAKNJdrH6sitrlg0FyifiFfGE1ug54bBIpiRJpMywVnx/HOrYcoUMnJb+67+b81NEgvObg2K c/TzO7/QT8+07f18JW5lOKLEDY7+SBdP69ljLs9ypxU7Yn33xA082vINL26J2Kqq0ZfPjcGqYGrpZ HK4/Zt5/IXaeFp09IW94LUpDeeDt9xzfGfr6mh5LwsKuEqu4sya2L2QeLOm0uROOQAIUV790wj6mP 7E1MfFzm8X3Fnyj/4qSA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVw4d-0005a4-O7; Tue, 05 May 2020 11:49:19 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVw4Z-0005XC-Ss for linux-arm-kernel@lists.infradead.org; Tue, 05 May 2020 11:49:17 +0000 X-UUID: 049a1c47e2f840d5b71190a049554c22-20200505 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=pPCw/hSKdiOkecOhojlmReD8aZk/qsyj+9+P5fF9LYA=; b=HvPZq82ywqxJE5RlOFXEeyzPJah9VOMzrT5fEEt5MUXvHBm/UgriO6dPs+Bei3oqYB8cxtuOHWIFE+OnuaCtJ59zzulSMza6B4U40bqEqbV/h2zEQQYTa5fgFkFhWnVotmojvMC3uvtSaz4H1PoAZ3oIqqwSk++2MtXojvLOv10=; X-UUID: 049a1c47e2f840d5b71190a049554c22-20200505 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 669339013; Tue, 05 May 2020 03:48:43 -0800 Received: from MTKMBS33N1.mediatek.inc (172.27.4.75) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 5 May 2020 04:49:03 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS33N1.mediatek.inc (172.27.4.75) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 5 May 2020 19:49:00 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 5 May 2020 19:48:59 +0800 Message-ID: <1588679279.8804.133.camel@mhfsdcap03> Subject: Re: [PATCH v10 1/3] media: dt-bindings: ov8856: Document YAML bindings From: Dongchun Zhu To: Robert Foss , Tomasz Figa Date: Tue, 5 May 2020 19:47:59 +0800 In-Reply-To: <20200505100129.104673-2-robert.foss@linaro.org> References: <20200505100129.104673-1-robert.foss@linaro.org> <20200505100129.104673-2-robert.foss@linaro.org> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 13630F7D312406468B28054E50195F55DADBD634018715057684F8B50EA5600E2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200505_044915_941780_5F32DB7B X-CRM114-Status: GOOD ( 23.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Tomasz Figa , Marco Felsch , Maxime Ripard , linux-kernel@vger.kernel.org, Ben Kao , Sakari Ailus , Maxime Ripard , Andy Shevchenko , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Robert, Thanks for the update. On Tue, 2020-05-05 at 12:01 +0200, Robert Foss wrote: > From: Dongchun Zhu > > This patch adds documentation of device tree in YAML schema for the > OV8856 CMOS image sensor. > > Signed-off-by: Dongchun Zhu > Signed-off-by: Robert Foss > Reviewed-by: Maxime Ripard > --- > > - Changes since v9: > * Remove remote-endpoint property > * Marco: Make port property required again > * Sakari: Remove Ben as a maintainer > * Sakari: Replace data-lanes with const items > * Sakari: Remove clock-lanes property > * Sakari & Rob Herring: Change type of link-frequency > work around dt-schema bug > > - Changes since v8: > * Maxime: Added r-b > > - Changes since v7: > * Marco: Make 'port' property optional > * Maxime & Sakari: Add 'link-frequencies' property to dt binding > * robher: Improve description for 'port' property > > - Changes since v6: > * Marco: remove qcom specifics from DT example > > - Changes since v5: > * Add assigned-clocks and assigned-clock-rates > * robher: dt-schema errors > > - Changes since v4: > * Fabio: Change reset-gpio to GPIO_ACTIVE_LOW, explain in description > * Add clock-lanes property to example > * robher: Fix syntax error in devicetree example > > - Changes since v3: > * robher: Fix syntax error > * robher: Removed maxItems > * Fixes yaml 'make dt-binding-check' errors > > - Changes since v2: > > - Changes since v1: > Fixes comments from Sakari, Tomasz > * Add clock-frequency and link-frequencies in DT > > .../devicetree/bindings/media/i2c/ov8856.yaml | 142 ++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 143 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov8856.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml > new file mode 100644 > index 000000000000..d6af685ad3ca > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml > @@ -0,0 +1,142 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright (c) 2019 MediaTek Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/ov8856.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Omnivision OV8856 CMOS Sensor Device Tree Bindings > + > +maintainers: > + - Dongchun Zhu > + > +description: |- > + The Omnivision OV8856 is a high performance, 1/4-inch, 8 megapixel, CMOS > + image sensor that delivers 3264x2448 at 30fps. It provides full-frame, > + sub-sampled, and windowed 10-bit MIPI images in various formats via the > + Serial Camera Control Bus (SCCB) interface. This chip is programmable > + through I2C and two-wire SCCB. The sensor output is available via CSI-2 > + serial data output (up to 4-lane). > + > +properties: > + compatible: > + const: ovti,ov8856 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + description: > + Input clock for the sensor. > + items: > + - const: xvclk > + > + clock-frequency: > + description: > + Frequency of the xvclk clock in Hertz. > + > + dovdd-supply: > + description: > + Definition of the regulator used as interface power supply. > + > + avdd-supply: > + description: > + Definition of the regulator used as analog power supply. > + > + dvdd-supply: > + description: > + Definition of the regulator used as digital power supply. > + > + reset-gpios: > + description: > + The phandle and specifier for the GPIO that controls sensor reset. > + This corresponds to the hardware pin XSHUTDOWN which is physically > + active low. > + > + port: > + type: object > + additionalProperties: false > + description: > + A node containing an output port node with an endpoint definition > + as documented in > + Documentation/devicetree/bindings/media/video-interfaces.txt > + > + properties: > + endpoint: > + type: object > + > + properties: > + data-lanes: > + description: |- > + The driver only supports four-lane operation. > + items: > + - const: 1 > + - const: 2 > + - const: 3 > + - const: 4 > + > + link-frequencies: > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint64-array > + description: > + Allowed data bus frequencies. 360000000, 180000000 Hz or both > + are supported by the driver. > + > + > + required: > + - link-frequencies > + > + required: > + - endpoint > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - clock-frequency > + - dovdd-supply > + - avdd-supply > + - dvdd-supply > + - reset-gpios > + - port > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ov8856: camera@10 { > + compatible = "ovti,ov8856"; > + reg = <0x10>; > + > + reset-gpios = <&pio 111 GPIO_ACTIVE_LOW>; Apologies for missing to follow the earlier discussion related to this. I noticed the GPIO flag para and __ov8856_power_on() are aligned using ACTIVE_LOW. But from the datasheet, XSHUTDN pin is active-high for OV8856. It means devm_gpiod_get API (in probe func) should use GPIOD_OUT_LOW to initialize the GPIO as output with a value of 0. Otherwise it should use GPIOD_OUT_HIGH. There is one case for GPIO_ACTIVE_LOW setting: https://patchwork.linuxtv.org/patch/63460/ https://patchwork.linuxtv.org/patch/63461/ Sakari, Tomasz, am I right? > + pinctrl-names = "default"; > + pinctrl-0 = <&clk_24m_cam>; > + > + clocks = <&cam_osc>; > + clock-names = "xvclk"; > + clock-frequency = <19200000>; > + > + avdd-supply = <&mt6358_vcama2_reg>; > + dvdd-supply = <&mt6358_vcamd_reg>; > + dovdd-supply = <&mt6358_vcamio_reg>; > + > + port { > + wcam_out: endpoint { > + remote-endpoint = <&mipi_in_wcam>; > + data-lanes = <1 2 3 4>; > + link-frequencies = /bits/ 64 <360000000>; > + }; > + }; > + }; > + }; > +... > \ No newline at end of file > diff --git a/MAINTAINERS b/MAINTAINERS > index 26f281d9f32a..84b262afd13d 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -12489,6 +12489,7 @@ L: linux-media@vger.kernel.org > S: Maintained > T: git git://linuxtv.org/media_tree.git > F: drivers/media/i2c/ov8856.c > +F: Documentation/devicetree/bindings/media/i2c/ov8856.yaml > Had you run parse-maintainers.pl? The new item is supposed to be arranged in alphabetical order. > OMNIVISION OV9640 SENSOR DRIVER > M: Petr Cvek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel