From: Will Deacon <will@kernel.org>
To: Daniel Thompson <daniel.thompson@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>
Cc: patches@linaro.org, Douglas Anderson <dianders@chromium.org>,
linux-kernel@vger.kernel.org,
Jason Wessel <jason.wessel@windriver.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] arm64: cacheflush: Fix KGDB trap detection
Date: Tue, 5 May 2020 17:13:45 +0100 [thread overview]
Message-ID: <158869137087.244424.4260224460496540281.b4-ty@kernel.org> (raw)
In-Reply-To: <20200504170518.2959478-1-daniel.thompson@linaro.org>
On Mon, 4 May 2020 18:05:18 +0100, Daniel Thompson wrote:
> flush_icache_range() contains a bodge to avoid issuing IPIs when the kgdb
> trap handler is running because issuing IPIs is unsafe (and not needed)
> in this execution context. However the current test, based on
> kgdb_connected is flawed: it both over-matches and under-matches.
>
> The over match occurs because kgdb_connected is set when gdb attaches
> to the stub and remains set during normal running. This is relatively
> harmelss because in almost all cases irq_disabled() will be false.
>
> [...]
Applied to arm64 (for-next/misc), thanks!
[1/1] arm64: cacheflush: Fix KGDB trap detection
https://git.kernel.org/arm64/c/ab8ad279ceac
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-05-05 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 17:05 [PATCH v2] arm64: cacheflush: Fix KGDB trap detection Daniel Thompson
2020-05-04 20:48 ` Will Deacon
2020-05-05 14:15 ` Daniel Thompson
2020-05-05 15:09 ` Will Deacon
2020-05-06 15:06 ` Daniel Thompson
2020-05-05 16:13 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158869137087.244424.4260224460496540281.b4-ty@kernel.org \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=jason.wessel@windriver.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox