From: Stanley Chu <stanley.chu@mediatek.com>
To: Avri Altman <Avri.Altman@wdc.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"andy.teng@mediatek.com" <andy.teng@mediatek.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"chun-hung.wu@mediatek.com" <chun-hung.wu@mediatek.com>,
"kuohong.wang@mediatek.com" <kuohong.wang@mediatek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"cang@codeaurora.org" <cang@codeaurora.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"peter.wang@mediatek.com" <peter.wang@mediatek.com>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"beanhuo@micron.com" <beanhuo@micron.com>
Subject: Re: [SPAM]RE: [PATCH v5 2/8] scsi: ufs: introduce fixup_dev_quirks vops
Date: Fri, 8 May 2020 07:56:52 +0800 [thread overview]
Message-ID: <1588895812.3197.43.camel@mtkswgap22> (raw)
In-Reply-To: <1588603287.3197.35.camel@mtkswgap22>
Hi Avri,
On Mon, 2020-05-04 at 22:41 +0800, Stanley Chu wrote:
> Hi Avri,
>
> On Mon, 2020-05-04 at 10:38 +0000, Avri Altman wrote:
> > >
> > > ufs_fixup_device_setup(hba);
> > > + ufshcd_vops_fixup_dev_quirks(hba);
> > Maybe call your new ufshcd_vops_fixup_dev_quirks as part of ufs_fixup_device_setup
>
> The latter patch exports ufs_fixup_device_setup() for vendors to re-use
> it to parse vendor-specific device quirk table during the call of
> ufshcd_vops_fixup_dev_quirks(), thus ufshcd_vops_fixup_dev_quirks()
> cannot be as part of ufs_fixup_device_setup().
Maybe I could use a new function to contain ufs_fixup_device_setup() and
ufshcd_vops_fixup_dev_quirks() to make the code more clear here.
Thanks,
Stanley Chu
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-07 23:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 11:34 [PATCH v5 0/8] scsi: ufs: support LU Dedicated buffer mode for WriteBooster Stanley Chu
2020-05-03 11:34 ` [PATCH v5 1/8] scsi: ufs: enable WriteBooster on some pre-3.1 UFS devices Stanley Chu
2020-05-04 10:37 ` Avri Altman
2020-05-04 14:33 ` Stanley Chu
2020-05-07 23:50 ` Stanley Chu
2020-05-03 11:34 ` [PATCH v5 2/8] scsi: ufs: introduce fixup_dev_quirks vops Stanley Chu
2020-05-04 10:38 ` Avri Altman
2020-05-04 14:41 ` Stanley Chu
2020-05-07 23:56 ` Stanley Chu [this message]
2020-05-03 11:34 ` [PATCH v5 3/8] scsi: ufs: export ufs_fixup_device_setup() function Stanley Chu
2020-05-04 11:00 ` Avri Altman
2020-05-03 11:34 ` [PATCH v5 4/8] scsi: ufs-mediatek: add fixup_dev_quirks vops Stanley Chu
2020-05-04 10:55 ` Avri Altman
2020-05-04 11:03 ` Avri Altman
2020-05-04 11:04 ` Avri Altman
2020-05-03 11:34 ` [PATCH v5 5/8] scsi: ufs: add "index" in parameter list of ufshcd_query_flag() Stanley Chu
2020-05-03 11:34 ` [PATCH v5 6/8] scsi: ufs: add LU Dedicated buffer mode support for WriteBooster Stanley Chu
2020-05-03 14:26 ` Avri Altman
2020-05-03 11:34 ` [PATCH v5 7/8] scsi: ufs-mediatek: enable WriteBooster capability Stanley Chu
2020-05-03 11:34 ` [PATCH v5 8/8] scsi: ufs: cleanup WriteBooster feature Stanley Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1588895812.3197.43.camel@mtkswgap22 \
--to=stanley.chu@mediatek.com \
--cc=Avri.Altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=asutoshd@codeaurora.org \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=chun-hung.wu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).