From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BB4CC433E1 for ; Thu, 14 May 2020 06:53:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40885206BE for ; Thu, 14 May 2020 06:53:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YUJe4OUv"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="FeAcylxc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40885206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uBvcXQZfPTTNidSchgRVEnJ8T4j7TAo+1jISjeTgvDI=; b=YUJe4OUvP/zzwi og+BDAr6QyxJdWk2J0LQao9nT7y1E+F+uJj671EVahr7WiNKsMGGhUAiG6SlDW7k7SWnZsSRFImb5 EC/Rcur0u+lyINwygqb46NIZJQ7Eb2vPcXWefQbrX34NQLFhHdDtDas+sOwU0lE4UEYVYq5+/meX4 zWtCrkHHzsqDIxMiLXASMWQiA7Va+T2MrSWtIe9gsOrqMVTU5auPsfq3tzfqZga/ZbZGA4tnzPLNt HVFmiFtQXZpPGPXjrzrbe+bVg/Te5r5hY9Ta8fV6n4bqpT3VuFNUJC21WoP35zuIQlpQA8bodeclc wtNcXQ1R37G9OhI+nEig==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZ7k1-0004q1-Ox; Thu, 14 May 2020 06:53:13 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZ7jy-0004pT-Dx; Thu, 14 May 2020 06:53:11 +0000 X-UUID: 7befcf9a470443b0b89bf31fcf6df3b0-20200513 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=3KesiILI1kxdXuxYFJLvOe2N5zt5fySbHaeCUFW3ySw=; b=FeAcylxcmvbJb8uonYacGncisTg9hEa9QZdt9A87BRSDzjrE2bIWI5NX6VqLQRJ8x/gKKXvyxFmqlgHFppgx5vnKnpbFj7wTzhnzt5qP8J5SCEjpvmyb3/Kbiv6OHpuZbsvLCvpSuJjrauAEUcxtpij97UyuKfEcSUEua29JPu8=; X-UUID: 7befcf9a470443b0b89bf31fcf6df3b0-20200513 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 156385679; Wed, 13 May 2020 22:53:05 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 13 May 2020 23:53:01 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 14 May 2020 14:53:01 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 14 May 2020 14:53:01 +0800 Message-ID: <1589439182.11120.1.camel@mtksdccf07> Subject: Re: [v4,7/7] thermal: mediatek: use spinlock to protect PTPCORESEL From: Michael Kao To: Matthias Brugger Date: Thu, 14 May 2020 14:53:02 +0800 In-Reply-To: <20200323121537.22697-8-michael.kao@mediatek.com> References: <20200323121537.22697-1-michael.kao@mediatek.com> <20200323121537.22697-8-michael.kao@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200513_235310_475718_424B8FCE X-CRM114-Status: GOOD ( 14.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, srv_heupstream@mediatek.com, linux-pm@vger.kernel.org, Daniel Lezcano , linux-kernel@vger.kernel.org, Eduardo Valentin , Rob Herring , linux-mediatek@lists.infradead.org, hsinyi@chromium.org, Zhang Rui , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2020-03-23 at 20:15 +0800, Michael Kao wrote: > From: "michael.kao" > > The driver of thermal and svs will use the > same register for the project which should select > bank before reading sensor value. > > Signed-off-by: Michael Kao > --- > drivers/thermal/mtk_thermal.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c > index 9eaca432920e..594ad4f0f8cd 100644 > --- a/drivers/thermal/mtk_thermal.c > +++ b/drivers/thermal/mtk_thermal.c > @@ -22,6 +22,7 @@ > #include > #include > #include > +#include > > /* AUXADC Registers */ > #define AUXADC_CON1_SET_V 0x008 > @@ -262,7 +263,7 @@ struct mtk_thermal { > struct clk *clk_peri_therm; > struct clk *clk_auxadc; > /* lock: for getting and putting banks */ > - struct mutex lock; > + unsigned long flags; > > /* Calibration values */ > s32 adc_ge; > @@ -561,7 +562,7 @@ static void mtk_thermal_get_bank(struct mtk_thermal_bank *bank) > u32 val; > > if (mt->conf->need_switch_bank) { > - mutex_lock(&mt->lock); > + mt->flags = claim_mtk_svs_lock(); > > val = readl(mt->thermal_base + PTPCORESEL); > val &= ~0xf; > @@ -581,7 +582,7 @@ static void mtk_thermal_put_bank(struct mtk_thermal_bank *bank) > struct mtk_thermal *mt = bank->mt; > > if (mt->conf->need_switch_bank) > - mutex_unlock(&mt->lock); > + release_mtk_svs_lock(mt->flags); > } > > /** > @@ -938,8 +939,6 @@ static int mtk_thermal_probe(struct platform_device *pdev) > if (ret) > return ret; > > - mutex_init(&mt->lock); > - > mt->dev = &pdev->dev; > > auxadc = of_parse_phandle(np, "mediatek,auxadc", 0); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel