From: Will Deacon <will@kernel.org>
To: mark.rutland@arm.com, Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: catalin.marinas@arm.com, Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pmu/smmuv3: Clear IRQ affinity hint on device removal
Date: Tue, 19 May 2020 00:04:06 +0100 [thread overview]
Message-ID: <158982257913.5151.8809626382618545833.b4-ty@kernel.org> (raw)
In-Reply-To: <20200422084805.237738-1-jean-philippe@linaro.org>
On Wed, 22 Apr 2020 10:48:06 +0200, Jean-Philippe Brucker wrote:
> Currently when trying to remove the SMMUv3 PMU module we get a
> WARN_ON_ONCE from free_irq(), because the affinity hint set during probe
> hasn't been properly cleared.
>
> [ 238.878383] WARNING: CPU: 0 PID: 175 at kernel/irq/manage.c:1744 free_irq+0x324/0x358
> ...
> [ 238.897263] Call trace:
> [ 238.897998] free_irq+0x324/0x358
> [ 238.898792] devm_irq_release+0x18/0x28
> [ 238.899189] release_nodes+0x1b0/0x228
> [ 238.899984] devres_release_all+0x38/0x60
> [ 238.900779] device_release_driver_internal+0x10c/0x1d0
> [ 238.901574] driver_detach+0x50/0xe0
> [ 238.902368] bus_remove_driver+0x5c/0xd8
> [ 238.903448] driver_unregister+0x30/0x60
> [ 238.903958] platform_driver_unregister+0x14/0x20
> [ 238.905075] arm_smmu_pmu_exit+0x1c/0xecc [arm_smmuv3_pmu]
> [ 238.905547] __arm64_sys_delete_module+0x14c/0x260
> [ 238.906342] el0_svc_common.constprop.0+0x74/0x178
> [ 238.907355] do_el0_svc+0x24/0x90
> [ 238.907932] el0_sync_handler+0x11c/0x198
> [ 238.908979] el0_sync+0x158/0x180
>
> [...]
Applied to will (for-next/perf), thanks!
[1/1] pmu/smmuv3: Clear IRQ affinity hint on device removal
https://git.kernel.org/will/c/10f6cd2af21b
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-05-18 23:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 8:48 [PATCH] pmu/smmuv3: Clear IRQ affinity hint on device removal Jean-Philippe Brucker
2020-05-18 23:04 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158982257913.5151.8809626382618545833.b4-ty@kernel.org \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=jean-philippe@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox