From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80CD5C433E0 for ; Wed, 20 May 2020 06:55:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 473D62065F for ; Wed, 20 May 2020 06:55:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EJ3NoIev"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="kgNj5eFk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 473D62065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qPFAtnwtziNsj2DLQga7DSG9M85ensGma6P3y4lPH+w=; b=EJ3NoIevHM34US fRfF+inTBXJ2b8sXkIrOvLqlVjg6XgwknBk7Ydk8oAu21wPN3+ieAUcG90uUzBHuNJaakTsTixsH5 2Q6t9nmKeEJjYmxyJu5YMhkQyDeC9IU6SVbTISZarcJkqVkyxmYMwTA5vbPf01UzPRmj8UWntnd9J F4r42QW0fYNoX5WRQ6rkRb9kvx6QycrkAqXel6b0xXmL6W9kwM+H7njau3G2FFCRRuFaRd4pNHB6o HNR9QOVIf0eEbTut1G2rHLLuYsYjv+gmu5A1F9hcK8ylN3aO3b1J3ymixGLdO++enlpRdSkJv5azc EdhXIlIhPAspd0O37FIg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbIdE-0001oS-FZ; Wed, 20 May 2020 06:55:12 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbId7-0000gk-TO; Wed, 20 May 2020 06:55:07 +0000 X-UUID: eb52538a63c547959b194ce3a3e60208-20200519 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=5Lcz411vQymr8LOv9ZOMpOR7TAY9qOG8MgWx5t4pG8Q=; b=kgNj5eFkW9mPa012Eif0MwO65NhHJv+kf3LAKjxzjF1JFTBJQtjE1QRHXVstaJqZ/PjloQMeqEOTLcV/u8sWiFpKGsIYMh1uWT1JownyyL4XLnw2zn69E2s2nlGFLJxE3JGdUNSMY5Es1LB3ZR+oX0ATl3WaUkXeRVeCHDWmiEI=; X-UUID: eb52538a63c547959b194ce3a3e60208-20200519 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 2133675788; Tue, 19 May 2020 22:55:03 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 19 May 2020 23:55:00 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 20 May 2020 14:54:53 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 20 May 2020 14:54:54 +0800 Message-ID: <1589957603.13912.2.camel@mhfsdcap03> Subject: Re: [PATCH] iommu: Don't call .probe_finalize() under group->mutex From: Yong Wu To: Joerg Roedel Date: Wed, 20 May 2020 14:53:23 +0800 In-Reply-To: <20200519132824.15163-1-joro@8bytes.org> References: <20200519132824.15163-1-joro@8bytes.org> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 255D14E269C30CBAC837F7C42790D730FB5613A0BD2417CC0B32DAEB4E59CBDF2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200519_235505_965596_4504F68D X-CRM114-Status: UNSURE ( 9.13 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joerg Roedel , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2020-05-19 at 15:28 +0200, Joerg Roedel wrote: > From: Joerg Roedel > > The .probe_finalize() call-back of some IOMMU drivers calls into > arm_iommu_attach_device(). This function will call back into the > IOMMU core code, where it tries to take group->mutex again, resulting > in a deadlock. > > As there is no reason why .probe_finalize() needs to be called under > that mutex, move it after the lock has been released to fix the > deadlock. > > Cc: Yong Wu > Reported-by: Yong Wu > Fixes: deac0b3bed26 ("iommu: Split off default domain allocation from group assignment") > Signed-off-by: Joerg Roedel Tested-by: Yong Wu Tested on MediaTek-v1 mt2701 evb board. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel