From: Martin Botka <martin.botka@somainline.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Yangtao Li <tiny.windzz@gmail.com>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org,
Andre Przywara <andre.przywara@arm.com>,
Alan Ma <tech@biqu3d.com>,
Luke Harrison <bttuniversity@biqu3d.com>,
Marijn Suijten <marijn.suijten@somainline.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rogerio Goncalves <rogerlz@gmail.com>,
Martin Botka <martin@biqu3d.com>
Subject: Re: [PATCH 5/6] arm64: dts: allwinner: h616: Add CPU Operating Performance Points table
Date: Mon, 04 Sep 2023 21:43:49 +0200 [thread overview]
Message-ID: <158H0S.OVEJGSQROBDV1@somainline.org> (raw)
In-Reply-To: <a6c074ec-81d6-4fde-98c7-fc2750483514@linaro.org>
On Mon, Sep 4 2023 at 09:33:33 PM +02:00:00, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> On 04/09/2023 17:57, Martin Botka wrote:
>> Add an Operating Performance Points table for the CPU cores to
>> enable Dynamic Voltage & Frequency Scaling on the H616.
>>
>
> ...
>
>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
>> b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
>> index 063db9634e5f..78e79c591dba 100644
>> --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
>> @@ -143,6 +143,10 @@ sid: efuse@3006000 {
>> ths_calibration: thermal-sensor-calibration@14 {
>> reg = <0x14 0x8>;
>> };
>> +
>> + cpu_speed_grade: cpu_speed_grade@0 {
>
> Underscores are no allowed in node names.
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
I actually did. And did rerun it just now to check. No error or warning
was reported by dtbs_check W=1 for this.
But I will correct it in V2 and look if my setup is doing something
wrong that its not reporting these issues.
Cheers,
Martin
>
> Best regards,
> Krzysztof
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-04 19:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 15:57 [PATCH 0/6] cpufreq for H616 Martin Botka
2023-09-04 15:57 ` [PATCH 1/6] firmware: smccc: Export revision soc_id function Martin Botka
2023-09-04 15:57 ` [PATCH 2/6] cpufreq: dt-platdev: Blocklist allwinner,h616 SoC Martin Botka
2023-09-04 20:40 ` Andre Przywara
2023-09-06 0:59 ` Icenowy Zheng
2023-09-25 8:59 ` Andre Przywara
2023-09-04 15:57 ` [PATCH 3/6] dt-bindings: opp: Add compatible for H616 Martin Botka
2023-09-04 19:31 ` Krzysztof Kozlowski
2023-09-04 19:32 ` Krzysztof Kozlowski
2023-09-04 19:48 ` Martin Botka
2023-09-04 19:53 ` Krzysztof Kozlowski
2023-09-04 20:06 ` Martin Botka
2023-09-04 19:52 ` Martin Botka
2023-09-04 15:57 ` [PATCH 4/6] cpufreq: sun50i: Add H616 support Martin Botka
2023-09-04 19:28 ` Martin Botka
2023-09-04 20:41 ` Andre Przywara
2023-09-04 20:44 ` Martin Botka
2023-09-25 8:59 ` Andre Przywara
2023-09-04 15:57 ` [PATCH 5/6] arm64: dts: allwinner: h616: Add CPU Operating Performance Points table Martin Botka
2023-09-04 19:33 ` Krzysztof Kozlowski
2023-09-04 19:43 ` Martin Botka [this message]
2023-09-04 15:57 ` [PATCH 6/6] arm64: dts: allwinner: h616: Add cooling cells Martin Botka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158H0S.OVEJGSQROBDV1@somainline.org \
--to=martin.botka@somainline.org \
--cc=andre.przywara@arm.com \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bttuniversity@biqu3d.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=lpieralisi@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mark.rutland@arm.com \
--cc=martin@biqu3d.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rogerlz@gmail.com \
--cc=samuel@sholland.org \
--cc=sudeep.holla@arm.com \
--cc=tech@biqu3d.com \
--cc=tiny.windzz@gmail.com \
--cc=viresh.kumar@linaro.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox