From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB0F4C71153 for ; Mon, 4 Sep 2023 19:44:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Cc:To :Subject:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6H4B9LMNm0Gi0bo0upM0VuLtA7+q866sBMeV7ajm+Dk=; b=NcdoJEhWuJlSNSW19aAqii3soe kwLiP6alm9wfLgEOLOezmH1VDFhnnFwukbYSfZIDvzMyunfHYr8iX9cNb7nf0RUp521JERDsilWcL hRdyHvJionaChv1ePcWy8pCx4wrOe75TDYVeK3mvk7f9gbP0aTZZ/oKy4TIYGTyB/H1wMsyf/7JUJ gOWkh2eb3Yyq/VmLCj2SDXbWQYTvaUqJmee5lPYfTvyq2FH9nUjOcf/csl+DR0TPwNuAY8jADG8BO KmQYnTGDstKTDfq1ZQqwRUmz5r2pWh3UokodsqGr0OcSumkK+htcLBYQIxwvvBC6vBHiE99pxss9P 5vWTZIVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qdFUW-004iEX-0A; Mon, 04 Sep 2023 19:44:08 +0000 Received: from relay06.th.seeweb.it ([2001:4b7a:2000:18::167]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qdFUS-004iDo-37 for linux-arm-kernel@lists.infradead.org; Mon, 04 Sep 2023 19:44:06 +0000 Received: from [192.168.2.144] (bband-dyn191.178-41-225.t-com.sk [178.41.225.191]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id B39993F289; Mon, 4 Sep 2023 21:43:56 +0200 (CEST) Date: Mon, 04 Sep 2023 21:43:49 +0200 From: Martin Botka Subject: Re: [PATCH 5/6] arm64: dts: allwinner: h616: Add CPU Operating Performance Points table To: Krzysztof Kozlowski Cc: Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , "Rafael J. Wysocki" , Viresh Kumar , Yangtao Li , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, Andre Przywara , Alan Ma , Luke Harrison , Marijn Suijten , AngeloGioacchino Del Regno , Konrad Dybcio , Rogerio Goncalves , Martin Botka Message-Id: <158H0S.OVEJGSQROBDV1@somainline.org> In-Reply-To: References: <20230904-cpufreq-h616-v1-0-b8842e525c43@somainline.org> <20230904-cpufreq-h616-v1-5-b8842e525c43@somainline.org> X-Mailer: geary/43.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230904_124405_180498_D8B80B5E X-CRM114-Status: GOOD ( 15.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 4 2023 at 09:33:33 PM +02:00:00, Krzysztof Kozlowski wrote: > On 04/09/2023 17:57, Martin Botka wrote: >> Add an Operating Performance Points table for the CPU cores to >> enable Dynamic Voltage & Frequency Scaling on the H616. >> > > ... > >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi >> b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi >> index 063db9634e5f..78e79c591dba 100644 >> --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi >> @@ -143,6 +143,10 @@ sid: efuse@3006000 { >> ths_calibration: thermal-sensor-calibration@14 { >> reg = <0x14 0x8>; >> }; >> + >> + cpu_speed_grade: cpu_speed_grade@0 { > > Underscores are no allowed in node names. > > It does not look like you tested the DTS against bindings. Please run > `make dtbs_check W=1` (see > Documentation/devicetree/bindings/writing-schema.rst or > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ > for instructions). I actually did. And did rerun it just now to check. No error or warning was reported by dtbs_check W=1 for this. But I will correct it in V2 and look if my setup is doing something wrong that its not reporting these issues. Cheers, Martin > > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel