From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: IRQ masking hierarchy with GIC as the root
Date: Mon, 6 Feb 2017 13:40:39 +0000 [thread overview]
Message-ID: <158e22d4-9864-a788-d4fd-576b3531ae22@arm.com> (raw)
In-Reply-To: <1486383720.2275.22.camel@pengutronix.de>
On 06/02/17 12:22, Lucas Stach wrote:
> Hi Marc and others,
>
> in the conversion of the old GIC arch_extension to proper stacked IRQ
> domain chips you added calls to irq_chip_mask_parent() to both the Tegra
> LIC (drivers/irqchip/irq-tegra.c) and the i.MX GPC
> (arch/arm/mach-imx/gpc.c).
>
> Both IRQ controllers should be able to mask the IRQ on their own,
> meaning the IRQ will not reach the GIC if it is masked at this hierarchy
> level. Is it safe to remove the the call to mask the IRQ at the GIC
> level, or is there something more to it that I don't (yet) see?
It should be safe, as long as you can guarantee that the LIC (resp. the
GPC) is always active between the device and the GIC (it never goes in
some bypass mode). If that condition holds, you can then cut it short.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
prev parent reply other threads:[~2017-02-06 13:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 12:22 IRQ masking hierarchy with GIC as the root Lucas Stach
2017-02-06 13:40 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158e22d4-9864-a788-d4fd-576b3531ae22@arm.com \
--to=marc.zyngier@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox