From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCA4AC433DF for ; Mon, 25 May 2020 10:03:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7844F207FB for ; Mon, 25 May 2020 10:03:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qR1LBgvb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="YoeaMU/S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7844F207FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E1GVH9XPn5Z7AlbApNUbvpJ7c8SEhjlZpCEM7cVVBeg=; b=qR1LBgvbG0M6FC R/5SzcQBEvYKMvXG8p9PZUYSHYxi5jhHhYAGPWE7h1COfZ/OBxY9ztF+H73h+OfCGiknC+EMoFy0e fwvwYxg3e0ZUCyNE/diQNHHjtUykVyNM25JsT5U8JLVE7nzVmZTmc8AMTWBwEysfVrV6R721WfLjZ OaG3oRwiyXipcfXQlZ3a9Gbn5N8r2cA77uqO6yCSRJ6YA/KNLX8B9Oa0aDYCMZCBVTF5/LbYMHKEk E+xrgjagofRq+RZGCXhAtIZA8XPsSVMl54uQHBrpekKOdOn4oyc4qVWmj+SfDqwqG++J/je0PrxHL 44lAE6O/mrMP75errQDA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jd9ws-0008Eo-1R; Mon, 25 May 2020 10:03:10 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jd9wo-0008EP-V7 for linux-arm-kernel@lists.infradead.org; Mon, 25 May 2020 10:03:08 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4FBA22078B; Mon, 25 May 2020 10:03:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590400986; bh=QWmuTSIms62P0ZYptnY7ALuk/JmBEu/4ATlRN4c6WG0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YoeaMU/SbkGTLQ6xEGnChjsBOp7rUe0dCs/y8iSUU/j0luFmUeT6GKsjn3haZyRtj esNhyCzUmzfMJr3FIkTfhh/xvomBTNj9kwLz2NvBBCfjaLAU+uPkfumTxgUwvYIC1p YCGQ1+5H4EtfEf49lgv2DmL8Doeg63qBXnKuGnxE= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jd9wm-00F7o7-Fo; Mon, 25 May 2020 11:03:04 +0100 From: Marc Zyngier To: linux-kernel@vger.kernel.org, Valentin Schneider , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] irqchip/gic-v2, v3: Drop extra IRQ_NOAUTOEN setting for (E)PPIs Date: Mon, 25 May 2020 11:02:59 +0100 Message-Id: <159040068512.385398.8830285697021452481.b4-ty@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200521223500.834-1-valentin.schneider@arm.com> References: <20200521223500.834-1-valentin.schneider@arm.com> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, valentin.schneider@arm.com, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de, jason@lakedaemon.net X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200525_030307_021303_94068ACA X-CRM114-Status: GOOD ( 11.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Gleixner , Jason Cooper Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 21 May 2020 23:35:00 +0100, Valentin Schneider wrote: > (E)PPIs are per-CPU interrupts, so we want each CPU to go and enable them > via enable_percpu_irq(); this also means we want IRQ_NOAUTOEN for them as > the autoenable would lead to calling irq_enable() instead of the more > appropriate irq_percpu_enable(). > > Calling irq_set_percpu_devid() is enough to get just that since it trickles > down to irq_set_percpu_devid_flags(), which gives us IRQ_NOAUTOEN (and a > few others). Setting IRQ_NOAUTOEN *again* right after this call is just > redundant, so don't do it. > > [...] Applied to irq/irqchip-next, thanks! [1/1] irqchip/gic-v2, v3: Drop extra IRQ_NOAUTOEN setting for (E)PPIs commit: cc86432aa8cc5a81f99d79eea2a29099da694df3 Cheers, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel