From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2667C433E0 for ; Thu, 28 May 2020 08:26:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86041208DB for ; Thu, 28 May 2020 08:26:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IEOehhe5"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="h2EeOBV8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86041208DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=onEeMv8S2eS1WESArLsRmzRcEn/DDy/fkNvECOjGeqY=; b=IEOehhe5kVAlXd 6ZUAAsZ5Z6QRLI/RxMGERtIfYF2uJpBeO8qqfZceOEY19w+Ce+Yo+m+xuFZEaq+tmKLUe/uRjFEdY F1/CBkIGJ1nGiGdbY369hXpHIuyfFP5ZyE6Ca6uriebXBMXACJqsUfPfEtc4osmOvEaipblzjChgA gzjXzoefCaw4pE0LsO8lj9OO+/24tlPqRrLID0d0Z5204wwP35V341CX0vSoqCgHNfC8BftDr6c3i GXmRywc3A+cdevxTts2e+yNyQNcxIH6nvGNTKZAALEdvM2hk+yNLDdVDwkqJKGLEGW5xAgeTbYAQx Kc+GlUQuH1yJoWl3mmKQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeDrc-0008Q3-48; Thu, 28 May 2020 08:26:08 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeDrX-0008OH-1Y; Thu, 28 May 2020 08:26:05 +0000 X-UUID: 22d8ed630fab4638868af72fcd634293-20200528 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=uhdAfcZAWfW+nRXgN3wGGFlouEdWIR+NISZcKKtGAks=; b=h2EeOBV8u9OriQH6KN1vhHH8KUM+w8DmaHa9hmxcwQhVUgnLv7AU800d9LKoURRCOmDi5lB3ZBoemF0Sch9yVbiTU0fWcn9gFSK894cHCjmV+8PUpNaHY8c1RQEiznsRb8W+2vkWZa6CSPNNvSHVYVA9Il+p1pp5h8Y3nRepnyY=; X-UUID: 22d8ed630fab4638868af72fcd634293-20200528 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 540698221; Thu, 28 May 2020 00:26:08 -0800 Received: from MTKMBS02N1.mediatek.inc (172.21.101.77) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 28 May 2020 01:25:07 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 28 May 2020 16:25:01 +0800 Received: from [10.15.20.246] (10.15.20.246) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 28 May 2020 16:25:00 +0800 Message-ID: <1590654061.15483.5.camel@mbjsdccf07> Subject: Re: [PATCH v10] Add matrix keypad driver support for Mediatek SoCs From: fengping.yu To: Marco Felsch Date: Thu, 28 May 2020 16:21:01 +0800 In-Reply-To: <20200528071916.2zxch46lbimxet2u@pengutronix.de> References: <20200528053344.25936-1-fengping.yu@mediatek.com> <20200528071916.2zxch46lbimxet2u@pengutronix.de> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200528_012603_101461_8EF865FE X-CRM114-Status: GOOD ( 13.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dmitry Torokhov , linux-mediatek@lists.infradead.org, linux-input@vger.kernel.org, Yingjoe Chen , Andy Shevchenko , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marco: I am sorry, I think I misunderstand your suggestion about wakeup member in patch v9. Keypad is a wakeup source, so I mis-remove wakeup source setting in the probe function. I will modify this in the next patch. Thanks. On Thu, 2020-05-28 at 09:19 +0200, Marco Felsch wrote: > Hi, > > this version looks nice to me =) One last question. > > On 20-05-28 13:33, Fengping Yu wrote: > > > > Change since v9: > > - modify KEYBOARD_MTK_KPD config dependent item > > - remove wakeup member of mtk_keypad struct > > You also removed the device wakeup capability completely, was this > intended? What I mean is that we don't need that member within the > driver state struct. > > Regards, > Marco > > > - remove default pinctrl state set > > - modify request irq failed return value > > - add space of kepad matching table > > - modify align issue > > > > fengping.yu (3): > > dt-bindings: Add keypad devicetree documentation > > drivers: input: keyboard: Add mtk keypad driver > > configs: defconfig: Add CONFIG_KEYBOARD_MTK_KPD=m > > > > .../devicetree/bindings/input/mtk-kpd.yaml | 95 +++++++++ > > arch/arm64/configs/defconfig | 1 + > > drivers/input/keyboard/Kconfig | 11 + > > drivers/input/keyboard/Makefile | 1 + > > drivers/input/keyboard/mtk-kpd.c | 201 ++++++++++++++++++ > > 5 files changed, 309 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.yaml > > create mode 100644 drivers/input/keyboard/mtk-kpd.c > > > > -- > > 2.18.0 > > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel