Re: [PATCH v10] Add matrix keypad driver support for Mediatek SoCs

fengping.yu
2020-05-28T08:26:18Z

Hi Marco:

I am sorry, I think I misunderstand your suggestion about wakeup member
in patch v9.

Keypad is a wakeup source, so I mis-remove wakeup source setting in the
probe function.

I will modify this in the next patch.

Thanks.

On Thu, 2020-05-28 at 09:19 +0200, Marco Felsch wrote:
> Hi,
>
> this version looks nice to me =) One last question.
>
> On 20-05-28 13:33, Fengping Yu wrote:
> >
> > Change since v9:
> > - modify KEYBOARD_MTK_KPD config dependent item
> > - remove wakeup member of mtk_keypad struct
>
> You also removed the device wakeup capability completely, was this
> intended? What I mean is that we don't need that member within the
> driver state struct.
>
> Regards,
> Marco
>
> > - remove default pinctrl state set
> > - modify request irq failed return value
> > - add space of kepad matching table
> > - modify align issue
> >
> > fengping.yu (3):
> > dt-bindings: Add keypad devicetree documentation
> > drivers: input: keyboard: Add mtk keypad driver
> > configs: defconfig: Add CONFIG_KEYBOARD_MTK_KPD=m
> >
> > .../devicetree/bindings/input/mtk-kpd.yaml | 95 +++++++++
> > arch/arm64/configs/defconfig | 1 +
> > drivers/input/keyboard/Kconfig | 11 +
> > drivers/input/keyboard/Makefile | 1 +
> > drivers/input/keyboard/mtk-kpd.c | 201 ++++++++++++++++++
> > 5 files changed, 309 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.yaml
> > create mode 100644 drivers/input/keyboard/mtk-kpd.c
> >
> > --
> > 2.18.0
> >
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek