From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57D2BC433DF for ; Fri, 12 Jun 2020 08:15:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27934207ED for ; Fri, 12 Jun 2020 08:15:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="F7mSlsX3"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="fL52jjGy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27934207ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mQb5WHAmTJdsgqY9Pcei/rR2+upPZ7RFxYd8LyoNOjU=; b=F7mSlsX3a0nknd g0iyZKzy5v9ldulN2/HaKSKcZnR/ETR2wHXisvnPTwlEppNwEc2V7Ltg5ARcz/6DBHON2wcUsBuJ5 +YD8eM6PdowRzTTK/RbQseeoVMgQ1KFJfjRTt9gWDCWRup8OQaFTjq/h5wQO21/TOkBeyU6TYpAvj ZSNu5vPxdzzp2CMu4zWDX7MkuoxHBud0RBA+FT0Og/wwSl1AdiIo5hOoCxuAXKIgOslK5qW0lw6sK gx2r/uMvEwS4cvkasy0FIOAWB2cmVTPdHHNK6fTAqinYSf8vdU9zobirITRtc5gB6pk/sm384s0mh OsprTGn7x/tFKv9CRKQA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jjeqS-0004uD-UV; Fri, 12 Jun 2020 08:15:24 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jjeqO-0004so-9h; Fri, 12 Jun 2020 08:15:23 +0000 X-UUID: 4db2162223dd42808ecd5adce96d9bc0-20200612 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=UMgcVfDJy2DNtueEsKv2oMpjTkk90WFRphgVGkekQiE=; b=fL52jjGyd7Q36ByJ4RxJqGCLiDVVn81WhjD37xSdQanH9IBsmmG8C8+ZaFwkMo5a7AcQNr+fsJijJH2decJIMcXqYHKTuhvNoCt5mMEa6P4CzMsF8Es+qIdRHxEDpqIdOP/oeEkG47GBDqriRl644Su+XLUT6w00FyFqvTVPOQc=; X-UUID: 4db2162223dd42808ecd5adce96d9bc0-20200612 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1660008849; Fri, 12 Jun 2020 00:15:11 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 12 Jun 2020 01:12:58 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 12 Jun 2020 16:12:57 +0800 Received: from [172.21.77.33] (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 12 Jun 2020 16:12:56 +0800 Message-ID: <1591949578.23595.8.camel@mtkswgap22> Subject: Re: [PATCH v4 3/4] dmaengine: mediatek-cqdma: fix compatible From: EastL To: Matthias Brugger Date: Fri, 12 Jun 2020 16:12:58 +0800 In-Reply-To: References: <1590659832-31476-1-git-send-email-EastL.Lee@mediatek.com> <1590659832-31476-4-git-send-email-EastL.Lee@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200612_011521_847961_C7EE71DF X-CRM114-Status: GOOD ( 16.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, wsd_upstream@mediatek.com, Sean Wang , linux-kernel@vger.kernel.org, vkoul@kernel.org, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2020-05-28 at 15:39 +0200, Matthias Brugger wrote: > > On 28/05/2020 11:57, EastL wrote: > > This patch fixes mediatek-cqdma compatible to common. > > > > Signed-off-by: EastL > > --- > > drivers/dma/mediatek/mtk-cqdma.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/dma/mediatek/mtk-cqdma.c b/drivers/dma/mediatek/mtk-cqdma.c > > index 905bbcb..bca7118 100644 > > --- a/drivers/dma/mediatek/mtk-cqdma.c > > +++ b/drivers/dma/mediatek/mtk-cqdma.c > > @@ -544,7 +544,7 @@ static void mtk_cqdma_hw_deinit(struct mtk_cqdma_device *cqdma) > > } > > > > static const struct of_device_id mtk_cqdma_match[] = { > > - { .compatible = "mediatek,mt6765-cqdma" }, > > + { .compatible = "mediatek,cqdma" }, > > We can't just delete and old compatible. If other cqdma IP blocks are the same > as mt6795, we should instead add entries in the binding description with > fallback compatible. For example for mt6779 the DTS would look like this: > compatible = "mediatek,mt6779-cqdma", "mediatek,mt6765-cqdma"; > > This way we the kernel will take care to bind the device against the driver with > mt7665-cqdma, but leaves us the posibillity to add any changes to the driver in > the future if we find some bugs/features for mt6779 that are not present in mt6765. > > Regards, > Matthias > > > { /* sentinel */ } > > }; > > MODULE_DEVICE_TABLE(of, mtk_cqdma_match); > > OK, Can I add a common compatible? Like this static const struct of_device_id mtk_cqdma_match[] = { { .compatible = "mediatek,mt6765-cqdma" }, { .compatible = "mediatek,common-cqdma" }, Regards, EastL _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel