RE: [PATCH] drivers/perf: hisi: Add identifier sysfs file

Joakim Zhang
2020-07-15T08:46:02Z

> -----Original Message-----
> From: John Garry <john.garry@huawei.com>
> Sent: 2020年7月15日 16:23
> To: Will Deacon <will@kernel.org>
> Cc: zhangshaokun@hisilicon.com; mark.rutland@arm.com;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Joakim
> Zhang <qiangqing.zhang@nxp.com>; jolsa@redhat.com;
> linuxarm@huawei.com
> Subject: Re: [PATCH] drivers/perf: hisi: Add identifier sysfs file
>
> Hi Will,
>
> >
> > On Wed, Jun 17, 2020 at 09:05:11PM +0800, John Garry wrote:
> >> To allow userspace to identify the specific implementation of the
> >> device, add an "identifier" sysfs file.
> >>
> >> Encoding is as follows:
> >> hi1620: 0x0 (aka hip08)
> >> hi1630: 0x30
> >>
> >> Signed-off-by: John Garry <john.garry@huawei.com>
> >
> > I'm struggling a bit to track this. If you still think it's worth
> > pursuing, please could you post a series with a cover-letter
> > describing what this is for, a link to the userspace changes and then
> > patches for all the PMU drivers that need updating?
>
> There is no hi1630 userspace support yet.
>
> So what I can do is post updated userspace support (including hi1630), and
> then post kernel parts together for all drivers we could initially support.
>
> @Joakim, I'll pick your imx driver changes here, if you don't mind.

Of course you can.

Best Regards,
Joakim Zhang
> There was an RFC from you for the SMMUv3 PMU as
> > well, and also some other "arm64" changes.
> >
>
> I hope to drop that RFC if an updated SMMUv3 spec helps us out.
>
> Cheers,
> John