From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35138C433E0 for ; Tue, 30 Jun 2020 14:22:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03DE020672 for ; Tue, 30 Jun 2020 14:22:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="O5EfMmJB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="GVVje8vy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03DE020672 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Pur5kDCaXpF6jb1gHjc9tC8ytW8lYaI5EA8sN3Ss6j8=; b=O5EfMmJBIuEFtelHEdM27nShw fDFqhkif7DmhiWGOXkv/U4YRPNkBxAclPpyzyuhQxPCf84h7Gn+STplrkM6yyeZWOono8Iwo5KbXl Hn/XYS1lXx5Pw1l5mjdbSwqk3KnvQO4reO/mtiy+qFpa4oolsIbRDOeBbSGIAFDD3KcPwQ/wcmZ62 +5P5jFjli72KsPT7nUCTSu8JaaxA5RaB7CeNcN2l9rRGXiDVODGRAx0SmPf4CYL4HJKx/Naer0Gh4 kqnkj5lRtplST/hPBgP1E9Tr7luSoJbRKFqmHaJZGWYB//o4q1Dt3/sZp06XEIrUeLA97t4k+hCuz YaYzoHFGg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqH8F-0002LK-VF; Tue, 30 Jun 2020 14:21:08 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqH8C-0002K7-Ag; Tue, 30 Jun 2020 14:21:05 +0000 X-UUID: 49d4f14ee8c34161850c60608a55e44b-20200630 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=cxMnMMWUcVlBq3TyW4cE97CM4bI+Rge6V0CEfuXLJSs=; b=GVVje8vy47V91iiWKK/nPY7B2b5015LBDU7sMrA53GVdlYsnxBIBsng+47QeeH+E5YQ2UwykS2bVR74JAbiU6Qvl4E7sXk5xBzTKlEIvdulUP8f/DoAgZxL1twSFEpQmLLnDwDth+Vnucv2Nsa++zvlnmbQG9mr13iQhTFmRvTY=; X-UUID: 49d4f14ee8c34161850c60608a55e44b-20200630 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 118298364; Tue, 30 Jun 2020 06:20:50 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 30 Jun 2020 07:10:51 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 30 Jun 2020 22:10:50 +0800 Received: from [172.21.84.99] (172.21.84.99) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 30 Jun 2020 22:10:50 +0800 Message-ID: <1593526253.29676.28.camel@mtksdccf07> Subject: Re: [RFC PATCH V4 0/4] media: platform: Add support for Face Detection (FD) on mt8183 SoC From: Jerry-ch Chen To: Tomasz Figa Date: Tue, 30 Jun 2020 22:10:53 +0800 In-Reply-To: <20200521183825.GB249683@chromium.org> References: <20191204124732.10932-1-Jerry-Ch.chen@mediatek.com> <1588903371.16825.14.camel@mtksdccf07> <20200521183825.GB249683@chromium.org> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Sean Cheng =?UTF-8?Q?=28=E9=84=AD=E6=98=87=E5=BC=98=29?= , "laurent.pinchart+renesas@ideasonboard.com" , "zwisler@chromium.org" , srv_heupstream , Christie Yu =?UTF-8?Q?=28=E6=B8=B8=E9=9B=85=E6=83=A0=29?= , jerry-ch.chen@mediatek.com, HansVerkuil , Jungo Lin =?UTF-8?Q?=28=E6=9E=97=E6=98=8E=E4=BF=8A=29?= , Sj Huang =?UTF-8?Q?=28=E9=BB=83=E4=BF=A1=E7=92=8B=29?= , "yuzhao@chromium.org" , "hans.verkuil@cisco.com" , "pihsun@chromium.org" , Frederic Chen =?UTF-8?Q?=28=E9=99=B3=E4=BF=8A=E5=85=83=29?= , "matthias.bgg@gmail.com" , "linux-mediatek@lists.infradead.org" , "mchehab@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tomasz, On Thu, 2020-05-21 at 18:38 +0000, Tomasz Figa wrote: > Hi Jerry, > > On Wed, May 13, 2020 at 11:45:37PM +0200, Tomasz Figa wrote: > > Hi Jerry, > > > > On Fri, May 8, 2020 at 4:03 AM Jerry-ch Chen wrote: > > > > > > Hi Laurent, Tomasz, Matthias, > > > > > > gentle ping for this patch set, > > > If no new comments, I would like to send a newer version. > > > > > > > Sorry, I still haven't had a chance to look at the series, so feel > > free to send a new version and I will take a look at the new one. > > > > Finally found some time to review the series. Again sorry for the delay > and thanks for your patience. > > Some general comments: > 1) The metadata format FourCC should be added in a separate patch, > together with documentation for it. > 2) Control IDs, structs used by the userspace, etc. should be defined in > a header under include/uapi/linux. > > Please also check my replies to particular patches for further comments. > > Best regards, > Tomasz Appreciate for your reply, So far, I've locally created an uapi header: include/uapi/linux/mtk_fd_40.h which provides some values, control ids, and the definitions of structures that would be needed by user of mtk_fd_40 driver. In addition, I also provide a MACRO as example in comments that can extract the struct member with bit length and offset definitions(eliminate the bit-fields). Also, I would like to rename struct fd_user_output with struct mtk_fd_hw_result. I worry fd_user_output would be a confusing name. I will add them in a separate patch in next version. I am still working on the documentation, which might be Documentation/media/uapi/v4l/pixfmt-meta-mtk-fd-40.rst. Refering the other pixfmt-*.rst files, I will try to provide the flat-table of the metadata with the structure of the mtk_fd_hw_result. I am confusing that should I remain the name with -40 in the tail of rst file? Since I think the layout of metadata might be different in the future mtk fd drivers. Maybe they create a new one or should they update the rst file when they are upstreaming? Other comments are almost fixed, I will inform you by this mail thread as soon as I finish the documentation of fd metadata format. Sorry for the late response, Thanks and Best Regards, Jerry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel