From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 431A6C433DF for ; Fri, 3 Jul 2020 00:17:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11DB62073E for ; Fri, 3 Jul 2020 00:17:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JVco1I4Q"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LSEdiF8O" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11DB62073E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:MIME-Version:In-Reply-To:References:To: Subject:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=htaOGbrre+QtlxYdTHcMb6psPamav4Ye7j1/wCO4/64=; b=JVco1I4QAx810SA26Eb75WfcB 5Kewxkpn9sPi7K8iAqdJPFA5rNqKqFx/5nV9xZuOCnubYCwpFMrAfKiyXMlbXj2/CQ+nkahZsivSg kJ6ZWVzumYfuZ0EK70pywPqHMwPu1zmMfnH33Q+0HqvCwtieVDAgqx7z0Kc3/OBP2+mITW/ThOZgC ZDhdhTfmQa1CJ3amelxb+WIwR8sQJYx2aAyR8WEOGgIIH5fyz1lzNT9EM9BbHlwHahuT81N9+5CfT m/yD4iipTReFTlhTxDraZ3EMmnjJP3Gjo/k+MS+X8oih9duX8zHlk63TOD6YJG/KmNBhRwtbsZTiK OyZ+Lqwxg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr9Mo-0007kE-9G; Fri, 03 Jul 2020 00:15:46 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr9Ml-0007jW-Cc for linux-arm-kernel@lists.infradead.org; Fri, 03 Jul 2020 00:15:44 +0000 Received: by mail-pl1-x644.google.com with SMTP id p1so2671872pls.4 for ; Thu, 02 Jul 2020 17:15:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=nuJRvdB0NXvVZz7pZcV4N1oDW2dnoBAuVAW0OAoXK2w=; b=LSEdiF8O8c0k36FJz+J/p1Xm+032fT22eON16GPFoOrZL6GDx9jPsHusIL7FEU0XAV lLDoHY9NSZfpcd5oNSgz7AXGqRLd1dfAW9ad86/buGeCa4uTE/vU9OPIKwfaZyBXfnsJ uG05dXYdVlfndLY83LDfB7lzK6ZqRQP5RvYyTLEoAscx9LtDbk1kTfrj/Cwbbvqz6uxW IUIYgXT0pd0DwhOqvL6wEv82lwldnFjq8WUAnvh0BthjGb+v++4h6R72lTgxl5Ir5SPV KaijBTzwUbf0D6ex6rU/rFRlvvyVHMSFetaS1LKZRTYt3D1mhdMNSiJCFStkUNFQKfnS w0+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=nuJRvdB0NXvVZz7pZcV4N1oDW2dnoBAuVAW0OAoXK2w=; b=h56lFXAg6g4t0IAsj4Ui3vUXYiOyXOxu3tAVJNmZaCSA2/08NNk3VTdI+swAZfn71v r9o22r6N4CNkuDADJKOWA/DCB87beP5J1iFh0EoirRfasZbSvnK9l9ebVitXSIkB8KCP Of2BzVgZMeTGMApYvhrGG57bqXTaUGFb3mX4pzVmWK07ewQaNsDkiVHnOU5LBgMobfZX SlhqglDrp/2T1TleY3ICPl4LyH90C50YLJu2uI5Dvu+pbGfJiKycZ72KiMZ1Na5FpoAJ bimvMJYZWvL8Box3cZjDUteFkimCjzugbRABgfJi0ddUjTaqCKJVQjBMER8h5wrHIWW9 M1IA== X-Gm-Message-State: AOAM532brwXDnx3OXbVMPyQmAd5u6xHUrImkSfcUevDlgw5i1otWNzrf IGkdhc0mhuWLCqBUUyDUy9o= X-Google-Smtp-Source: ABdhPJzVARbnUoiUECgH/rt6gF7oxr/jO/Or3UFnEeEEE5zO8Q2uC+eAackVR4Z456AOo0TJ+H99Rw== X-Received: by 2002:a17:902:b78a:: with SMTP id e10mr28875186pls.34.1593735341316; Thu, 02 Jul 2020 17:15:41 -0700 (PDT) Received: from localhost (61-68-186-125.tpgi.com.au. [61.68.186.125]) by smtp.gmail.com with ESMTPSA id b11sm10202251pfr.179.2020.07.02.17.15.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 17:15:40 -0700 (PDT) Date: Fri, 03 Jul 2020 10:15:34 +1000 From: Nicholas Piggin Subject: Re: [PATCH v2 4/4] mm/vmalloc: Hugepage vmalloc mappings To: linux-mm@kvack.org, Zefan Li References: <20200413125303.423864-1-npiggin@gmail.com> <20200413125303.423864-5-npiggin@gmail.com> In-Reply-To: MIME-Version: 1.0 Message-Id: <1593735251.svr5r5cxle.astroid@bobo.none> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200702_201543_484370_F26A56CF X-CRM114-Status: UNSURE ( 8.99 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Will Deacon , Catalin Marinas , x86@kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , =?iso-8859-1?q?Borislav=0A?= Petkov , "H. Peter Anvin" , =?iso-8859-1?q?Thomas=0A?= Gleixner , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Excerpts from Zefan Li's message of July 1, 2020 5:10 pm: >> static void *__vmalloc_node(unsigned long size, unsigned long align, >> - gfp_t gfp_mask, pgprot_t prot, >> - int node, const void *caller); >> + gfp_t gfp_mask, pgprot_t prot, unsigned long vm_flags, >> + int node, const void *caller); >> static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, >> - pgprot_t prot, int node) >> + pgprot_t prot, unsigned int page_shift, >> + int node) >> { >> struct page **pages; >> + unsigned long addr = (unsigned long)area->addr; >> + unsigned long size = get_vm_area_size(area); >> + unsigned int page_order = page_shift - PAGE_SHIFT; >> unsigned int nr_pages, array_size, i; >> const gfp_t nested_gfp = (gfp_mask & GFP_RECLAIM_MASK) | __GFP_ZERO; >> const gfp_t alloc_mask = gfp_mask | __GFP_NOWARN; >> const gfp_t highmem_mask = (gfp_mask & (GFP_DMA | GFP_DMA32)) ? >> - 0 : >> - __GFP_HIGHMEM; >> + 0 : __GFP_HIGHMEM; >> >> - nr_pages = get_vm_area_size(area) >> PAGE_SHIFT; >> + nr_pages = size >> page_shift; > > while try out this patchset, we encountered a BUG_ON in account_kernel_stack() > in kernel/fork.c. > > BUG_ON(vm->nr_pages != THREAD_SIZE / PAGE_SIZE); > > which obviously should be updated accordingly. Thanks for finding that. We may have to change this around a bit so nr_pages still appears to be in PAGE_SIZE units for anybody looking. Thanks, Nick _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel