Re: [PATCH 2/2] soc: mediatek: devapc: add devapc-mt6779 driver

Randy Dunlap
2020-07-06T16:14:40Z

On 7/6/20 2:28 AM, Neal Liu wrote:
> diff --git a/drivers/soc/mediatek/devapc/Kconfig b/drivers/soc/mediatek/devapc/Kconfig
> new file mode 100644
> index 0000000..b0f7d0e
> --- /dev/null
> +++ b/drivers/soc/mediatek/devapc/Kconfig
> @@ -0,0 +1,17 @@
> +config MTK_DEVAPC
> + tristate "Mediatek Device APC Support"
> + help
> + Device APC is a HW IP controlling internal device security.

preferably: s/HW/hardware/

> + MediaTek bus frabric provides TrustZone security support and data

fabric

> + protection to prevent slaves from being accessed by unexpected
> + bus masters.
> + Device APC prevents malicious access to internal devices.
> +
> +config DEVAPC_MT6779
> + tristate "Mediatek MT6779 Device APC driver"
> + select MTK_DEVAPC
> + help
> + Say yes here to enable support Mediatek MT6779 Device APC driver.

support for Mediatek

> + This driver mainly used to handle the violation with 1 DEVAPC AO/PDs.

This driver is mainly used ^^^^^^^^^^^^^^^^

What is that meaningless string of chars? ^^^^^^^

> + The violation information are logged for further analysis or

is

> + countermeasures.

thanks.
--
~Randy