Re: [PATCH v7 2/8] cpufreq: mediatek: Enable clock and regulator

Viresh Kumar
2020-07-15T03:39:52Z

On 14-07-20, 21:18, andrew-sh.cheng wrote:
> On Mon, 2020-07-13 at 15:09 +0530, Viresh Kumar wrote:
> > On 10-07-20, 10:31, Andrew-sh.Cheng wrote:
> > > From: "Andrew-sh.Cheng" <andrew-sh.cheng@mediatek.com>
> > >
> > > Need to enable regulator,
> > > so that the max/min requested value will be recorded
> > > even it is not applied right away.
> > >
> > > Intermediate clock is not always enabled by ccf in different projects,
> > > so cpufreq should enable it by itself.
> > >
> > > Change-Id: I9f4c8b1ea793794f5f9cdc65427daad1393f5df8
> >
> > You are on V7 right now, these should have been gone long back.
>
> Hi Viresh,
> Sorry for forgetting to remove the change-ID message.
>
> >
> > > Signed-off-by: Andrew-sh.Cheng <andrew-sh.cheng@mediatek.com>
> > > ---
> > > drivers/cpufreq/mediatek-cpufreq.c | 33 +++++++++++++++++++++++++++++----
> > > 1 file changed, 29 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
> > > index 0c98dd08273d..4b479c110cc9 100644
> > > --- a/drivers/cpufreq/mediatek-cpufreq.c
> > > +++ b/drivers/cpufreq/mediatek-cpufreq.c
> > > @@ -350,6 +350,11 @@ static int mtk_cpu_dvfs_info_init(struct mtk_cpu_dvfs_info *info, int cpu)
> > > ret = PTR_ERR(proc_reg);
> > > goto out_free_resources;
> > > }
> > > + ret = regulator_enable(proc_reg);
> > > + if (ret) {
> > > + pr_warn("enable vproc for cpu%d fail\n", cpu);
> > > + goto out_free_resources;
> > > + }
> >
> > This is already done by the OPP core now.
>
> Do you mean I can use dev_pm_opp_set_regulators() and
> dev_pm_opp_set_rate() to do dvfs?
> Due to mediatek-cpufreq may change Vproc and Vsram by special flow, that
> is not suitable.

Sorry about that. I completely missed that you aren't using
dev_pm_opp_set_rate().

--
viresh