From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled
Date: Fri, 07 Aug 2015 13:12:56 +0200 [thread overview]
Message-ID: <1594902.Dv5JKhve0y@amdc1976> (raw)
In-Reply-To: <20150807104156.GE6939@linux>
On Friday, August 07, 2015 04:11:56 PM Viresh Kumar wrote:
> On 07-08-15, 12:34, Bartlomiej Zolnierkiewicz wrote:
> > > I would suggest you sending such patches as reply to the earlier
> > > threads only, instead of a new chain. This will save your time.
> >
> > Please explain it more. This patch needs to be first for cpufreq-dt
> > switch to be complete. scaling_boost_freqs is available currently
> > for exynos-cpufreq users when boost is enabled and ideally we would
> > like it to be available immediately after the switch to cpufreq-dt.
>
> I wasn't talking about the ordering of the patches here, but when to
> send patches.
>
> So, you now sent these patches again, but what you could have done
> is: only send the first patch in reply to the earlier thread. And ask
> if it looks fine. If yes, resend the whole series properly or keep
> fixing there only..
>
> That makes things really fast. You don't have to resend the series and
> people wouldn't stay away from it. I stayed away from this series to
> find enough available time to see your 6 patches. Had it been just a
> reply, I would have replied immediately like now.
>
> Look at how updated versions in the same mail chain in case of OPP
> series..
Please find updated patch below. It can be moved just before
patch #6 and all patches in the series would still apply fine.
---------------------8<-------------------
>From 993ebb6fc632ec7b61654c9610c90ff4dca4be34 Mon Sep 17 00:00:00 2001
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Date: Fri, 7 Aug 2015 13:07:51 +0200
Subject: [PATCH] cpufreq-dt: make scaling_boost_freqs sysfs attr available
when boost is enabled
Make scaling_boost_freqs sysfs attribute is available when
cpufreq-dt driver is used and boost support is enabled.
Cc: Thomas Abraham <thomas.ab@samsung.com>
Cc: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Suggested-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
drivers/cpufreq/cpufreq-dt.c | 11 ++++++++++-
include/linux/cpufreq.h | 1 +
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c
index b9259ab..c6a3b98 100644
--- a/drivers/cpufreq/cpufreq-dt.c
+++ b/drivers/cpufreq/cpufreq-dt.c
@@ -36,6 +36,12 @@ struct private_data {
unsigned int voltage_tolerance; /* in percentage */
};
+static struct freq_attr *cpufreq_dt_attr[] = {
+ &cpufreq_freq_attr_scaling_available_freqs,
+ NULL, /* Extra space for boost-attr if required */
+ NULL,
+};
+
static int set_target(struct cpufreq_policy *policy, unsigned int index)
{
struct dev_pm_opp *opp;
@@ -182,6 +188,8 @@ try_again:
return ret;
}
+static struct cpufreq_driver dt_cpufreq_driver;
+
static int cpufreq_init(struct cpufreq_policy *policy)
{
struct cpufreq_frequency_table *freq_table;
@@ -336,6 +344,7 @@ static int cpufreq_init(struct cpufreq_policy *policy)
ret = cpufreq_enable_boost_support();
if (ret)
goto out_free_cpufreq_table;
+ cpufreq_dt_attr[1] = &cpufreq_freq_attr_scaling_boost_freqs;
}
policy->cpuinfo.transition_latency = transition_latency;
@@ -411,7 +420,7 @@ static struct cpufreq_driver dt_cpufreq_driver = {
.exit = cpufreq_exit,
.ready = cpufreq_ready,
.name = "cpufreq-dt",
- .attr = cpufreq_generic_attr,
+ .attr = cpufreq_dt_attr,
};
static int dt_cpufreq_probe(struct platform_device *pdev)
diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
index 95f0186..657542d 100644
--- a/include/linux/cpufreq.h
+++ b/include/linux/cpufreq.h
@@ -609,6 +609,7 @@ struct cpufreq_frequency_table *cpufreq_frequency_get_table(unsigned int cpu);
/* the following are really really optional */
extern struct freq_attr cpufreq_freq_attr_scaling_available_freqs;
+extern struct freq_attr cpufreq_freq_attr_scaling_boost_freqs;
extern struct freq_attr *cpufreq_generic_attr[];
int cpufreq_table_validate_and_show(struct cpufreq_policy *policy,
struct cpufreq_frequency_table *table);
--
1.9.1
next prev parent reply other threads:[~2015-08-07 11:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 13:41 [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Bartlomiej Zolnierkiewicz
2015-08-06 13:41 ` [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled Bartlomiej Zolnierkiewicz
2015-08-07 3:41 ` Viresh Kumar
2015-08-07 10:34 ` Bartlomiej Zolnierkiewicz
2015-08-07 10:41 ` Viresh Kumar
2015-08-07 11:12 ` Bartlomiej Zolnierkiewicz [this message]
2015-08-07 11:37 ` Viresh Kumar
2015-08-07 22:21 ` Rafael J. Wysocki
2015-08-08 2:06 ` Viresh Kumar
2015-08-06 13:41 ` [PATCH v4 2/6] clk: samsung: exynos4x12: add cpu clock configuration data and instantiate cpu clock Bartlomiej Zolnierkiewicz
2015-08-25 18:40 ` Michael Turquette
2015-08-06 13:41 ` [PATCH v4 3/6] ARM: dts: Exynos4x12: add CPU OPP and regulator supply property Bartlomiej Zolnierkiewicz
2015-08-06 13:41 ` [PATCH v4 4/6] ARM: Exynos: switch to using generic cpufreq driver for Exynos4x12 Bartlomiej Zolnierkiewicz
2015-08-06 13:41 ` [PATCH v4 5/6] cpufreq: exynos: remove Exynos4x12 specific cpufreq driver support Bartlomiej Zolnierkiewicz
2015-08-06 13:41 ` [PATCH v4 6/6] cpufreq: remove no longer needed CPU_FREQ_BOOST_SW config option Bartlomiej Zolnierkiewicz
2015-08-07 4:31 ` Viresh Kumar
2015-08-06 23:53 ` [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Kukjin Kim
2015-08-07 3:50 ` Viresh Kumar
2015-08-07 3:51 ` Viresh Kumar
2015-08-07 4:13 ` Krzysztof Kozlowski
2015-08-07 4:30 ` Viresh Kumar
2015-08-07 4:52 ` Krzysztof Kozlowski
2015-08-07 5:18 ` Viresh Kumar
2015-08-07 11:31 ` Bartlomiej Zolnierkiewicz
2015-08-07 11:39 ` Viresh Kumar
2015-08-07 11:47 ` Bartlomiej Zolnierkiewicz
2015-08-07 11:56 ` Viresh Kumar
2015-08-07 22:24 ` Rafael J. Wysocki
2015-08-08 2:07 ` Viresh Kumar
2015-08-08 7:27 ` Krzysztof Kozlowski
2015-08-08 13:59 ` Viresh Kumar
2015-08-10 1:27 ` Kukjin Kim
2015-08-11 2:20 ` Krzysztof Kozlowski
2015-08-11 7:51 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1594902.Dv5JKhve0y@amdc1976 \
--to=b.zolnierkie@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox