From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF377C433DF for ; Mon, 20 Jul 2020 02:50:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA64220674 for ; Mon, 20 Jul 2020 02:50:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nYBL3Lno"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CdpDdzgw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA64220674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:MIME-Version:In-Reply-To:References:To: Subject:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nHCB47rw8TnbcPtLc1NpCfDTlCeK/PxfaQNAz4MZeqQ=; b=nYBL3Lnou+l0FVTfD/ocDgDf+ 8vPYa3ZI18ESHo08iOrPorc45Ez08YzxwCX5mR7htpF77tCCuv6loygShPsuyF71qKHzXmNrfXdgI RSeLq1iQ8ma5aLHvdsZ0S22fq1mVQLAsx6DdMCGmsHFHhZu9KYcXgp/CewfDtVGRsPJkKaDX9Lczh CnJItyQZcPp45qiMgtMaY/tGOGDw0bD0sWJ1moQI1hMfbF0NAGU8VijOEDArBOmtBci/dvdCd/A6/ SksENKUPwpXpoymUWeRwfzxb+rxsZmPz1EWqnmu2lqmcSi8HRzrNtrjPtbEVDCphuCyo3sK0vDAh5 kus7Tw9Ug==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxLrd-0007rZ-PW; Mon, 20 Jul 2020 02:49:13 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxLrb-0007qJ-7V for linux-arm-kernel@lists.infradead.org; Mon, 20 Jul 2020 02:49:12 +0000 Received: by mail-pl1-x642.google.com with SMTP id m16so8000742pls.5 for ; Sun, 19 Jul 2020 19:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=MHAQuV7wqFXE2gTJXyIGBJkkSS+/2fb6/SqEN+IMJpU=; b=CdpDdzgwHD6KDQNhDlu82DlmyWWjZ/tE6sKRBv4R+f6DNQQk3obKV028wEN8NHQe44 ivpvsS3MyhDPBNTyPoxFeJ7XFObRFd8p5lDUvQWmEZLORZNpDUmsYDtCQtQBjWEph5Jh 4UbuZHebtzX2AFmWHCKMSDCUU6CrNCv//mNYHHIp2g9SX31oJe5mi7j4eUwDehYc29+H ylq58SwOBe5p0fVnwPLea9PkWcZG7C43Si1MqGYbndJH1usUs612RiFtiYzoCGbhlNlq NNAAB8WinXGMNgzrYPheT/QyRtpMt8ZSuDngMgeue+/ZpaK+oENAp4e9Kc8cNPqxAKW8 HoTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=MHAQuV7wqFXE2gTJXyIGBJkkSS+/2fb6/SqEN+IMJpU=; b=shGmxWav0SuPjbC1oJiRYfA3y54i4sTOT580PycB+OOTcSj5flI5VR1TTVaUaAQaB+ n4uf322TM6FUWG4eVYPatR4G28iNbxm1uMl+SkMEgH6OPTIq5bArZn7b0y5jG8p7WqsP HyuMUeY7u+zF53Lhw9xte5uJaUaHgz6OljxpxpN/sjLVqbp+JvHl04XMSwW+NbWq3gho CgrIS41gq55Bb9HPUGfXEEuIVspaon0DOyqV2FHd4xM8CyxKThIziHt3U5uxTTQVxt/U IdONIaaPnsZMH9c+v8BeOsjLqiig+Vqh3lUtmjFhRnGJAb3yyfOPZBtcYrKHbNlC3QYo wrsA== X-Gm-Message-State: AOAM533K2+2e8ZMd2351TMkbYLo5H5zFX5Z+DXfc9aw3E+55WHvYW5vn t6hBtf4H5LvslCW8tt2QYOQ= X-Google-Smtp-Source: ABdhPJyKOJqndxCg3mIhcaYDZPJSsTmVuKMyFWNLPeExLhzmb2sdnZbuRmCL/dLOi+bJNfrzWai0hA== X-Received: by 2002:a17:90a:6448:: with SMTP id y8mr21541193pjm.142.1595213347563; Sun, 19 Jul 2020 19:49:07 -0700 (PDT) Received: from localhost (110-174-173-27.tpgi.com.au. [110.174.173.27]) by smtp.gmail.com with ESMTPSA id f131sm13389215pgc.14.2020.07.19.19.49.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2020 19:49:06 -0700 (PDT) Date: Mon, 20 Jul 2020 12:49:02 +1000 From: Nicholas Piggin Subject: Re: [PATCH v2 4/4] mm/vmalloc: Hugepage vmalloc mappings To: linux-mm@kvack.org, Zefan Li References: <20200413125303.423864-1-npiggin@gmail.com> <20200413125303.423864-5-npiggin@gmail.com> <0e43e743-7c78-fb86-6c36-f42e6184d32c@huawei.com> In-Reply-To: <0e43e743-7c78-fb86-6c36-f42e6184d32c@huawei.com> MIME-Version: 1.0 Message-Id: <1595213278.m30kayfsvu.astroid@bobo.none> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200719_224911_278914_6E2C2CE3 X-CRM114-Status: GOOD ( 10.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Will Deacon , Catalin Marinas , x86@kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , =?iso-8859-1?q?Borislav=0A?= Petkov , "H. Peter Anvin" , =?iso-8859-1?q?Thomas=0A?= Gleixner , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Excerpts from Zefan Li's message of July 20, 2020 12:02 pm: >> +static int vmap_pages_range_noflush(unsigned long start, unsigned long end, >> + pgprot_t prot, struct page **pages, >> + unsigned int page_shift) >> +{ >> + if (page_shift == PAGE_SIZE) { > > Is this a typo of PAGE_SHIFT? Oh good catch, yeah that'll always be going via the one-at-a-time route and slow down the small page vmaps. Will fix. Thanks, Nick > >> + return vmap_small_pages_range_noflush(start, end, prot, pages); >> + } else { >> + unsigned long addr = start; >> + unsigned int i, nr = (end - start) >> page_shift; >> + >> + for (i = 0; i < nr; i++) { >> + int err; >> + >> + err = vmap_range_noflush(addr, >> + addr + (1UL << page_shift), >> + __pa(page_address(pages[i])), prot, >> + page_shift); >> + if (err) >> + return err; >> + >> + addr += 1UL << page_shift; >> + } >> + >> + return 0; >> + } >> +} >> + > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel