From: lei liu <leilk.liu@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Mark Brown <broonie@kernel.org>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] spi: mediatek: add spi support for mt8192 IC
Date: Wed, 22 Jul 2020 16:38:47 +0800 [thread overview]
Message-ID: <1595407127.31408.3.camel@mhfsdcap03> (raw)
In-Reply-To: <27e48721-5e54-6947-cd8f-669f4da34c4d@gmail.com>
On Wed, 2020-07-22 at 00:44 +0200, Matthias Brugger wrote:
>
> On 21/07/2020 14:24, Leilk Liu wrote:
> > From: "leilk.liu" <leilk.liu@mediatek.com>
> >
> > This patch add spi support for mt8192 IC.
> >
> > Signed-off-by: leilk.liu <leilk.liu@mediatek.com>
> > ---
> > drivers/spi/spi-mt65xx.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c
> > index 6783e12c40c2..3d0d69fe0c69 100644
> > --- a/drivers/spi/spi-mt65xx.c
> > +++ b/drivers/spi/spi-mt65xx.c
> > @@ -170,6 +170,9 @@ static const struct of_device_id mtk_spi_of_match[] = {
> > { .compatible = "mediatek,mt8183-spi",
> > .data = (void *)&mt8183_compat,
> > },
> > + { .compatible = "mediatek,mt8192-spi",
> > + .data = (void *)&mt6765_compat,
> > + },
>
> That's not needed. We will use the fallback compatible which is
> "mediatek,mt6765-spi" which will take the correct DT data. If in the future we
> realize that mt8192 has a difference in the HW we can add the compatible.
> Otherwise with the binding description we should be fine
>
So you mean that only the following binding patch is needed?
[PATCH v2 1/2] dt-bindings: spi: update bindings for MT8192 SoC
> > {}
> > };
> > MODULE_DEVICE_TABLE(of, mtk_spi_of_match);
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-22 8:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 12:24 [PATCH v2 1/2] dt-bindings: spi: update bindings for MT8192 SoC Leilk Liu
2020-07-21 12:24 ` [PATCH v2 2/2] spi: mediatek: add spi support for mt8192 IC Leilk Liu
2020-07-21 22:44 ` Matthias Brugger
2020-07-22 8:38 ` lei liu [this message]
2020-07-22 10:38 ` Matthias Brugger
2020-07-22 10:39 ` [PATCH v2 1/2] dt-bindings: spi: update bindings for MT8192 SoC Matthias Brugger
2020-07-22 13:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1595407127.31408.3.camel@mhfsdcap03 \
--to=leilk.liu@mediatek.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox