From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52AE2C433E0 for ; Wed, 29 Jul 2020 08:47:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E072206D8 for ; Wed, 29 Jul 2020 08:47:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="3a5TS1i8"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="WTmhDVee" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E072206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EG/yqsr3s9jN+IC4D6Obc52yXRI53wEpzG0h863w02k=; b=3a5TS1i8BWLk0TiZAp96X7+pR u5VDqgpOH/kN5rP3qAEoCMcl98B5VIC14ED6CxSxYd46LJhDjwbQVMPCvdv/GNmWudelWHKjNT4I+ MDS/+6vDCJaI06S/EoVW9sYDb74C5ErYlFjG3RA3chsBy8SuoqoGqWTuVtcvHzQsFRd2UjpDnLwaf 8f0ZFKFNMSvLFWJTDOSz3MYzYBuCLuooia2IXRZWcf+tPXbVXEaFZD3TEIslPXwF/0E2xIftWMVkR J8b870PeKpb9MdpjB87lnXFBlj0Rg+QeISYY6jXM+8Oi7tfSNngX9u/I6brmeqkxXniww7l+l7nfP VpwAjJbgA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0hid-0000kg-J4; Wed, 29 Jul 2020 08:45:47 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0hia-0000ib-DU; Wed, 29 Jul 2020 08:45:45 +0000 X-UUID: f4993d91b88246938ba76be94fb5175c-20200729 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=Ia1XARyByvYXLRx9mXxEAiykte60Wo0wfVOMz7hQaag=; b=WTmhDVeeRYuU7vlrbTVytFuIX1pyrncV+YOI087Gokod0w9xBu5qbcPgo5RngmHfkvIBzztqGVPzz+YVMYDm0WiTtN3l0wnyoUZ76j2BJb25yDP4mqFL7QoacC+dQqC3YVtf95rUHj7J+jPgfoYifMrjkLTgtOfRx8CWy+PFWP0=; X-UUID: f4993d91b88246938ba76be94fb5175c-20200729 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 828658589; Wed, 29 Jul 2020 00:45:50 -0800 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 29 Jul 2020 01:35:33 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 29 Jul 2020 16:35:32 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 29 Jul 2020 16:35:30 +0800 Message-ID: <1596011707.11360.9.camel@mhfsdcap03> Subject: Re: [v2,2/3] dt-bindings: watchdog: add a new head file for toprgu reset-controllers From: Crystal Guo To: Matthias Brugger Date: Wed, 29 Jul 2020 16:35:07 +0800 In-Reply-To: <72d317ef-7f69-9e61-b1d5-23d660c58560@gmail.com> References: <1596004249-28655-1-git-send-email-crystal.guo@mediatek.com> <1596004249-28655-3-git-send-email-crystal.guo@mediatek.com> <1596010313.11360.2.camel@mhfsdcap03> <72d317ef-7f69-9e61-b1d5-23d660c58560@gmail.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200729_044544_651444_6479E0DE X-CRM114-Status: GOOD ( 20.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-watchdog@vger.kernel.org" , srv_heupstream , Seiya Wang =?UTF-8?Q?=28=E7=8E=8B=E8=BF=BA=E5=90=9B=29?= , Erin Lo =?UTF-8?Q?=28=E7=BE=85=E9=9B=85=E9=BD=A1=29?= , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "linux-mediatek@lists.infradead.org" , "linux@roeck-us.net" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2020-07-29 at 16:15 +0800, Matthias Brugger wrote: > > On 29/07/2020 10:11, Crystal Guo wrote: > > On Wed, 2020-07-29 at 15:42 +0800, Matthias Brugger wrote: > >> Hi Crystal, > >> > >> On 29/07/2020 08:30, Crystal Guo wrote: > >>> merge all the reset numbers in one head file. > >>> > >>> Signed-off-by: Crystal Guo > >>> --- > >>> include/dt-bindings/reset-controller/mtk-resets.h | 13 +++++++++++++ > >>> 1 file changed, 13 insertions(+) > >>> create mode 100644 include/dt-bindings/reset-controller/mtk-resets.h > >>> > >>> diff --git a/include/dt-bindings/reset-controller/mtk-resets.h b/include/dt-bindings/reset-controller/mtk-resets.h > >>> new file mode 100644 > >>> index 0000000..d73a4ba > >>> --- /dev/null > >>> +++ b/include/dt-bindings/reset-controller/mtk-resets.h > >>> @@ -0,0 +1,13 @@ > >>> +/* SPDX-License-Identifier: GPL-2.0 */ > >>> +/* > >>> + * Copyright (C) 2020 Mediatek Inc. > >>> + * > >>> + */ > >>> + > >>> +#ifndef _DT_BINDINGS_RESET_CONTROLLER_MTK > >>> +#define _DT_BINDINGS_RESET_CONTROLLER_MTK > >>> + > >>> +#define MT2712_TOPRGU_SW_RST_NUM 11 > >>> +#define MT8183_TOPRGU_SW_RST_NUM 19 > >> > >> Maybe I didn't explain myself properly. We want to have all resets in one file > >> and do not want to have the resets for the watchdog in a different file. That > >> means I don't thin your patch is correct and the effort should be abandoned. > >> > >> Regards, > >> Matthias > > > > Do you mean to keep the current way unchanged? For example, with a new > > SOC 8192, should add a new head file mt8192_resets.h for the resets > > numbers. > > > > Exactly. > > Regards, > Matthias OK, but the dt-binding mtk-wdt.txt still need to update, please help me to review, many thanks~ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel