From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi/xilinx: Cast ioread32/iowrite32 function pointers
Date: Thu, 29 Jan 2015 17:04:03 +0100 [thread overview]
Message-ID: <1597235.QjzCE74z4V@wuerfel> (raw)
In-Reply-To: <1422543073-21895-1-git-send-email-ricardo.ribalda@gmail.com>
On Thursday 29 January 2015 15:51:13 Ricardo Ribalda Delgado wrote:
> * Setup little endian helper functions first and try to use them
> * and check if bit was correctly setup or not.
> */
> - xspi->read_fn = ioread32;
> - xspi->write_fn = iowrite32;
> + xspi->read_fn = (u32 (*)(void __iomem *)) ioread32;
> + xspi->write_fn = (void (*)(u32, void __iomem *)) iowrite32;
>
> xspi->write_fn(XSPI_CR_LOOP, xspi->regs + XSPI_CR_OFFSET);
>
Casting the type of a function you call seems rather dangerous. Why not
add an inline function in this driver as a wrapper?
Arnd
next prev parent reply other threads:[~2015-01-29 16:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 14:51 [PATCH] spi/xilinx: Cast ioread32/iowrite32 function pointers Ricardo Ribalda Delgado
2015-01-29 15:56 ` Geert Uytterhoeven
2015-01-29 16:39 ` Ricardo Ribalda Delgado
2015-01-29 22:11 ` Arnd Bergmann
2015-01-29 22:14 ` Ricardo Ribalda Delgado
2015-01-29 22:28 ` Arnd Bergmann
2015-01-29 16:04 ` Arnd Bergmann [this message]
2015-01-29 16:39 ` Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1597235.QjzCE74z4V@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox