From: Wenbin Mei <wenbin.mei@mediatek.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: devicetree@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>,
srv_heupstream@mediatek.com, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Chaotian Jing <chaotian.jing@mediatek.com>
Subject: Re: [PATCH 1/3] mmc: dt-bindings: Add resets/reset-names for Mediatek MMC bindings
Date: Wed, 12 Aug 2020 21:03:33 +0800 [thread overview]
Message-ID: <1597237413.10188.5.camel@mhfsdcap03> (raw)
In-Reply-To: <6e667ff6f5a1aae51b89d00e9ec5bba29852f683.camel@pengutronix.de>
Thanks for your reply.
I have changed this in v2 patch.
On Wed, 2020-08-12 at 14:03 +0200, Philipp Zabel wrote:
> On Wed, 2020-08-12 at 17:37 +0800, Wenbin Mei wrote:
> > Add description for resets/reset-names.
> >
> > Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> > index 8a532f4453f2..35da72de7aac 100644
> > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> > @@ -49,6 +49,8 @@ Optional properties:
> > error caused by stop clock(fifo full)
> > Valid range = [0:0x7]. if not present, default value is 0.
> > applied to compatible "mediatek,mt2701-mmc".
> > +- resets: Phandle and reset specifier pair to softreset line of MSDC IP.
> > +- reset-names: Reset names for MSDC.
>
> I think the reset-names documentation should mention the actual value
> the driver should look for, "hrst".
>
> regards
> Philipp
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-12 13:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 9:37 [PATCH 0/3] mmc: mediatek: add optional module reset property mmc: mediatek: add optional module reset property arm64: dts: mt7622: add reset node for mmc device Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++ arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 ++ drivers/mmc/host/mtk-sd.c | 13 +++++++++++++ 3 files changed, 17 insertions(+) Wenbin Mei
2020-08-12 9:37 ` [PATCH 1/3] mmc: dt-bindings: Add resets/reset-names for Mediatek MMC bindings Wenbin Mei
2020-08-12 12:03 ` Philipp Zabel
2020-08-12 13:03 ` Wenbin Mei [this message]
2020-08-12 9:37 ` [PATCH 2/3] arm64: dts: mt7622: add reset node for mmc device Wenbin Mei
2020-08-12 10:33 ` Aw: " Frank Wunderlich
2020-08-12 11:57 ` Wenbin Mei
2020-08-12 9:37 ` [PATCH 3/3] mmc: mediatek: add optional module reset property Wenbin Mei
2020-08-12 10:07 ` Aw: " Frank Wunderlich
2020-08-12 11:55 ` Wenbin Mei
2020-08-12 12:08 ` Philipp Zabel
2020-08-12 19:59 ` Frank Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1597237413.10188.5.camel@mhfsdcap03 \
--to=wenbin.mei@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox