From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8B04C433E1 for ; Thu, 20 Aug 2020 01:59:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95316207DA for ; Thu, 20 Aug 2020 01:59:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H82C3bwv"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="J1IlM1Yh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95316207DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1HabA3pnrxcICbxVX5BtGHsuRyyeveLZTataQxzl3hU=; b=H82C3bwvq7IdWUJ+UNOrGDl5C IO3I9Hh4NZsSzMoPM/Y2t4FziBiQWvpRq83AXCJ6TTg4KFCsQNCLMCrKi6koEVpKYx7cTEFu2FmYa baKZt8wXEBQWv9Sj2IXbCSpgmQlTMBhVc3mWlrBKQR327rKpnJrjLY40m2NsPyv6xdxwh83N1yULY 5UhHBLQMkK451GOX42FCFPVuJjUUeBEP8Z2jZKHAr7YRKvvgL+xtDRDoiPCDK37I2AJFb/nl99EwF uaZWMn7X9Rb6U2HzdZyhN5YCgDD1iJ0XusPE6z4/2IH4OmoEd+EnBDu85GaWDZ+HINRVMOWYmPC+7 MjKh+NDVQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8ZqT-0005jh-DT; Thu, 20 Aug 2020 01:58:25 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8ZqQ-0005j4-OJ; Thu, 20 Aug 2020 01:58:23 +0000 X-UUID: 2f6d2dfb8f6d456aaa9b9ae808eede03-20200819 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=EFWywN6zeLfx3mYDlfu+y15rEMdXgmrxserMhZ887hk=; b=J1IlM1Yh+IHRVrTZB10AbJJjGKJIysMwZxenNX8Ft9rLwFeBaUaZpAmzSONDJdkWSaIEyuXNZrptSzF00gOsovKM15ESR3J7/GOay1iESu2CnkD99HcLAahG3JqX0QJF6e0qy2hezG2roBv4hil5Of18//EPupwNMU9T1Xqd/v8=; X-UUID: 2f6d2dfb8f6d456aaa9b9ae808eede03-20200819 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1685836257; Wed, 19 Aug 2020 17:58:18 -0800 Received: from MTKMBS33DR.mediatek.inc (172.27.6.106) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 Aug 2020 18:58:17 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS33DR.mediatek.inc (172.27.6.106) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 20 Aug 2020 09:58:14 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 20 Aug 2020 09:58:10 +0800 Message-ID: <1597888623.23067.19.camel@mhfsdcap03> Subject: Re: [PATCH 10/10] usb: udc: net2280: convert to readl_poll_timeout_atomic() From: Chunfeng Yun To: Alan Stern Date: Thu, 20 Aug 2020 09:57:03 +0800 In-Reply-To: <20200819145957.GA183103@rowland.harvard.edu> References: <1597840865-26631-1-git-send-email-chunfeng.yun@mediatek.com> <1597840865-26631-10-git-send-email-chunfeng.yun@mediatek.com> <20200819145957.GA183103@rowland.harvard.edu> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 22D2EDA70C9DE4A57BACB86CCD4B9AF55312C82D351F55D5F12277413D9518212000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200819_215822_985067_0C21BACB X-CRM114-Status: GOOD ( 21.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , Lee Jones , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2020-08-19 at 10:59 -0400, Alan Stern wrote: > On Wed, Aug 19, 2020 at 08:41:05PM +0800, Chunfeng Yun wrote: > > Use readl_poll_timeout_atomic() to simplify code > > > > Cc: Alan Stern > > Cc: Felipe Balbi > > Signed-off-by: Chunfeng Yun > > --- > > drivers/usb/gadget/udc/net2280.c | 21 ++++++++++----------- > > 1 file changed, 10 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c > > index 7530bd9..f1a21f4 100644 > > --- a/drivers/usb/gadget/udc/net2280.c > > +++ b/drivers/usb/gadget/udc/net2280.c > > @@ -52,6 +52,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > @@ -360,18 +361,16 @@ static inline void enable_pciirqenb(struct net2280_ep *ep) > > static int handshake(u32 __iomem *ptr, u32 mask, u32 done, int usec) > > { > > u32 result; > > + int ret; > > > > - do { > > - result = readl(ptr); > > - if (result == ~(u32)0) /* "device unplugged" */ > > - return -ENODEV; > > - result &= mask; > > - if (result == done) > > - return 0; > > - udelay(1); > > - usec--; > > - } while (usec > 0); > > - return -ETIMEDOUT; > > + ret = readl_poll_timeout_atomic(ptr, result, > > + ((result & mask) == done || > > + result == U32_MAX), > > + 1, usec); > > + if (result == U32_MAX) /* device unplugged */ > > + return -ENODEV; > > + > > + return ret; > > } > > > > static const struct usb_ep_ops net2280_ep_ops; > > -- > > Acked-by: Alan Stern > > However, I noticed that the kerneldoc for readl_poll_timeout_atomic() is > out of date. Can you fix it up? Ok, will do it, thanks > > Alan Stern _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel