From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69BA4C433E1 for ; Fri, 21 Aug 2020 22:47:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35A202067C for ; Fri, 21 Aug 2020 22:47:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ku8FTXwx"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Aaem4Vn0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35A202067C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:MIME-Version:In-Reply-To:References:To: Subject:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5lecgp6NLTQwPuCAyrtbLUa0zl48hGDuKv6KJM/AWKw=; b=ku8FTXwxwQ9cqd0a6pjR1rYIq Xs13P+a1omlVz+G3NbvebrsknO09snf9LXd9/tyGLvwPjhj46kwJEQgIjRDuJtFxtHNLM52WsVcin VdCs/WdjPbp68ipeeuR2YgJxZWyxsaBv9hDGL+Z4RjCkZqIIWsXXxVRnR5GvEqzqhqGeGU/+v8qH7 HkJcgWQXT5UM1GCKSUaumyySrygoIhGvb1ZjIYpbk8z5/D6eQsVp1Kt6KN7q8aGw0vy/SgKctDISW N/gYEi0IBhsbu5MF9ooOg50l1A0f7VGCoBZi+ZAortJ7oiv/CfB8qXDXFGKzxfiyyTAIRVbM2fT0M uvlMGbajw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9FnK-0006W8-TB; Fri, 21 Aug 2020 22:45:58 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9FnI-0006Ud-OM for linux-arm-kernel@lists.infradead.org; Fri, 21 Aug 2020 22:45:57 +0000 Received: by mail-pf1-x444.google.com with SMTP id u128so1769692pfb.6 for ; Fri, 21 Aug 2020 15:45:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=XRteHtv7uQmPq//ewuwrb7IZate8ro17vyeajkupG2I=; b=Aaem4Vn0bTEhViBFnc9tNsPPZfZuxBSub2f1nuc4MmLrKJfehNNHC9FP58+Q99TpoJ CpyvdmR758FAbXUk+bZELWHzl0ZBJJHNrJ0o1OiFr5aEhnPiK7JAYnBYHuFlc87PBxMw 5CkKUufHHUze0EbfKk5GkR4Sze0bxy10EoqSvehwLcZJivmtaCviba+jHzYG29+4F1hR kqoGu7zsi8jiLTa8Ca1bap7yXXxhgWrpwIC4iek8D8rNgLuKpNWAQMCj6+Sri3WvOUGr ZpkrJVq6T11xVJA0tVsLBKFfIsFV+B/n1jrQ+SlwybFHe3e4OAiIp0iV880jRDPNyHar P9TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=XRteHtv7uQmPq//ewuwrb7IZate8ro17vyeajkupG2I=; b=Lz9H6MGp7c6OXk2ZQj8V3EQ5sGo/6uvDCMio0ORFb68QbXiyZZz0cjtwPSCI2kJ4zb vlbHPSDPh26lDOaG7THKWpHehkj1aqIWTPaw5nNPmp1+QXYH64reDsS3HU7MFIbQNkUF HueXcB0g3qM7euR46hJ5pCtbYeYLbAmyJpL6WkKKH7iEHPTfcO0hbTCVvlhlhRHJ4Q/6 L6kfbW2HMRmRTRG0qN7Am5yIz1QJnPj7kP598SQlJFdLhfqA7WeSw5pySHbJPhPl7tTL w2AEXaJnMJEeNAfNmGNiBb44wFrLjFctKO7z1UuQO3xyUEzWIvvhcJoK1hGznPKbY8kR nqoQ== X-Gm-Message-State: AOAM531mN9sWvsEMM7MjSxF4v1L8hqxtlKF1hziMzg0HdzdUtD/W/tG9 HXwiQuamSr/ljNgrUaad2oI= X-Google-Smtp-Source: ABdhPJy7krGSqdemncjBBCsDGsMdylWo6zM9qjg4SD8PzW/+V58PKpTZD+S3JHXtmZJ0AJ7MWzK3TQ== X-Received: by 2002:a62:7acb:: with SMTP id v194mr4142526pfc.302.1598049954288; Fri, 21 Aug 2020 15:45:54 -0700 (PDT) Received: from localhost (61-68-212-105.tpgi.com.au. [61.68.212.105]) by smtp.gmail.com with ESMTPSA id w130sm3564073pfd.104.2020.08.21.15.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2020 15:45:53 -0700 (PDT) Date: Sat, 22 Aug 2020 08:45:48 +1000 From: Nicholas Piggin Subject: Re: [PATCH v6 05/12] mm: HUGE_VMAP arch support cleanup To: Andrew Morton References: <20200821151216.1005117-1-npiggin@gmail.com> <20200821151216.1005117-6-npiggin@gmail.com> <20200821131422.110abb1a0c0b6a9d378b0e48@linux-foundation.org> In-Reply-To: <20200821131422.110abb1a0c0b6a9d378b0e48@linux-foundation.org> MIME-Version: 1.0 Message-Id: <1598049779.exwra3cjwe.astroid@bobo.none> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200821_184556_832312_51008CAF X-CRM114-Status: GOOD ( 14.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, Will Deacon , Catalin Marinas , "H. Peter Anvin" , linux-kernel@vger.kernel.org, Christophe Leroy , Christoph Hellwig , linux-mm@kvack.org, Zefan Li , =?iso-8859-1?q?Borislav=0A?= Petkov , Jonathan Cameron , =?iso-8859-1?q?Thomas=0A?= Gleixner , linuxppc-dev@lists.ozlabs.org, Ingo Molnar , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Excerpts from Andrew Morton's message of August 22, 2020 6:14 am: > On Sat, 22 Aug 2020 01:12:09 +1000 Nicholas Piggin wrote: > >> This changes the awkward approach where architectures provide init >> functions to determine which levels they can provide large mappings for, >> to one where the arch is queried for each call. >> >> This removes code and indirection, and allows constant-folding of dead >> code for unsupported levels. >> >> This also adds a prot argument to the arch query. This is unused >> currently but could help with some architectures (e.g., some powerpc >> processors can't map uncacheable memory with large pages). >> >> --- a/arch/arm64/include/asm/vmalloc.h >> +++ b/arch/arm64/include/asm/vmalloc.h >> @@ -1,4 +1,12 @@ >> #ifndef _ASM_ARM64_VMALLOC_H >> #define _ASM_ARM64_VMALLOC_H >> >> +#include >> + >> +#ifdef CONFIG_HAVE_ARCH_HUGE_VMAP >> +bool arch_vmap_p4d_supported(pgprot_t prot); >> +bool arch_vmap_pud_supported(pgprot_t prot); >> +bool arch_vmap_pmd_supported(pgprot_t prot); >> +#endif > > Moving these out of generic code and into multiple arch headers is > unfortunate. Can we leave them in include/linux/somewhere? And remove > the ifdefs, if so inclined - they just move the build error from > link-time to compile-time, and such an error shouldn't occur! Yeah this was just an intermediate step as you saw. It's a bit unfortunate, but I thought it made the arch changes clearer. Thanks, Nick _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel