* [PATCH v2] nvmem: mtk-efuse: Remove EFUSE register write support
@ 2020-08-26 6:21 Chih-En Hsu
2020-08-26 7:34 ` CK Hu
2020-08-26 8:30 ` andrew-ct chen
0 siblings, 2 replies; 4+ messages in thread
From: Chih-En Hsu @ 2020-08-26 6:21 UTC (permalink / raw)
To: Srinivas Kandagatla, Matthias Brugger
Cc: Andrew-CT.Chen, srv_heupstream, linux-kernel, linux-mediatek,
Chih-En Hsu, linux-arm-kernel, Michael.Mei
This patch is to remove function "mtk_reg_write" since
Mediatek EFUSE hardware only supports read functionality
for NVMEM consumers.
Fixes: 4c7e4fe37766 ("nvmem: mediatek: Add Mediatek EFUSE driver")
Signed-off-by: Chih-En Hsu <chih-en.hsu@mediatek.com>
---
drivers/nvmem/mtk-efuse.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c
index 856d9c3fc38e..6a537d959f14 100644
--- a/drivers/nvmem/mtk-efuse.c
+++ b/drivers/nvmem/mtk-efuse.c
@@ -28,19 +28,6 @@ static int mtk_reg_read(void *context,
return 0;
}
-static int mtk_reg_write(void *context,
- unsigned int reg, void *_val, size_t bytes)
-{
- struct mtk_efuse_priv *priv = context;
- u32 *val = _val;
- int i = 0, words = bytes / 4;
-
- while (words--)
- writel(*val++, priv->base + reg + (i++ * 4));
-
- return 0;
-}
-
static int mtk_efuse_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
@@ -61,7 +48,6 @@ static int mtk_efuse_probe(struct platform_device *pdev)
econfig.stride = 4;
econfig.word_size = 4;
econfig.reg_read = mtk_reg_read;
- econfig.reg_write = mtk_reg_write;
econfig.size = resource_size(res);
econfig.priv = priv;
econfig.dev = dev;
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] nvmem: mtk-efuse: Remove EFUSE register write support
2020-08-26 6:21 [PATCH v2] nvmem: mtk-efuse: Remove EFUSE register write support Chih-En Hsu
@ 2020-08-26 7:34 ` CK Hu
2020-08-26 8:30 ` andrew-ct chen
1 sibling, 0 replies; 4+ messages in thread
From: CK Hu @ 2020-08-26 7:34 UTC (permalink / raw)
To: Chih-En Hsu
Cc: Andrew-CT.Chen, srv_heupstream, linux-kernel, linux-mediatek,
Matthias Brugger, Srinivas Kandagatla, linux-arm-kernel,
Michael.Mei
Hi, Chih-En:
On Wed, 2020-08-26 at 14:21 +0800, Chih-En Hsu wrote:
> This patch is to remove function "mtk_reg_write" since
> Mediatek EFUSE hardware only supports read functionality
> for NVMEM consumers.
>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Fixes: 4c7e4fe37766 ("nvmem: mediatek: Add Mediatek EFUSE driver")
> Signed-off-by: Chih-En Hsu <chih-en.hsu@mediatek.com>
> ---
> drivers/nvmem/mtk-efuse.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c
> index 856d9c3fc38e..6a537d959f14 100644
> --- a/drivers/nvmem/mtk-efuse.c
> +++ b/drivers/nvmem/mtk-efuse.c
> @@ -28,19 +28,6 @@ static int mtk_reg_read(void *context,
> return 0;
> }
>
> -static int mtk_reg_write(void *context,
> - unsigned int reg, void *_val, size_t bytes)
> -{
> - struct mtk_efuse_priv *priv = context;
> - u32 *val = _val;
> - int i = 0, words = bytes / 4;
> -
> - while (words--)
> - writel(*val++, priv->base + reg + (i++ * 4));
> -
> - return 0;
> -}
> -
> static int mtk_efuse_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> @@ -61,7 +48,6 @@ static int mtk_efuse_probe(struct platform_device *pdev)
> econfig.stride = 4;
> econfig.word_size = 4;
> econfig.reg_read = mtk_reg_read;
> - econfig.reg_write = mtk_reg_write;
> econfig.size = resource_size(res);
> econfig.priv = priv;
> econfig.dev = dev;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] nvmem: mtk-efuse: Remove EFUSE register write support
2020-08-26 6:21 [PATCH v2] nvmem: mtk-efuse: Remove EFUSE register write support Chih-En Hsu
2020-08-26 7:34 ` CK Hu
@ 2020-08-26 8:30 ` andrew-ct chen
2020-08-26 8:38 ` Chih-En Hsu
1 sibling, 1 reply; 4+ messages in thread
From: andrew-ct chen @ 2020-08-26 8:30 UTC (permalink / raw)
To: Chih-En Hsu
Cc: srv_heupstream, linux-kernel, linux-mediatek, Matthias Brugger,
Srinivas Kandagatla, linux-arm-kernel, Michael.Mei
Hi Chih-En,
On Wed, 2020-08-26 at 14:21 +0800, Chih-En Hsu wrote:
> This patch is to remove function "mtk_reg_write" since
> Mediatek EFUSE hardware only supports read functionality
> for NVMEM consumers.
The fixed patch should be ba360fd040e34 ("nvmem: mtk-efuse: remove nvmem
regmap dependency")
> Fixes: 4c7e4fe37766 ("nvmem: mediatek: Add Mediatek EFUSE driver")
> Signed-off-by: Chih-En Hsu <chih-en.hsu@mediatek.com>
> ---
> drivers/nvmem/mtk-efuse.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c
> index 856d9c3fc38e..6a537d959f14 100644
> --- a/drivers/nvmem/mtk-efuse.c
> +++ b/drivers/nvmem/mtk-efuse.c
> @@ -28,19 +28,6 @@ static int mtk_reg_read(void *context,
> return 0;
> }
>
> -static int mtk_reg_write(void *context,
> - unsigned int reg, void *_val, size_t bytes)
> -{
> - struct mtk_efuse_priv *priv = context;
> - u32 *val = _val;
> - int i = 0, words = bytes / 4;
> -
> - while (words--)
> - writel(*val++, priv->base + reg + (i++ * 4));
> -
> - return 0;
> -}
> -
> static int mtk_efuse_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> @@ -61,7 +48,6 @@ static int mtk_efuse_probe(struct platform_device *pdev)
> econfig.stride = 4;
> econfig.word_size = 4;
> econfig.reg_read = mtk_reg_read;
> - econfig.reg_write = mtk_reg_write;
> econfig.size = resource_size(res);
> econfig.priv = priv;
> econfig.dev = dev;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] nvmem: mtk-efuse: Remove EFUSE register write support
2020-08-26 8:30 ` andrew-ct chen
@ 2020-08-26 8:38 ` Chih-En Hsu
0 siblings, 0 replies; 4+ messages in thread
From: Chih-En Hsu @ 2020-08-26 8:38 UTC (permalink / raw)
To: andrew-ct chen
Cc: srv_heupstream, linux-kernel, linux-mediatek, Matthias Brugger,
Srinivas Kandagatla, linux-arm-kernel, Michael.Mei
Hi Andrew:
OK, I will fix it.
Thanks a lot.
Alex
On Wed, 2020-08-26 at 16:30 +0800, andrew-ct chen wrote:
> Hi Chih-En,
>
> On Wed, 2020-08-26 at 14:21 +0800, Chih-En Hsu wrote:
> > This patch is to remove function "mtk_reg_write" since
> > Mediatek EFUSE hardware only supports read functionality
> > for NVMEM consumers.
>
> The fixed patch should be ba360fd040e34 ("nvmem: mtk-efuse: remove nvmem
> regmap dependency")
>
> > Fixes: 4c7e4fe37766 ("nvmem: mediatek: Add Mediatek EFUSE driver")
> > Signed-off-by: Chih-En Hsu <chih-en.hsu@mediatek.com>
> > ---
> > drivers/nvmem/mtk-efuse.c | 14 --------------
> > 1 file changed, 14 deletions(-)
> >
> > diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c
> > index 856d9c3fc38e..6a537d959f14 100644
> > --- a/drivers/nvmem/mtk-efuse.c
> > +++ b/drivers/nvmem/mtk-efuse.c
> > @@ -28,19 +28,6 @@ static int mtk_reg_read(void *context,
> > return 0;
> > }
> >
> > -static int mtk_reg_write(void *context,
> > - unsigned int reg, void *_val, size_t bytes)
> > -{
> > - struct mtk_efuse_priv *priv = context;
> > - u32 *val = _val;
> > - int i = 0, words = bytes / 4;
> > -
> > - while (words--)
> > - writel(*val++, priv->base + reg + (i++ * 4));
> > -
> > - return 0;
> > -}
> > -
> > static int mtk_efuse_probe(struct platform_device *pdev)
> > {
> > struct device *dev = &pdev->dev;
> > @@ -61,7 +48,6 @@ static int mtk_efuse_probe(struct platform_device *pdev)
> > econfig.stride = 4;
> > econfig.word_size = 4;
> > econfig.reg_read = mtk_reg_read;
> > - econfig.reg_write = mtk_reg_write;
> > econfig.size = resource_size(res);
> > econfig.priv = priv;
> > econfig.dev = dev;
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-26 8:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-26 6:21 [PATCH v2] nvmem: mtk-efuse: Remove EFUSE register write support Chih-En Hsu
2020-08-26 7:34 ` CK Hu
2020-08-26 8:30 ` andrew-ct chen
2020-08-26 8:38 ` Chih-En Hsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).