From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC962C43461 for ; Thu, 10 Sep 2020 08:53:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2BB542078B for ; Thu, 10 Sep 2020 08:53:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eVzjHzRe"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ADmQP41q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2BB542078B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=oA26FsN6DUFGMEP/CDVaOh/xzEwJKY1mIjEyoiCFVJs=; b=eVzjHzRexe6awle2qzdNnyxJ6k T61vUU70YxrIpNb5Cny8z6vtweu7ry5bJMMIEk/mk9/UUyKHrl1Kl0IGjlyYYIFm+LnWV2sevB29I zF+bvNIGDXpBDy1scVn3F3FcVQEQG5Ulz3qF6uRH+Hxlr4MV/8ce4eF/UP39yO4z3H1z/QKT7e7Eb EKDjB0vvy1Zj+TMXTkxkqEieEcQSrMvK6uEX2rG3aQan+xfUfI09tV3Dcv6iVxgZz6cVaZlwEu8Aq uiupU+8X6MtygAcdMO00+Gs8sSGvOwcUuuH95AoJ2Qq/QMyg0/CeyktSVCL8ObknwGIrku0BY4j9u 36lQP9Aw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGIJc-0002Be-LX; Thu, 10 Sep 2020 08:52:24 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGIJZ-0002B4-Jc for linux-arm-kernel@lists.infradead.org; Thu, 10 Sep 2020 08:52:22 +0000 Received: from PC-kkoz.proceq.com (unknown [213.160.61.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F13E02078B; Thu, 10 Sep 2020 08:52:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599727940; bh=pKJBC1J8nO1JEn2di9prUMv7XinIJkYYcTXmoZZ2/b4=; h=From:To:Cc:Subject:Date:From; b=ADmQP41qeWq2CTNwYYPujfGLaqoHNF418+olBQVBGZIKE4kER5nR8Zk4YrhHM155I u+FhKUiqNCdL8l+5umFN5vVzQ7+/Kq64246MGKMj5xLeaBLH3RZdI/qe9EJTKgFPWa 1MmA+vIZFHPHUVxvj5Kirz2dkF4AnMOrCn1t0CyE= From: Krzysztof Kozlowski To: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Maxime Coquelin , Alexandre Torgue , Krzysztof Kozlowski , Andy Shevchenko , linux-iio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] iio: adc: stm32: Fix missing return in booster error path Date: Thu, 10 Sep 2020 10:52:07 +0200 Message-Id: <1599727927-7776-1-git-send-email-krzk@kernel.org> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200910_045221_731786_BE0906D5 X-CRM114-Status: GOOD ( 15.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Rothwell , Greg KH MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Conversion of error paths to dev_err_probe() dropped one return statement. The driver will continue to probe if getting booster regulator fails. Reported-by: Stephen Rothwell Fixes: ce30eeb613cb ("iio: adc: stm32: Simplify with dev_err_probe()") Signed-off-by: Krzysztof Kozlowski --- Commit sha from linux-next. --- drivers/iio/adc/stm32-adc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c index 3f27b4817a42..6a0338d33bd8 100644 --- a/drivers/iio/adc/stm32-adc-core.c +++ b/drivers/iio/adc/stm32-adc-core.c @@ -595,7 +595,7 @@ static int stm32_adc_core_switches_probe(struct device *dev, if (IS_ERR(priv->booster)) { ret = PTR_ERR(priv->booster); if (ret != -ENODEV) - dev_err_probe(dev, ret, "can't get booster\n"); + return dev_err_probe(dev, ret, "can't get booster\n"); priv->booster = NULL; } -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel