From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D050FC433E2 for ; Fri, 11 Sep 2020 13:33:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F34922272 for ; Fri, 11 Sep 2020 13:33:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YnAmQMeL"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZJtKHlg2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F34922272 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=2PAJ0p7Yipt7ke1ObYln/xtiAEBOoPvK922kwSfh7Kc=; b=YnAmQMeLzeATZ0Q2MeMjAlPOXV Fssqf7mhHVFubqr/OliaNWMmxyXFnvquhDwIB+Bj0pn4AbQtg4YpG3ER+FhbC8Z8rcWTYYhKkwiVT 5Osk6UcR7IrfIeSRXcTxmUOsYDqup8Fpye1EplbGdISxbovYTclzyX8tTHcH/dUExBs0obqcWwhNB GKmbiXaiuN2apwg+V8WMg8XHAdudXLo7WoH6Swjp4IIhyyKkVThFca80a2PRzbSPcYXIQMTf/s7J7 bYDY7vHNKTu24tG+zut0al1OiyNO2nEs6iX/w+xU/CgVdrCu31FkY7kOO0Om4CFBpD41YEQoGe10B izEzyxJg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGj8b-0007Md-1R; Fri, 11 Sep 2020 13:30:49 +0000 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGj73-0006O2-Bs for linux-arm-kernel@lists.infradead.org; Fri, 11 Sep 2020 13:29:15 +0000 Received: by mail-pj1-x1043.google.com with SMTP id fa1so1728868pjb.0 for ; Fri, 11 Sep 2020 06:29:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=oE/wqoSbsqv2hid7WyjqPh05UOp+PSXcBf5enraQNIw=; b=ZJtKHlg2+Qyk+e6flWMUPDf2R513o9k5cmLgzNedw2Fzrrg2TvxtrJhrtQv/G77XDE Awr//OH53K23djlIRJOaWvkuYt4BNrys6dltOmdfdT0r3PEjxPlZUwZCQtXxU/Moq40h q8tzl6VH/S4mA5HfogBAqoBkTH8j4JawYnEFxnfseyHNyeC6gpvg1rXdTzZtJ0cyA66x vXv3S3Xva5+PN0uK92naQ70TX8GNxmqirwEau2oaGnz4uFwuz6Bb1M0pbU0Qt7RI8S1X pNbcdHKdv6hOCuM8Oyy0CEmdKQ1YhIYInxuI9eXNHyE5CBXZnMMkByo1QrJPzvwwZnZs z8yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=oE/wqoSbsqv2hid7WyjqPh05UOp+PSXcBf5enraQNIw=; b=IJpFB0GEskqitJYqXETHHLi/kIjFbOE8YeI6xMk1eO03pPTBdruBpMtHQ0bEdTgJBP af2GkOGgfGebN9tYg6m8aoz8OPjzf8FayEzL1l1DVPhgPQmR9j0dyMEwU+9K1Z54Cxt7 YNQ0B1CyZUK+YwiARuJp9yFk42eFfILVzzADXVcuQUc42wZ7ibAKPIxEw2bZo7eEyB6B xljLuO1FTiz3Apbs0rnB8YEUrMX9UYuyIC+bBn9b9QvtPwIfbsdARvuglBROR2d7QgDL yv1gkDt+fjeN2lJPmAfafFHg03xCli5DarPjRFjiutOEEyyi8fGm9zYnt2KUiD5tkt+p OWbg== X-Gm-Message-State: AOAM53382PmL2Qvkc8piR8ulNxmk0uHcBpZwEUwosPVrlFjSUTfzuz1w 0z9xCjUJB2Qf3sAoXAYJQXtsKw== X-Google-Smtp-Source: ABdhPJxbjdUv3H0gL8OHcqKBS2SE0Vo7mVcMOQlitX0foG0MQcL6w/a4cRDFyo1GcgHsYfGc3CZIPQ== X-Received: by 2002:a17:90a:ec05:: with SMTP id l5mr2392447pjy.172.1599830948206; Fri, 11 Sep 2020 06:29:08 -0700 (PDT) Received: from localhost.localdomain ([117.210.209.48]) by smtp.gmail.com with ESMTPSA id e10sm557988pgb.45.2020.09.11.06.29.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Sep 2020 06:29:07 -0700 (PDT) From: Sumit Garg To: maz@kernel.org, catalin.marinas@arm.com, will@kernel.org Subject: [PATCH v4 0/5] arm64: Add framework to turn an IPI as NMI Date: Fri, 11 Sep 2020 18:58:39 +0530 Message-Id: <1599830924-13990-1-git-send-email-sumit.garg@linaro.org> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200911_092913_774360_628A8D54 X-CRM114-Status: GOOD ( 16.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, Sumit Garg , daniel.thompson@linaro.org, jason@lakedaemon.net, kgdb-bugreport@lists.sourceforge.net, dianders@chromium.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jason.wessel@windriver.com, tglx@linutronix.de, julien.thierry.kdev@gmail.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org With pseudo NMIs support available its possible to configure SGIs to be triggered as pseudo NMIs running in NMI context. And kernel features such as: - NMI backtrace can leverage IPI turned as NMI to get a backtrace of CPU stuck in hard lockup using magic SYSRQ. - kgdb relies on NMI support to round up CPUs which are stuck in hard lockup state with interrupts disabled. This patch-set adds framework to turn an IPI as NMI which can be triggered as a pseudo NMI which in turn invokes registered NMI handlers. After this patch-set we should be able to get a backtrace for a CPU stuck in HARDLOCKUP. Have a look at an examples below from a hard lockup testcase run on Developerbox: $ echo HARDLOCKUP > /sys/kernel/debug/provoke-crash/DIRECT NMI backtrace: ============== # Issue Magic SysRq to dump backtrace [ 376.894502] NMI backtrace for cpu 8 [ 376.894506] CPU: 8 PID: 555 Comm: bash Not tainted 5.9.0-rc3-00740-g06ff047-dirty #242 [ 376.894510] Hardware name: Socionext SynQuacer E-series DeveloperBox, BIOS build #73 Apr 6 2020 [ 376.894514] pstate: 40000005 (nZcv daif -PAN -UAO BTYPE=--) [ 376.894517] pc : lkdtm_HARDLOCKUP+0x8/0x18 [ 376.894520] lr : lkdtm_do_action+0x24/0x30 [ 376.894524] sp : ffff800012cebd20 [ 376.894527] pmr_save: 00000060 [ 376.894530] x29: ffff800012cebd20 x28: ffff000875ae8000 [ 376.894540] x27: 0000000000000000 x26: 0000000000000000 [ 376.894550] x25: 000000000000001a x24: ffff800012cebe40 [ 376.894560] x23: 000000000000000b x22: ffff800010fc5040 [ 376.894569] x21: ffff000878b61000 x20: ffff8000113b2870 [ 376.894579] x19: 000000000000001b x18: 0000000000000010 [ 376.894588] x17: 0000000000000000 x16: 0000000000000000 [ 376.894598] x15: ffff000875ae8470 x14: 00000000000002ad [ 376.894613] x13: 0000000000000000 x12: 0000000000000000 [ 376.894622] x11: 0000000000000007 x10: 00000000000009c0 [ 376.894631] x9 : ffff800012ceba80 x8 : ffff000875ae8a20 [ 376.894641] x7 : ffff00087f6b3280 x6 : ffff00087f6b3200 [ 376.894651] x5 : 0000000000000000 x4 : ffff00087f6a91f8 [ 376.894660] x3 : ffff00087f6b0120 x2 : 1aa310cec69eb500 [ 376.894670] x1 : 0000000000000000 x0 : 0000000000000060 [ 376.894679] Call trace: [ 376.894683] lkdtm_HARDLOCKUP+0x8/0x18 [ 376.894686] direct_entry+0x124/0x1c0 [ 376.894689] full_proxy_write+0x60/0xb0 [ 376.894693] vfs_write+0xf0/0x230 [ 376.894696] ksys_write+0x6c/0xf8 [ 376.894699] __arm64_sys_write+0x1c/0x28 [ 376.894703] el0_svc_common.constprop.0+0x74/0x1f0 [ 376.894707] do_el0_svc+0x24/0x90 [ 376.894710] el0_sync_handler+0x180/0x2f8 [ 376.894713] el0_sync+0x158/0x180 KGDB: ===== # Enter kdb via Magic SysRq [6]kdb> btc btc: cpu status: Currently on cpu 6 Available cpus: 0-5(I), 6, 7(I), 8, 9-23(I) Stack traceback for pid 555 0xffff000875ae8000 555 554 1 8 R 0xffff000875ae89c0 bash CPU: 8 PID: 555 Comm: bash Not tainted 5.9.0-rc3-00740-g06ff047-dirty #242 Hardware name: Socionext SynQuacer E-series DeveloperBox, BIOS build #73 Apr 6 2020 Call trace: dump_backtrace+0x0/0x1a0 show_stack+0x18/0x28 dump_stack+0xc0/0x11c kgdb_cpu_enter+0x648/0x660 kgdb_nmicallback+0xa0/0xa8 ipi_kgdb_nmicallback+0x24/0x30 ipi_nmi_handler+0x48/0x60 handle_percpu_devid_fasteoi_ipi+0x74/0x88 generic_handle_irq+0x30/0x48 handle_domain_nmi+0x48/0x80 gic_handle_irq+0x18c/0x34c el1_irq+0xcc/0x180 lkdtm_HARDLOCKUP+0x8/0x18 direct_entry+0x124/0x1c0 full_proxy_write+0x60/0xb0 vfs_write+0xf0/0x230 ksys_write+0x6c/0xf8 __arm64_sys_write+0x1c/0x28 el0_svc_common.constprop.0+0x74/0x1f0 do_el0_svc+0x24/0x90 el0_sync_handler+0x180/0x2f8 el0_sync+0x158/0x180 Changes in v4: - Move IPI NMI framework to a separate file. - Get rid of hard-coded IPI_CALL_NMI_FUNC allocation. - Add NMI backtrace support leveraged via magic SYSRQ. Changes in v3: - Rebased to Marc's latest IPIs patch-set [1]. [1] https://lkml.org/lkml/2020/9/1/603 Changes since RFC version [1]: - Switch to use generic interrupt framework to turn an IPI as NMI. - Dependent on Marc's patch-set [2] which turns IPIs into normal interrupts. - Addressed misc. comments from Doug on patch #4. - Posted kgdb NMI printk() fixup separately which has evolved since to be solved using different approach via changing kgdb interception of printk() in common printk() code (see patch [3]). [1] https://lkml.org/lkml/2020/4/24/328 [2] https://lkml.org/lkml/2020/5/19/710 [3] https://lkml.org/lkml/2020/5/20/418 Sumit Garg (5): arm64: Add framework to turn IPI as NMI irqchip/gic-v3: Enable support for SGIs to act as NMIs arm64: smp: Allocate and setup IPI as NMI arm64: kgdb: Round up cpus using IPI as NMI arm64: ipi_nmi: Add support for NMI backtrace arch/arm64/include/asm/irq.h | 6 +++ arch/arm64/include/asm/kgdb.h | 8 ++++ arch/arm64/include/asm/nmi.h | 16 ++++++++ arch/arm64/kernel/Makefile | 2 +- arch/arm64/kernel/ipi_nmi.c | 93 +++++++++++++++++++++++++++++++++++++++++++ arch/arm64/kernel/kgdb.c | 21 ++++++++++ arch/arm64/kernel/smp.c | 8 ++++ drivers/irqchip/irq-gic-v3.c | 13 +++++- 8 files changed, 164 insertions(+), 3 deletions(-) create mode 100644 arch/arm64/include/asm/nmi.h create mode 100644 arch/arm64/kernel/ipi_nmi.c -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel