From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: hypmean.kim@samsung.com,
"bzolnier@gmail.com" <bzolnier@gmail.com>,
"rafael@kernel.org" <rafael@kernel.org>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"amitk@kernel.org" <amitk@kernel.org>,
"rui.zhang@intel.com" <rui.zhang@intel.com>,
ALIM AKHTAR <alim.akhtar@samsung.com>,
"edubezval@gmail.com" <edubezval@gmail.com>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] thermal: exynos: fix masking value for exynos7 temp_error
Date: Thu, 31 Mar 2022 10:23:23 +0200 [thread overview]
Message-ID: <15b3d34f-2a91-6dd3-8335-9ccd0d5ec70e@linaro.org> (raw)
In-Reply-To: <20220331072843epcms2p5c9e7ee4756d1aa267cf4af56b0ca22fc@epcms2p5>
On 31/03/2022 09:28, Sang Min Kim wrote:
>
Unneeded empty line at beginning of msg.
> Modify mask value for the temp_error in the sanitize_temp_error() function.
>
> Fixes: aef27b658b43 ("thermal: exynos: use sanitize_temp_error() in exynos7_tmu_initialize()")
> masked temp_error2 with EXYNOS_TMU_TEMP_MASK(0xff) value even in the case
> of EXYNOS7.
> In addition, when entering the if statement, both temp_error1 and 2 are
> masked with EXYNOS_TMU_TEMP_MASK(0xff).
>
> By modifying to use the previously declared local variable tmu_temp_mask,
> the mask value suitable for the SOC can be applied.
>
Fixes tag goes next to other tags, so usually before Signed-off-by.
Check some existing commits for examples.
> Signed-off-by: sangmin kim <hypmean.kim@samsung.com>
You received by Reviewed-by tag, so you should include it in v2. Don't
skip them.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> V1 -> V2: Add fixes tag
>
> drivers/thermal/samsung/exynos_tmu.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-03-31 8:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220331071833.115732-1-hypmean.kim@samsung.com>
[not found] ` <CGME20220331071809epcas2p472298073d4aed0a8026d4b08967c5de5@epcms2p5>
2022-03-31 7:28 ` [PATCH v2] thermal: exynos: fix masking value for exynos7 temp_error Sang Min Kim
2022-03-31 8:23 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15b3d34f-2a91-6dd3-8335-9ccd0d5ec70e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=amitk@kernel.org \
--cc=bzolnier@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=hypmean.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).