From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86529C10F1A for ; Mon, 22 Apr 2024 13:47:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iKrxZNT+TMIbN2C2peaFOyMEb0fsNVA++BuPeeUIFtU=; b=zPfKUjbZyzTY8I wxRR3yNQik4lF6Ykq/Cf6AAeYEce/Gl2CtGg9qVnsMMX4A6esg6tPJb89eBwWDbazh4GWyoiZrQ5W VHbCnElnkgw0r3wKcTcgcPgsnBHltcoPVTHsT/8i2ftst8ylEXNLYKjNKm+Jm7OyKKuesXm1pSoD4 1UvWTdAVEWwJgkW7KbZZEsLh0grfVQ3XA8CAPMEZSZd2LisiblrmzL0dTNcXusfoB6P3eFhzZyfDD Xom3QVXqmepqQFEbZBFPmm7gYKhnzid0CxAFtVo+GY+JeTS7uEEDm9BywRsV2dDp2P3IN7tjZAYY/ QATkNHFA0HVNSQMs34Jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryu0r-0000000DoGW-3yhI; Mon, 22 Apr 2024 13:47:17 +0000 Received: from mail-vi1eur04on20701.outbound.protection.outlook.com ([2a01:111:f403:2611::701] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryu0p-0000000DoEL-1zMo for linux-arm-kernel@lists.infradead.org; Mon, 22 Apr 2024 13:47:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CfoVCDQuH/qO3TUYpF/n/+Z3EsLR0cXmJ7Wk2bRDQ0TXsad+PRM4h4Fdv9eApZBpTIE9f8/A0hmKxy20o/Xc5Zjbcb/4nhsO1oQ8YIwf74/OiHfQV4ZXnwS1OnSumQdsYbUvXlI1tCi0FSSqjvbK4Fv1QHnNEWC6Ku2tJYPNYAV4nS+YOj8jI0LfcRj5y4/NrgegUoWAkBFgYcuZAw6aFuQbehYtZhkNcD0DqgGG1iqjGOynEL6PT3lY4Yn+QsmJwtj8e8AzILz8hldL37fmg/cvn46IJRLzfNTa1oE4H1mkfx3Cr6m8kOd3Y8uxqOGVdgwSoAFOHW/MZMSFNzNpLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/rPzgMUhLJxFBGL2PxT1NwJwRoh8TG9N8eEXUd1UMro=; b=UH/hnUqFoyxb1pbw9F3qPueKcqmKlbT0321i3P7S5oNZIdxk+lIcUPOVKvMScBt+hGZwN+LYH95il28u8lZIuch01cLqvresP0biqdZUNfCZCiDV+fZw2Crn1ZBNWZ9WDc3UO/XuxkpX4f6i6gNZQovM1KrCyuzuOMvsjZcDYSFslmI60z7wfYgAYaA/ppEOAnEnp9C8QX8d2kx8ei+60J0GFjwZWbRhHDTmlhGOjZji1M3jP5vRBlJR0la2aG7aBidwIkBfksKNK218G2/E7B856rIJqK4mYWbWlwo9Vsk0MUMmuJFzmSMTT72EoDmQtqf6zJWkDmxjocBayv7gMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=solid-run.com; dmarc=pass action=none header.from=solid-run.com; dkim=pass header.d=solid-run.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=solidrn.onmicrosoft.com; s=selector1-solidrn-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/rPzgMUhLJxFBGL2PxT1NwJwRoh8TG9N8eEXUd1UMro=; b=ffWJzgf7JI127PAgADE8AGAoWrgbwc0cW9Ujja7QRTkVEkA/mLAguKTM21dJjnSAz1/ibXSsQe3tf+eSVAZ5UEY8BPSj4m5o8yw/fB4O6EJyTkkv9t6Tm6ajkXRYEHAhJ9m73HDhtGVAFDmEMbzFulaZuz9r5yCqxYPeeKW2vhA= Received: from AM9PR04MB7586.eurprd04.prod.outlook.com (2603:10a6:20b:2d5::17) by DB9PR04MB9498.eurprd04.prod.outlook.com (2603:10a6:10:360::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Mon, 22 Apr 2024 13:47:01 +0000 Received: from AM9PR04MB7586.eurprd04.prod.outlook.com ([fe80::c04e:8a97:516c:5529]) by AM9PR04MB7586.eurprd04.prod.outlook.com ([fe80::c04e:8a97:516c:5529%7]) with mapi id 15.20.7472.044; Mon, 22 Apr 2024 13:47:01 +0000 From: Josua Mayer To: Andrew Lunn CC: Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rob Herring , Yazan Shhady , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 4/4] arm64: dts: add description for solidrun cn9131 solidwan board Thread-Topic: [PATCH v3 4/4] arm64: dts: add description for solidrun cn9131 solidwan board Thread-Index: AQHajmt4w4zwT8gI9EGUFXDjzCdkprFnv8QAgAyX9QCAAAKKgA== Date: Mon, 22 Apr 2024 13:47:01 +0000 Message-ID: <15b79794-41f4-43e0-888e-286ca1fc4321@solid-run.com> References: <20240414-cn9130-som-v3-0-350a67d44e0a@solid-run.com> <20240414-cn9130-som-v3-4-350a67d44e0a@solid-run.com> <3958052d-fc09-4c4c-a9e3-4923871cff44@solid-run.com> In-Reply-To: Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=solid-run.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM9PR04MB7586:EE_|DB9PR04MB9498:EE_ x-ms-office365-filtering-correlation-id: 0d837fc9-c537-4931-e07b-08dc62d2afeb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: =?utf-8?B?Q09KaUhQMWlZVFJOZ3FEd1ZaQjJpcHpWQlI5QzlxbzFDRVJvNGVGdWRpVE51?= =?utf-8?B?bCtqalVWNVBCaFJ5bGZpV1hlTUg2UUZ6TG0ycUhtWlZPQ1E0ZFhTNTEwbDRC?= =?utf-8?B?a1UyK0N5UXNXOHJoTWJ1dDVyYm5jK3cvajB3MmpPaEh3Q2dnejNOVEphYUFL?= =?utf-8?B?RUlUWG94VjFLeDRRQkcxN2YveXowSE0xakNXRVB0U2UwWEd1Qm1vYmg4dEFw?= =?utf-8?B?c24vNUpNR3J6SHVtb01XMXQ3RlRSbTA1QS9ZaXhwVHZ3S2MwOWpVWmNSa0Za?= =?utf-8?B?RUxzNC8yUHA4R01PdFB4Mm9iWElhUS8xTmE4OXBkdmVCbk9JZTFGZXRMMDkz?= =?utf-8?B?Vk1lQWxPUXYwVFNqSjVMWGliZzQ2cWlCNzFZNElqZDFHYjdBWC82aEZsUTdv?= =?utf-8?B?YSthZWtOclp5ZFNvN0krYzdoZW1PY25LWnFTQS9VNlhjdGpzc1hjTm14MlBl?= =?utf-8?B?alp6UlFTL3ZDUnVrR3VpYVFSSmd1YnJEVDNKdm5rZmhiRld3eDVhYlNhTkhk?= =?utf-8?B?VjF0akwxSVdUY0pvVm9LYzdEK2RLMW1wV0ZMWk5YN3N6SHJHeGVCa1pIb3Jm?= =?utf-8?B?SW5sWlYzTW5xTk9Ubi9QbnpTT3NZQ2xMVzU4Uk5xNFBpUkpIZEQrb240S2xo?= =?utf-8?B?U2w1cG1YWGxncmxQZmpTSmdRS3V3dkw4QVJsWUJ1SCsraWV6RXYzUk90U1Ux?= =?utf-8?B?bGxuRlFEZ0JYUjRjSFlwMGtwLzR6dFRZZkY5UFRUcnhKTGJqNDU2blhMazBa?= =?utf-8?B?bHprSGh6aGdscnFsTjJlbDk4bGpvak5UNEtycTlBWkY3QnZQZFVJS1pmSnNq?= =?utf-8?B?ZWJiYmVHa3dKak1FSndIelJldUR1a0hPSk1mK1RYSUtkNlJLZitBZlJ5OXRN?= =?utf-8?B?aHJEV3dWd2JiakxtV0RlRGE0SkRyOFZ6cEVuYXc3UFRBamltUEpFN3YybFhN?= =?utf-8?B?V08xTHF5bTFzQnVnbkFzKy9MbnJZWFNjYUcreDUxZXNqNmFrcWVRQzVEUS9r?= =?utf-8?B?VExPQjlGTHVFRjBJOG5ncEpheG83Vk5ZRWhseGxDeHlQQlNpN1o0d1luSWQ4?= =?utf-8?B?MTVIdmYva3JnWFlqU3NidFdJamIxbmFwQ1d3S3lIeHJIK3V3Yk9TUXRXSDEy?= =?utf-8?B?QmtvRWVpUFFnUUdwc242OWhIT2duSEh2cjNpNmNJVzBmZzFyV2cvUXgrRllw?= =?utf-8?B?UkZXazlBTFhXUXh0UnNPYlNlaldkTXZueVlleWl1QTlWSGd5bVAxRXczakR1?= =?utf-8?B?VUhPanorNmZmZXE3c2cxZzBMMDl5QWlHVGRaSURUd0l1Vms1YklvajJkcWZz?= =?utf-8?B?SDdtbWgzdU1ydDhvL0Z2RUJNV3Y2NVhYWUNOMG1GaERzQ2lxcThpS205VUFC?= =?utf-8?B?b0JsMzRmTWx4VlZnUXlyZ3BHTHR0ZEFxdjduTXdWdEo5ME53RlAwMDAwRmJK?= =?utf-8?B?YmFhR3NPRlJCd3d6NGNVWTFCci9MK2VxN2NRODBybDFmLzl2a3UzK1B1ZVJp?= =?utf-8?B?V3Vvc0JaSXVJZXE5Mi9vdHEyeXZtYklISnoxUzQzb24xbXFxRktvcUcrejBR?= =?utf-8?B?b3NPQ0dLMjBRR2R4eXZtVVhUU0g3Sm81OSs3Q0RIdks1dWwvK0M1K0k4Y2cz?= =?utf-8?B?R3htQXE2YnpKL0swUlFCcHE3TE1DTkM0VlhBV0RCb2w1Q3MyRlZZTWlSSXNC?= =?utf-8?B?SndDVWUxc0JjeDk5SllXQjR5cVZDQXFLTXBHTkFtL1dpSWlwekxYY3hBajJZ?= =?utf-8?B?ZHRTYU5OZmJNYlg5S3RISlloZHdIZUQzVGxkaWttTXpZYkhrZGw0NG9rSDR6?= =?utf-8?B?a0xmejVpTnRaRXA2c1U0dz09?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR04MB7586.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(1800799015)(7416005)(376005)(38070700009);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aUtKZmI2SU1jK3hlMGkreU1EMkV2QmJXWkJMNzJJRlJjenBMSmQxV0phdWdl?= =?utf-8?B?aVovRFhQdTVManRpdm51bnY5QlNWY1pDNzMvcmJ6cERFZUtyT0xTaHlIVlVu?= =?utf-8?B?NWtiQjZJZ2twM3V6MXVYbW85UWRwTkN5QXp0U2VtTkVLaExBUEQ3RnNBdTh3?= =?utf-8?B?cmVib1FyQTdORE5yb0ZsRXJlcVBvdmttTnFqMEJrWlpveGVGdkFNVmxYR1kv?= =?utf-8?B?elZNeFR4TUtIY3Uyd2pkSkRzNk0wZVNDOFRLNUdaUE4zMzJmRlFjcTNZc0RG?= =?utf-8?B?MkZBaXIybURCMCs1dXNkUVZsNmduTVpxb3pLTFZCNlg4QkJZdnJ5M2ZEdzht?= =?utf-8?B?NzIvK0pkT2s5ZHFRamg0Tm8vS3VodWpoaWdWNndjT3h0WDNaZjlUckdBdi9V?= =?utf-8?B?MDFEVnN2TEd5akpSb0VuYVd1Q1JCSVBSVHBvckpRQno4bUJWWDRIZm45OU81?= =?utf-8?B?Uy9kVkYvWE5hQmJNa1VTM1h6aGlZdjZoa1MzdVhwRGdWTm5KL1I0eGdQTVBQ?= =?utf-8?B?SUFBUlExUGhabUxESmlIL29sTHJ3Qy8vcjBXaUhjTDBOOXN4dTQ3d1NKeXJu?= =?utf-8?B?bUhHMkt5Uk1Bd0ZLenVDUjMvZWxRVmRiRGliZUFadG9reTkwRmJXUWNVY2VP?= =?utf-8?B?Q1ZOMFhWcnhmL1dYSUhSMmJtM1lUY3JHL0hOazlsRzA4YzUrYTVzQnlHN1B2?= =?utf-8?B?U2Q3NUhjU2JWd1VKK0FqSkN5andUczNCRlhWNWJlVGRwTDhxbDBHUDBBajcw?= =?utf-8?B?aXFTcTRRMEMrempSbWZ5MFpzUDhWcDM0YjVwYXRpUTZOQVRTM2JpeVlrUjRZ?= =?utf-8?B?UzBMSlpNK2lXVm84OFRkRlErUUF0OXVueXV3WCs0UXlMN2o1QzdDbzB3elY2?= =?utf-8?B?U3VpUG1KaUMyT2ppTVp0K1JvM2Jham1NNFVtcS9heE9oQzcyRDUzZWlvUVJq?= =?utf-8?B?VnA5SDMxOTg5ekVZU3IrNkRibDNXRTZ2M1lQdm14VklJVjF3TDNjQm1yYXh4?= =?utf-8?B?YnpxVTU4QnFuQkdJTjI5YnkrZUJOWEQrajVqc24vbkNJZGdzcW9ac1ViQ0xV?= =?utf-8?B?aVZuY0FkTUE2dlRKRHVVc2JFSkUwT3RGSWhIVTVpMFFNWFoxL2dObzIwZEZL?= =?utf-8?B?dnRwajRkd0R1aStFREtCUDFhdFZTRVZuTHIyYTgyLzA2SFRIdUNzb0ZscU8r?= =?utf-8?B?Z3lRS0JkMHZtbUtZZk0zb1FBQUpxTnFPQWtUY0xINnQyY2ZCUFlHUEp5eWx4?= =?utf-8?B?TG5iVDZKcGhFbHZMNW80Qmx0YmlIeE9Sdkh0NS9TOGtVR0VsWVJYRkcyQmw1?= =?utf-8?B?NHBVTEJ5UTdkd3l5UWtQNkxOWnUya0pFb0Z6d3h5YXM2ZDJxdkJ1cUhsZlhK?= =?utf-8?B?Z1FzNHR0dU1vbzROK083ZzI5a3NWQWR5VGFiMkZRVnJFSGVsMVYrNXNSaEVn?= =?utf-8?B?TjRzcmdxbHBFYld6SjlydDJrcmR4eTlpK1N3WWxhc3JWTzFYMTFmWlo1cjN3?= =?utf-8?B?RWJmNGJNYUlyMnhBcWRMWnFFdDRBWUhmZW1QOEdsVi9PbDR0QU1NWGRmaS9Q?= =?utf-8?B?NnNmTFpUT1lFaEttTlZUR3VLSnhBVVk1WFdGaXNzVGp0VDNOVWhjaTNaR0N6?= =?utf-8?B?ejhRbGxUSWp6Z2djWENQSnB5dEdUZUdVUFltUEFsOTl0aGhiZ2JYZkp5eUdT?= =?utf-8?B?NmI0K2VKcENiYXB0Wm5nNm9YOUpuNDVmUnRxVE5zM1ZQSEt1L2FGSXhJL3ZU?= =?utf-8?B?dkEreXZoc0xMOU1wV3FwL3hRNmE4TDVPa2VYL2ZzKzIwc1FXcFBxMHBMbmJ5?= =?utf-8?B?TE0yVERVTnlqQ0NkSkNFQWpXdERpMDROVnBXUHZEVmcvUFN6L0VHOERLS3B5?= =?utf-8?B?K1JyQXJ5STl5dVQvV0ZZTkMwUER6dWxnK1FXS1krbTRQdzdYQ3Q5MGdsZEdN?= =?utf-8?B?Z2pvNFpmTlk1OVcyVmpCN2tpZGlTUWF0RHNaMkhianIvN2xqRHZXUFhYclN4?= =?utf-8?B?ZDRmOW8xY3E1Z0xBamRQWkdrcHRGZzEvbmxaTy94NWowWjVzdExsRTZIK2V0?= =?utf-8?B?MnczaEtFSzdiYWhvUFd3d0MySjJrV0prMEMxRzV3dWpxSGJlKzE0d0lXNktz?= =?utf-8?Q?xIpY=3D?= Content-ID: MIME-Version: 1.0 X-OriginatorOrg: solid-run.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB7586.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d837fc9-c537-4931-e07b-08dc62d2afeb X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2024 13:47:01.3689 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a4a8aaf3-fd27-4e27-add2-604707ce5b82 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dGsdYfs3kej6dktYL0TgrkqRR96x+My8r6aqP7rbgzmqKF7sJAljKORAybfddohELOudrhWBsIfnU66BgMazaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9498 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240422_064715_525210_572D63BD X-CRM114-Status: GOOD ( 15.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 22.04.24 um 15:37 schrieb Andrew Lunn: > On Sun, Apr 14, 2024 at 01:18:56PM +0000, Josua Mayer wrote: >> Am 14.04.24 um 14:58 schrieb Josua Mayer: >>> Add description for the SolidRun CN9131 SolidWAN, based on CN9130 SoM >>> with an extra communication processor on the carrier board. >>> >>> This board differentiates itself from CN9130 Clearfog by providing >>> additional SoC native network interfaces and pci buses: >>> 2x 10Gbps SFP+ >>> 4x 1Gbps RJ45 >>> 1x miniPCI-E >>> 1x m.2 b-key with sata, usb-2.0 and usb-3.0 >>> 1x m.2 m-key with pcie and usb-2.0 >>> 1x m.2 b-key with pcie, usb-2.0, usb-3.0 and 2x sim slots >>> 1x mpcie with pcie only >>> 2x type-a usb-2.0/3.0 >>> >>> Signed-off-by: Josua Mayer >>> --- >>> arch/arm64/boot/dts/marvell/Makefile | 1 + >>> arch/arm64/boot/dts/marvell/cn9131-cf-solidwan.dts | 653 +++++++++++++++++++++ >>> 2 files changed, 654 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/marvell/Makefile b/arch/arm64/boot/dts/marvell/Makefile >>> index 019f2251d696..16f9d7156d9f 100644 >>> --- a/arch/arm64/boot/dts/marvell/Makefile >>> +++ b/arch/arm64/boot/dts/marvell/Makefile >>> @@ -30,3 +30,4 @@ dtb-$(CONFIG_ARCH_MVEBU) += ac5x-rd-carrier-cn9131.dtb >>> dtb-$(CONFIG_ARCH_MVEBU) += ac5-98dx35xx-rd.dtb >>> dtb-$(CONFIG_ARCH_MVEBU) += cn9130-cf-base.dtb >>> dtb-$(CONFIG_ARCH_MVEBU) += cn9130-cf-pro.dtb >>> +dtb-$(CONFIG_ARCH_MVEBU) += cn9131-cf-solidwan.dtb >>> diff --git a/arch/arm64/boot/dts/marvell/cn9131-cf-solidwan.dts b/arch/arm64/boot/dts/marvell/cn9131-cf-solidwan.dts >> cut >>> + leds { >>> + compatible = "gpio-leds"; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&cp0_led_pins &cp1_led_pins>; >>> + >>> + /* for sfp-1 (J42) */ >>> + led-sfp1-activity { >>> + label = "sfp1"; >>> + gpios = <&cp0_gpio1 7 GPIO_ACTIVE_HIGH>; >>> + color = ; >>> + }; >>> + >>> + /* for sfp-1 (J42) */ >>> + led-sfp1-link { >>> + label = "sfp1"; >>> + gpios = <&cp0_gpio1 4 GPIO_ACTIVE_HIGH>; >>> + color = ; >>> + }; >>> + >>> + /* (J28) */ >>> + led-sfp0-activity { >>> + label = "sfp0"; >>> + gpios = <&cp1_gpio2 22 GPIO_ACTIVE_HIGH>; >>> + color = ; >>> + }; >>> + >>> + /* (J28) */ >>> + led-sfp0-link { >>> + label = "sfp0"; >>> + gpios = <&cp1_gpio2 23 GPIO_ACTIVE_HIGH>; >>> + color = ; >>> + }; >>> + }; >>> + >> Here I am uncertain what to put in the label. >> Each SFP has a single dual-color (3 terminals) LED, >> with one gpio controlling each colour. >> >> Colours are similar to RJ45 connectors (yellow, green), >> and are intended for the same purpose: link, activity. > For the switch LEDs you used label = "LED10"; Does the silk screen > have similar numbers for these LEDs? Correct, on CN9130 Clearfog Pro DSA switch, all LEDs are labeled individually on the silk screen. The SolidWAN SFP leds are dual-colour leds with 3 terminals: anode to 3.3V, 2x cathode to gpio-controlled transistors. They are labeled on the silk-screen as "LED9", "LED10". Duplicate labels are not great, is there a better way? old style "LED9:green" e.g. ...? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel