From mboxrd@z Thu Jan 1 00:00:00 1970 From: nm@ti.com (Nishanth Menon) Date: Fri, 18 Nov 2016 07:56:35 -0600 Subject: [RFC 4/6] ARM: dts: dra7: add entry for bb2d module In-Reply-To: <1479466741.20533.5.camel@pengutronix.de> References: <20161118024436.13447-1-robertcnelson@gmail.com> <20161118024436.13447-4-robertcnelson@gmail.com> <1479466741.20533.5.camel@pengutronix.de> Message-ID: <15bbd8af-c321-689b-ca85-acce581bd8a7@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/18/2016 04:59 AM, Lucas Stach wrote: > Am Donnerstag, den 17.11.2016, 20:44 -0600 schrieb Robert Nelson: >> From: Gowtham Tammana >> >> BB2D entry is added to the dts file. Crossbar index number is used >> for interrupt mapping. >> >> Signed-off-by: Gowtham Tammana >> Signed-off-by: Tomi Valkeinen >> --- >> arch/arm/boot/dts/dra7.dtsi | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi >> index addb753..43488b6 100644 >> --- a/arch/arm/boot/dts/dra7.dtsi >> +++ b/arch/arm/boot/dts/dra7.dtsi >> @@ -959,6 +959,16 @@ >> ti,hwmods = "dmm"; >> }; >> >> + bb2d: bb2d at 59000000 { >> + compatible = "ti,dra7-bb2d"; >> + reg = <0x59000000 0x0700>; >> + interrupts = ; >> + ti,hwmods = "bb2d"; >> + clocks = <&dpll_core_h24x2_ck>; >> + clock-names = "fclk"; > > "fclk" is not an accepted clock name for the etnaviv driver. It supports > up to 3 clocks: "bus", "core" and "shader". If there is only one clock > required in your design it would probably be the "core" clock. fclk is used as a standard for all hwmod (SoC level control library that existed prior to ARM DT-fication, and now slowly being converted to DT). I think the core and bus clock is the same here.. I wonder if something duplicated like the following will fly? clocks = <&dpll_core_h24x2_ck>, <&dpll_core_h24x2_ck> ; clock-names = "fclk", "core"; It might have been better if hwmod clocks were'nt assumed from clock-names.. instead it could have been something like: ti,hwmod-fck-clk-names = "core"; ti,hwmod-ick-clk-names = "bus"; ti,hwmod-ock-clk-names = "shader"; clocks = <&dpll_core_h24x2_ck>, <&clk2>, <&clk3>; clock-names = "core", "bus", "shader"; Tero: ? -- Regards, Nishanth Menon