From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98EA3C43461 for ; Tue, 15 Sep 2020 03:46:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B3F8206E9 for ; Tue, 15 Sep 2020 03:46:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cjmruNCL"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="A1upKMC3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B3F8206E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QBjVBdubgdn15SlDzkJ7rYYr7nh8aTGzvWKVJTxL3Zg=; b=cjmruNCLNkbat52IyG9Hd7p7O KXlTxtpokZMrlomEvVOp9BCUoRplXITBIqLha5l6aTlg82Z+uqIzMXXqnGRIvLoUryQH3mT/YhS89 OTkkJ5JtN5s70zCA4oXtFEy+E8BJXJ4CgHwUWyb3lBto0It1VS5uYPXiZG/f7WjqkLVwBmiSQJuRm CfY4SH41iG7Xneehv375dJuKUAnFFo+gd2DYMaWwA0IsmOkLnYFUCb+gEiwDRMb37/idK2CDwMKWR 0YuX72Zt3nimLk65873SjdNunNrz58VT0Ch+VmX32XLio2getxNxCPOQqzqni8dPrYSDufS83TEdd jUTmTmUsA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kI1u8-0005Md-Id; Tue, 15 Sep 2020 03:45:16 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kI1u5-0005Ly-L0; Tue, 15 Sep 2020 03:45:14 +0000 X-UUID: a7503cbf93ad4733b43bf99bf150c359-20200914 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=fjtaVNlKqWQZ+nDwPY/kGe7L/DsU5VQfgkfZJC8M/FI=; b=A1upKMC3KCgfJrS5hyTQEz1+yh4EwYK5XFegorqzDWhZVH0R1Q4uwTyhyJmWZh6M57tc/S+iukDi0Hl9q3RQTz7NPf0cgth/OUJrgCAM7WZZDuKKWm49gBnxGOGvqBm7QlOtEd7Nlhl2lbtpvecDVM/4tuoaSB6/4z3PoNfjmZo=; X-UUID: a7503cbf93ad4733b43bf99bf150c359-20200914 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1926335980; Mon, 14 Sep 2020 19:45:10 -0800 Received: from MTKMBS02N1.mediatek.inc (172.21.101.77) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 14 Sep 2020 20:45:07 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 15 Sep 2020 11:44:55 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 15 Sep 2020 11:44:56 +0800 Message-ID: <1600141495.20512.5.camel@mtksdaap41> Subject: Re: [PATCH V5 15/17] regulator: Regulator driver for the Mediatek DVFSRC From: Henry Chen To: Mark Brown Date: Tue, 15 Sep 2020 11:44:55 +0800 In-Reply-To: <20200914123444.GE4821@sirena.org.uk> References: <1600052684-21198-1-git-send-email-henryc.chen@mediatek.com> <1600052684-21198-16-git-send-email-henryc.chen@mediatek.com> <20200914123444.GE4821@sirena.org.uk> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200914_234513_877920_55AEF6A4 X-CRM114-Status: GOOD ( 17.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nicolas Boichat , Mike Turquette , James Liao , Viresh Kumar , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Boyd , Fan Chen , devicetree@vger.kernel.org, Rob Herring , Ryan Case , Arvin Wang , Matthias Brugger , linux-mediatek@lists.infradead.org, Georgi Djakov , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mark, Thank you for reviewing. On Mon, 2020-09-14 at 13:34 +0100, Mark Brown wrote: > On Mon, Sep 14, 2020 at 11:04:42AM +0800, Henry Chen wrote: > > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (c) 2019 MediaTek Inc. > > + */ > > Please make the entire comment a C++ one so things look more > intentional, and are you sure about that copyright date? Ok, it will be modified on next version. > > > +static int dvfsrc_set_voltage_sel(struct regulator_dev *rdev, > > + unsigned int selector) > > +{ > > + struct device *dvfsrc_dev = to_dvfsrc_dev(rdev); > > + int id = rdev_get_id(rdev); > > + > > + switch (id) { > > + case DVFSRC_ID_VCORE: > > + mtk_dvfsrc_send_request(dvfsrc_dev, > > + MTK_DVFSRC_CMD_VCORE_REQUEST, > > + selector); > > + break; > > + case DVFSRC_ID_VSCP: > > + mtk_dvfsrc_send_request(dvfsrc_dev, > > + MTK_DVFSRC_CMD_VSCP_REQUEST, > > + selector); > > + break; > > Just have two separate operations rather than the switch statement, and > where you do have switch statements please follow the kernel coding > style. Ok, it will be modified on next version. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel