public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 0/2] ARM: shmobile: Add early debugging support using SCIF(A)
Date: Fri, 14 Nov 2014 17:23:41 +0100	[thread overview]
Message-ID: <1602253.050FQygs2a@wuerfel> (raw)
In-Reply-To: <1415980187-12683-1-git-send-email-geert+renesas@glider.be>

On Friday 14 November 2014 16:49:45 Geert Uytterhoeven wrote:
>         Hi Simon, Magnus, Arnd,
> 
> This patch series adds serial port debug macros for the SCIF(A) serial ports.
> This includes all supported shmobile SoCs, except for EMEV2.
> 
> It contains 2 patches, which are two alternative versions:
>   - The first patch keeps on using the identity mapping set up by .map_io()
>     on platforms I cannot test myself (sh7372 and r8a7779),
>   - The second one converts the remaining platforms to use debug_ll_io_init(),
>     which allowed to get rid of the #ifdef in renesas-scif.S, and consolidate
>     more config options.
> 
> Both versions work fine on r8a7791/koelsch (multiplatform), r8a7740/armadillo
> (legacy and reference), and sh73a0/kzm9g (legacy, reference, and
> multiplatform), also with a multiplatform kernel based on shmobile_defconfig.
> 
> I'd appreciate if you could test the second one on sh7372 and r8a7779,
> and if it works, apply it.
> 
> Else, please apply the first version. We can do incremental conversions later,
> as discussed before.

Both versions look good to me,

Acked-by: Arnd Bergmann <arnd@arndb.de>

I do notice that strictly speaking you break alphabetical ordering by putting
DEBUG_R8A* and DEBUG_RCAR* after DEBUG_RK*, but it does seem way more reasonable
like this.

	Arnd

  parent reply	other threads:[~2014-11-14 16:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-14 15:49 [PATCH v4 0/2] ARM: shmobile: Add early debugging support using SCIF(A) Geert Uytterhoeven
2014-11-14 15:49 ` [PATCH v4a 1/2] " Geert Uytterhoeven
2014-11-14 15:49 ` [PATCH v4b 2/2] " Geert Uytterhoeven
2014-11-14 16:23 ` Arnd Bergmann [this message]
2014-11-17  1:27 ` [PATCH v4 0/2] " Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1602253.050FQygs2a@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox