From: claude yen <claude.yen@mediatek.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Len Brown <len.brown@intel.com>,
wsd_upstream@mediatek.com, linux-pm@vger.kernel.org,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Pavel Machek <pavel@ucw.cz>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PM / s2idle: Export s2idle_set_ops
Date: Fri, 23 Oct 2020 12:28:20 +0800 [thread overview]
Message-ID: <1603427300.7573.6.camel@mtkswgap22> (raw)
In-Reply-To: <20201022070154.hqvksoj4nss3er2e@bogus>
On Thu, 2020-10-22 at 08:02 +0100, Sudeep Holla wrote:
> On Thu, Oct 22, 2020 at 02:17:48PM +0800, Claude Yen wrote:
> > As suspend_set_ops is exported in commit a5e4fd8783a2
> > ("PM / Suspend: Export suspend_set_ops, suspend_valid_only_mem"),
> > exporting s2idle_set_ops to make kernel module setup s2idle ops too.
> >
> > In this way, kernel module can hook platform suspend
> > functions regardless of Suspend-to-Ram(S2R) or
> > Suspend-to-Idle(S2I)
> >
>
> If this is for arm64 platform, then NACK. You must use PSCI and it will
> set the ops and it can't be module.
>
PSCI uses suspend_set_ops instead. And suspend_set_ops has been
exported years ago.
Suspend-to_Idle(S2I) is another suspend method supported by linux
kernel. The corresponding s2idle_ops can be hooked by s2idle_set_ops
by underlying platforms. For example, S2I is now introduced into
Mediatek SoC platforms. Besides, power management driver is built as
kernel module.
Mobile platforms are now call for kernel drivers to be kernel modules.
This could help drivers easier to migrate to newer linux kernel.
Ref: https://linuxplumbersconf.org/event/7/contributions/790/
Regards,
Claude
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-23 4:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 6:17 [PATCH] PM / s2idle: Export s2idle_set_ops Claude Yen
2020-10-22 6:17 ` Claude Yen
2020-10-22 7:02 ` Sudeep Holla
2020-10-23 4:28 ` claude yen [this message]
2020-10-23 14:48 ` Sudeep Holla
2020-10-23 14:58 ` Rafael J. Wysocki
2020-10-26 9:55 ` claude yen
2020-10-24 8:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1603427300.7573.6.camel@mtkswgap22 \
--to=claude.yen@mediatek.com \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox