From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C960C388F7 for ; Wed, 28 Oct 2020 15:14:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B27B24694 for ; Wed, 28 Oct 2020 15:14:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HraHby8U"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="uqaV11gb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B27B24694 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ia6xWPBVbOJqQaiJ1QLrTVttrn3XwRD1mJpdroHzlq8=; b=HraHby8UjjZiNO+Pg1nf0aWz1 clmIrNruxdTMb2Tlk0+sLHcVPT+PxIxkN4pkY4cI804kukhxZ3tdamwbtQx66lfGQbykTloIRMkkB lQ10ABHQnRlleyHsxF3HAmo0JTt5TvvsOfPNWJ+2KA1N5Qg3oObDamfxK3HiJeaexFrd3qvlhY55g cSa98rsAoZMCU0GKIobZnXhM4LOeBKDEPAPp/FTdqpbGreEMbpHUC/iU6bWhJp4k11QXzfhtmhomc NcoKKAwhKP5S6XT5cljH+OSMzaselUEgQboImhcmYB1PeYRGGq/qBt3f8GN+X67v/2Gvdb8jlPwXF gkSyEoPng==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXn8C-0007AJ-4E; Wed, 28 Oct 2020 15:12:56 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXn85-00078r-D0 for linux-arm-kernel@lists.infradead.org; Wed, 28 Oct 2020 15:12:50 +0000 Received: from localhost.localdomain (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DEE64247B4; Wed, 28 Oct 2020 15:12:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603897968; bh=G+a9tAqKfo1FKngndd1wk/6n9OaUyZGsZA67OwoudG4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uqaV11gbUEV4zvNXiGpLI51CWpkthZ3eLlf/UK+rqHMVIQdd7836W3aMcVJEDUn4O anOuCYwDkUXDOpbLFVxImekHbJ/q1bzMz8j7Fh/k2EiUj8xw7IfaI54bfHElMNmZxD nwldbbREuijDa/Si90aWB+aAFtbbED3tbxzlP0rw= From: Will Deacon To: Ard Biesheuvel , linux-kernel@vger.kernel.org Subject: Re: [PATCH] module: use hidden visibility for weak symbol references Date: Wed, 28 Oct 2020 15:12:34 +0000 Message-Id: <160389413619.1112960.12611093041695506337.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201027151132.14066-1-ardb@kernel.org> References: <20201027151132.14066-1-ardb@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201028_111249_585706_27952A75 X-CRM114-Status: GOOD ( 14.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Will Deacon , catalin.marinas@arm.com, Nick Desaulniers , Geert Uytterhoeven , Jessica Yu , kernel-team@android.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 27 Oct 2020 16:11:32 +0100, Ard Biesheuvel wrote: > Geert reports that commit be2881824ae9eb92 ("arm64/build: Assert for > unwanted sections") results in build errors on arm64 for configurations > that have CONFIG_MODULES disabled. > > The commit in question added ASSERT()s to the arm64 linker script to > ensure that linker generated sections such as .got, .plt etc are empty, > but as it turns out, there are corner cases where the linker does emit > content into those sections. More specifically, weak references to > function symbols (which can remain unsatisfied, and can therefore not > be emitted as relative references) will be emitted as GOT and PLT > entries when linking the kernel in PIE mode (which is the case when > CONFIG_RELOCATABLE is enabled, which is on by default). > > [...] Applied to arm64 (for-next/fixes), thanks! [1/1] module: use hidden visibility for weak symbol references https://git.kernel.org/arm64/c/13150bc5416f Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel