From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80C06C388F9 for ; Mon, 9 Nov 2020 02:24:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03FEB206CB for ; Mon, 9 Nov 2020 02:24:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JynAxOXb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="iQOAIKDn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03FEB206CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DRov0zhxx9DVMAFuGAI0VOxsxH2oM2UbeZ0QAd3wAwE=; b=JynAxOXbTsa4AwhxWckp2/HdJ Zxy31U2GWJUxiYgeNCX9yH6TK7pXPSzTUXMLbV5kEbP71qKBSFPQG9/YYy1fEXLh4TLzGw+NPxDv5 qoq0LxvEcfKHzhXuh0ngVRstTajtRdMJTtBzOyFVwLFNXQPDDcOFLuIzJwXV0yu5+gMYy6ozWkW4Y VrAVFb/P2NQiQTeF7QnsQHOlKvnHmcMNJ+zrh/TwCPiI7F3hewhyWLHbqZMs6cPLUhZP+Ek4MDaoW OD7VwYOclsTbp6m4qiVHLgrfhCuOXQTHevu6cLuXcADOUrcRPx+QzWIwRSQD9DwZR84i/hpaKes6z R9BpBte9w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kbwqD-0003f1-It; Mon, 09 Nov 2020 02:23:33 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kbwph-0003LL-MA; Mon, 09 Nov 2020 02:23:11 +0000 X-UUID: 37c8a7ab50ea4833893ed5c8e49cac8e-20201108 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=X+emFbkKDWXUxsl/dlhhvQTCk9MsT2snLQrN+cM5D/U=; b=iQOAIKDn/exKrF6hFBz12QJOxoCuzkJETAkXSAQkJbmOu4FUcv0uo7Ku84yay3jnIGtd8KzL7u3Xu2qZOEvwerncwY0h4pzTUMojuEeIBPgJbKSpB1ponePX6v12Mv2aYFibbtmZPa/wM+4zwiO9w0AA7RklNdPhZkBrHsVvzrA=; X-UUID: 37c8a7ab50ea4833893ed5c8e49cac8e-20201108 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1976345950; Sun, 08 Nov 2020 18:22:58 -0800 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 8 Nov 2020 18:22:56 -0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 9 Nov 2020 10:22:55 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 9 Nov 2020 10:22:48 +0800 Message-ID: <1604888568.15580.1.camel@mtksdaap41> Subject: Re: [PATCH 10/12] clk: mediatek: Clean up the pll_en_bit from en_mask on MT8183 From: Weiyi Lu To: Fabien Parent Date: Mon, 9 Nov 2020 10:22:48 +0800 In-Reply-To: References: <1603371365-30863-1-git-send-email-weiyi.lu@mediatek.com> <1603371365-30863-11-git-send-email-weiyi.lu@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201108_212301_923387_68A97629 X-CRM114-Status: GOOD ( 21.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Boichat , srv_heupstream@mediatek.com, Stephen Boyd , linux-kernel , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , linux-clk@vger.kernel.org, Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2020-10-28 at 11:27 +0100, Fabien Parent wrote: > Hi Weiyi, > > The clock driver for MT8167 has been merged in v5.10-rc1. Can you also > apply the change to that driver. > Thank you > > Fabien > Hi Fabien, Done. update in v2. Many thanks. > On Fri, Oct 23, 2020 at 2:44 AM Weiyi Lu wrote: > > > > remove pll_en_bit(bit0) from en_mask to make en_mask a pure en_mask > > that only used for pll dividers. > > > > Signed-off-by: Weiyi Lu > > --- > > drivers/clk/mediatek/clk-mt8183.c | 22 +++++++++++----------- > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/clk/mediatek/clk-mt8183.c b/drivers/clk/mediatek/clk-mt8183.c > > index 5046852..608108c 100644 > > --- a/drivers/clk/mediatek/clk-mt8183.c > > +++ b/drivers/clk/mediatek/clk-mt8183.c > > @@ -1121,34 +1121,34 @@ > > }; > > > > static const struct mtk_pll_data plls[] = { > > - PLL_B(CLK_APMIXED_ARMPLL_LL, "armpll_ll", 0x0200, 0x020C, 0x00000001, > > + PLL_B(CLK_APMIXED_ARMPLL_LL, "armpll_ll", 0x0200, 0x020C, 0, > > HAVE_RST_BAR | PLL_AO, BIT(24), 22, 8, 0x0204, 24, 0x0, 0x0, 0, > > 0x0204, 0, 0, armpll_div_table), > > - PLL_B(CLK_APMIXED_ARMPLL_L, "armpll_l", 0x0210, 0x021C, 0x00000001, > > + PLL_B(CLK_APMIXED_ARMPLL_L, "armpll_l", 0x0210, 0x021C, 0, > > HAVE_RST_BAR | PLL_AO, BIT(24), 22, 8, 0x0214, 24, 0x0, 0x0, 0, > > 0x0214, 0, 0, armpll_div_table), > > - PLL(CLK_APMIXED_CCIPLL, "ccipll", 0x0290, 0x029C, 0x00000001, > > + PLL(CLK_APMIXED_CCIPLL, "ccipll", 0x0290, 0x029C, 0, > > HAVE_RST_BAR | PLL_AO, BIT(24), 22, 8, 0x0294, 24, 0x0, 0x0, 0, > > 0x0294, 0, 0), > > - PLL(CLK_APMIXED_MAINPLL, "mainpll", 0x0220, 0x022C, 0x00000001, > > + PLL(CLK_APMIXED_MAINPLL, "mainpll", 0x0220, 0x022C, 0, > > HAVE_RST_BAR, BIT(24), 22, 8, 0x0224, 24, 0x0, 0x0, 0, > > 0x0224, 0, 0), > > - PLL(CLK_APMIXED_UNIV2PLL, "univ2pll", 0x0230, 0x023C, 0x00000001, > > + PLL(CLK_APMIXED_UNIV2PLL, "univ2pll", 0x0230, 0x023C, 0, > > HAVE_RST_BAR, BIT(24), 22, 8, 0x0234, 24, 0x0, 0x0, 0, > > 0x0234, 0, 0), > > - PLL_B(CLK_APMIXED_MFGPLL, "mfgpll", 0x0240, 0x024C, 0x00000001, > > + PLL_B(CLK_APMIXED_MFGPLL, "mfgpll", 0x0240, 0x024C, 0, > > 0, 0, 22, 8, 0x0244, 24, 0x0, 0x0, 0, 0x0244, 0, 0, > > mfgpll_div_table), > > - PLL(CLK_APMIXED_MSDCPLL, "msdcpll", 0x0250, 0x025C, 0x00000001, > > + PLL(CLK_APMIXED_MSDCPLL, "msdcpll", 0x0250, 0x025C, 0, > > 0, 0, 22, 8, 0x0254, 24, 0x0, 0x0, 0, 0x0254, 0, 0), > > - PLL(CLK_APMIXED_TVDPLL, "tvdpll", 0x0260, 0x026C, 0x00000001, > > + PLL(CLK_APMIXED_TVDPLL, "tvdpll", 0x0260, 0x026C, 0, > > 0, 0, 22, 8, 0x0264, 24, 0x0, 0x0, 0, 0x0264, 0, 0), > > - PLL(CLK_APMIXED_MMPLL, "mmpll", 0x0270, 0x027C, 0x00000001, > > + PLL(CLK_APMIXED_MMPLL, "mmpll", 0x0270, 0x027C, 0, > > HAVE_RST_BAR, BIT(23), 22, 8, 0x0274, 24, 0x0, 0x0, 0, > > 0x0274, 0, 0), > > - PLL(CLK_APMIXED_APLL1, "apll1", 0x02A0, 0x02B0, 0x00000001, > > + PLL(CLK_APMIXED_APLL1, "apll1", 0x02A0, 0x02B0, 0, > > 0, 0, 32, 8, 0x02A0, 1, 0x02A8, 0x0014, 0, 0x02A4, 0, 0x02A0), > > - PLL(CLK_APMIXED_APLL2, "apll2", 0x02b4, 0x02c4, 0x00000001, > > + PLL(CLK_APMIXED_APLL2, "apll2", 0x02b4, 0x02c4, 0, > > 0, 0, 32, 8, 0x02B4, 1, 0x02BC, 0x0014, 1, 0x02B8, 0, 0x02B4), > > }; > > > > -- > > 1.8.1.1.dirty > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel