Re: [PATCH] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET

From: Macpaul Lin <macpaul.lin@mediatek.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, linux-usb@vger.kernel.org,
	Mediatek WSD Upstream <wsd_upstream@mediatek.com>,
	Christopher Swenson <swenson@swenson.io>,
	linux-kernel@vger.kernel.org, Macpaul Lin <macpaul@gmail.com>,
	Eddie Hung <eddie.hung@mediatek.com>,
	Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Alexander Tsoy <alexander@tsoy.me>,
	linux-mediatek@lists.infradead.org,
	Nick Kossifidis <mickflemm@gmail.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Nicola Lunghi <nick83ola@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	Ainge Hsu <ainge.hsu@mediatek.com>
Subject: Re: [PATCH] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET
Date: Tue, 10 Nov 2020 16:17:46 +0800	[thread overview]
Message-ID: <1604996266.2817.1.camel@mtkswgap22> (raw)
In-Reply-To: <s5h5z6dljf7.wl-tiwai@suse.de>

On Tue, 2020-11-10 at 09:12 +0100, Takashi Iwai wrote:
> On Tue, 10 Nov 2020 09:04:03 +0100,
> Macpaul Lin wrote:
> > 
> > The HUAWEI USB-C headset (VID:0x12d1, PID:0x3a07) reported it supports
> > 96khz. However there will be some random issue under 96khz.
> > Not sure if there is any alternate setting could be applied.
> > Hence 48khz is suggested to be applied at this moment.
> > 
> > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> > Signed-off-by: Eddie Hung <eddie.hung@mediatek.com>
> > ---
> >  sound/usb/format.c |    5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/sound/usb/format.c b/sound/usb/format.c
> > index 1b28d01..6f6e79b 100644
> > --- a/sound/usb/format.c
> > +++ b/sound/usb/format.c
> > @@ -217,6 +217,11 @@ static int parse_audio_format_rates_v1(struct snd_usb_audio *chip, struct audiof
> >  			    (chip->usb_id == USB_ID(0x041e, 0x4064) ||
> >  			     chip->usb_id == USB_ID(0x041e, 0x4068)))
> >  				rate = 8000;
> > +			/* Huawei headset can't support 96kHz fully */
> > +			if (rate == 96000 &&
> > +			    chip->usb_id == USB_ID(0x12d1, 0x3a07) &&
> > +			    le16_to_cpu(udev->descriptor.bcdDevice) == 0x49)
> 
> This causes the compile error due to the unknown udev.
> Is this bcdDevice check mandatory?

This means firmware version of the headset as far as I know..
Sorry I'll check the compile error and resend later.

> 
> thanks,
> 
> Takashi

Thanks
Macpaul Lin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel