From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC08FC388F7 for ; Fri, 13 Nov 2020 08:27:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 351C920936 for ; Fri, 13 Nov 2020 08:27:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AFNLa+MR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="EPiaua46" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 351C920936 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YKdBemeVYoHkqCnYURJP6OlgbKI9UEBl75EAYsOWtro=; b=AFNLa+MR9R1+Xl/BLx3VWACHW rpXthMgoco9nhG/8RLg4tD4z/6IoqCEnMlsZklz6X3ZPWABCtDqY7yu7nE279uNvPjZnKkiCwYEXR DoKwFy1Sr9BAeO/bnWk9VAZ7qD9626GoYsACtsI33seOGfv5QwvHCG73JFCD5oDA9r225JdXwrXqx 3uHdwRkcfJX6fO36Apu/QWSz8r6mEBLzv6SRy3CTeYrxt4S2rpiVUV22Y0GRo54yrtkVD9roZ/KUU Mdu3vRIwmoqBRG+sm2GPT1Y9TPKEjgGxJhMuSwNWDBgaUmQNk39NDd2GKmFtZOITLV3pLaEWQ3AD9 Rd/xxBxrA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdUQ6-0002bw-Ii; Fri, 13 Nov 2020 08:26:58 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdUQ3-0002aP-GJ; Fri, 13 Nov 2020 08:26:56 +0000 X-UUID: 9a8dc7cb751e4dd59a535eef1ad9e71a-20201113 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=ZShn+dzBZrjkCnF7peuUmT+UVHHS3a90GpKlN9nJIjE=; b=EPiaua462hSIfPfeZPO1WkwCzYt06jWxWBF8pfOmr9IDmQOWiezjBOH6PGsPK0z2VjMKRKrd5p/xZacPwU5F/of3a1EMIcnhk56Q3eNxTaSf3jObHu1cNUVdEoEyqF7ElBlCjLIPBAOBcMD/9Bo80YwGoKLUAFqs0N+EoG/Ur90=; X-UUID: 9a8dc7cb751e4dd59a535eef1ad9e71a-20201113 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 996187859; Fri, 13 Nov 2020 00:27:05 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 13 Nov 2020 00:26:47 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 13 Nov 2020 16:26:43 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 13 Nov 2020 16:26:43 +0800 Message-ID: <1605256003.31607.26.camel@mhfsdcap03> Subject: Re: [PATCH 7/7] usb: musb: convert to devm_platform_ioremap_resource_byname From: Chunfeng Yun To: Geert Uytterhoeven Date: Fri, 13 Nov 2020 16:26:43 +0800 In-Reply-To: References: <1595404275-8449-1-git-send-email-chunfeng.yun@mediatek.com> <1595404275-8449-7-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 5899ECDA3DC868B0B5D4BFAE4960474BA86ACCF81DC48B0440F0F167947F43C42000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201113_032655_701452_7847445B X-CRM114-Status: GOOD ( 20.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Greg Kroah-Hartman , USB list , Linux Kernel Mailing List , linux-mediatek@lists.infradead.org, Matthias Brugger , Bin Liu , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2020-11-12 at 15:08 +0100, Geert Uytterhoeven wrote: > Hi Chunfeng, > > On Wed, Jul 22, 2020 at 9:54 AM Chunfeng Yun wrote: > > Use devm_platform_ioremap_resource_byname() to simplify code > > > > Cc: Bin Liu > > Signed-off-by: Chunfeng Yun > > Thanks for your patch, which is now commit 2d30e408a2a6b344 ("usb: musb: > convert to devm_platform_ioremap_resource_byname") in v5.9. > > > --- a/drivers/usb/musb/musb_dsps.c > > +++ b/drivers/usb/musb/musb_dsps.c > > @@ -429,12 +429,10 @@ static int dsps_musb_init(struct musb *musb) > > struct platform_device *parent = to_platform_device(dev->parent); > > const struct dsps_musb_wrapper *wrp = glue->wrp; > > void __iomem *reg_base; > > - struct resource *r; > > u32 rev, val; > > int ret; > > > > - r = platform_get_resource_byname(parent, IORESOURCE_MEM, "control"); > > - reg_base = devm_ioremap_resource(dev, r); > > + reg_base = devm_platform_ioremap_resource_byname(parent, "control"); > > if (IS_ERR(reg_base)) > > return PTR_ERR(reg_base); > > musb->ctrl_base = reg_base; > > On Beaglebone Black, where each interface has 2 children: > > musb-dsps 47401c00.usb: can't request region for resource [mem > 0x47401800-0x474019ff] > musb-hdrc musb-hdrc.1: musb_init_controller failed with status -16 > musb-hdrc: probe of musb-hdrc.1 failed with error -16 > musb-dsps 47401400.usb: can't request region for resource [mem > 0x47401000-0x474011ff] > musb-hdrc musb-hdrc.0: musb_init_controller failed with status -16 > musb-hdrc: probe of musb-hdrc.0 failed with error -16 > > Before, devm_ioremap_resource() was called on "dev" ("musb-hdrc.0" or > "musb-hdrc.1"), after it is called on "&pdev->dev" ("47401400.usb" or > "47401c00.usb"), leading to a duplicate region request, which fails. > My bad, I didn't notice that, thanks a lot. And sorry, I missed your message > I have sent a revert: > https://lore.kernel.org/linux-usb/20201112135900.3822599-1-geert+renesas@glider.be/ > > Gr{oetje,eeting}s, > > Geert > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel