From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11452C388F7 for ; Fri, 13 Nov 2020 14:52:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A3A6021D79 for ; Fri, 13 Nov 2020 14:52:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V/rMg61S"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R3fMTtxI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3A6021D79 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=EBp+7+Wj2/rXRpIph1upOudGzUzscCmOdAUmp2E8upA=; b=V/rMg61SlhdiIVCqJhxhTagkM2 XDJ+JLI6Oilun8tmxdQ0IrvNFWNcGqZujyp3GJCzIZuYp6qk3er9tUp+6ZTpfU/36PvDWfEPWlIni AP8Wsx9Fo51XgMgc5xSa0ZQ4TM3+gwdzp4AXJQanVx7v4qKEqXrXCzZrnz0PS0Lq7db+hqb8a4v0x vquoHbjJmXJsthqfmLhI7lR5GddP32hW/sWKz0yElszqQ+36cBPcXkzYJGX5zCJTH+kojuyFGJqbv YHMBD2gJR+HAvR2U3XB6G0gJRM5JeLTi4qOo4Twj7bLSykoZ0lERFSWOUdwFEq7PE0i5lZ7OqJ/Jo 6uuMB1rw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdaQF-0004QZ-5C; Fri, 13 Nov 2020 14:51:31 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdaQD-0004Pf-09 for linux-arm-kernel@lists.infradead.org; Fri, 13 Nov 2020 14:51:29 +0000 Received: by mail-pg1-x542.google.com with SMTP id t21so928653pgl.3 for ; Fri, 13 Nov 2020 06:51:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=FeQh4FdOZwVhx4i39hlguo34HgLhuLiBD0/DOQQq4rI=; b=R3fMTtxIF543Ih5YOs+n3v5kt1uVu6ewdLPwgczWBuGSJfOhwmfZiQfCHlaz2+OeQE nnYOwy71jqOodTVzkTszDyxcCDm5i4Bryf++//u2YyXwtjw6jBCD39PayLkmI4aihFrk 3xNkhZqdUVSms+ssnsGbgfPF12JbAsrvYs0MjEqwYSN8IOZFGfXl20ibyHdpeQhwiUNd cGJWBv+Gr6q0I5ynGKbMeIs9iBLkE4kxH0S7B6z6wjsPmwjrYuTyqNA0QzrUNo1hNgsM 9BEwlZ7tRTz6n2ML4TMokaV9hyc5BzLch7SVYXvend25kRyA3kE5w0qKux0lxXzCEGme sHiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=FeQh4FdOZwVhx4i39hlguo34HgLhuLiBD0/DOQQq4rI=; b=Dis0W+COQ+sCuTAyclwQKRcS9JQQ5WOj8rtVjEvO+Rusv3QtIlLJ8tDtNcvTz+pBIJ o+ZQAevNv0XA9tytOZuB0ME/orXSyLkRJ/DonOKiizWD3U6lRhZVghipSdx1NtIijnVl fJ5Nr66Ck2AbqRoy3fm4GkG/TmpZPFc+MDJNFVRHXaSPhQIWL9aTXqybhIAlACm8GeZy htvt/pDfQnsBJhKfS4CkZ05aT8mtNbw+uU49F+U6WKUWJoe3ZCxpgo2U33bGaQHA2cTt yrFto4z4Q0mG9YPLH1WXEjwrVh6ujiGCKFS/j+WVYXvrJuDaedBwezgbwnSjqTDPM/kt V7ZQ== X-Gm-Message-State: AOAM532uU2F3omJvGXa2fWNum4JGJiwZtGkOTfYsjejHtEMdKZZJNAj4 M1mgajQgZSBsdF3vzf5VeA== X-Google-Smtp-Source: ABdhPJy16wOevtvij+fqDb1WHcMwi+goNOVnFva8Xzhl90PTNfWe+5pi0V/uwYGgWXjDZXxe/ARIGQ== X-Received: by 2002:a17:90a:f189:: with SMTP id bv9mr3571491pjb.174.1605279084911; Fri, 13 Nov 2020 06:51:24 -0800 (PST) Received: from he-cluster.localdomain (67.216.221.250.16clouds.com. [67.216.221.250]) by smtp.gmail.com with ESMTPSA id t9sm12818965pje.1.2020.11.13.06.51.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Nov 2020 06:51:24 -0800 (PST) From: xiakaixu1987@gmail.com X-Google-Original-From: kaixuxia@tencent.com To: krzk@kernel.org Subject: [PATCH] ASoC: samsung: remove the unused variable value assignment Date: Fri, 13 Nov 2020 22:51:19 +0800 Message-Id: <1605279079-6416-1-git-send-email-kaixuxia@tencent.com> X-Mailer: git-send-email 1.8.3.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201113_095129_053652_2D4E556B X-CRM114-Status: GOOD ( 12.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Kaixu Xia , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Kaixu Xia The value of variable ret is overwritten by the following call devm_snd_soc_register_card(), so here the value assignment is useless. Remove it. Reported-by: Tosk Robot Signed-off-by: Kaixu Xia --- sound/soc/samsung/smdk_wm8994.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/samsung/smdk_wm8994.c b/sound/soc/samsung/smdk_wm8994.c index 64a1a64..1db5b59 100644 --- a/sound/soc/samsung/smdk_wm8994.c +++ b/sound/soc/samsung/smdk_wm8994.c @@ -160,11 +160,9 @@ static int smdk_audio_probe(struct platform_device *pdev) smdk_dai[0].cpus->dai_name = NULL; smdk_dai[0].cpus->of_node = of_parse_phandle(np, "samsung,i2s-controller", 0); - if (!smdk_dai[0].cpus->of_node) { + if (!smdk_dai[0].cpus->of_node) dev_err(&pdev->dev, "Property 'samsung,i2s-controller' missing or invalid\n"); - ret = -EINVAL; - } smdk_dai[0].platforms->name = NULL; smdk_dai[0].platforms->of_node = smdk_dai[0].cpus->of_node; -- 1.8.3.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel