From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Heiko Stuebner <heiko@sntech.de>,
linux-kernel@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
linux-mediatek@lists.infradead.org,
Xuefeng Li <lixuefeng@loongson.cn>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] phy/mediatek: Make PHY_MTK_XSPHY depend on HAS_IOMEM and OF_ADDRESS to fix build errors
Date: Wed, 25 Nov 2020 10:24:04 +0800 [thread overview]
Message-ID: <1606271044.32484.20.camel@mhfsdcap03> (raw)
In-Reply-To: <1606211233-7425-1-git-send-email-yangtiezhu@loongson.cn>
Hi Tiezhu,
On Tue, 2020-11-24 at 17:47 +0800, Tiezhu Yang wrote:
> devm_ioremap_resource() will be not built in lib/devres.c if
> CONFIG_HAS_IOMEM is not set, of_address_to_resource() will be
> not built in drivers/of/address.c if CONFIG_OF_ADDRESS is not
> set, and then there exists two build errors about undefined
> reference to "devm_ioremap_resource" and "of_address_to_resource"
> in phy-mtk-xsphy.c under COMPILE_TEST and CONFIG_PHY_MTK_XSPHY,
> make PHY_MTK_XSPHY depend on HAS_IOMEM and OF_ADDRESS to fix it.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> drivers/phy/mediatek/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig
> index 50c5e93..66df045 100644
> --- a/drivers/phy/mediatek/Kconfig
> +++ b/drivers/phy/mediatek/Kconfig
> @@ -30,6 +30,8 @@ config PHY_MTK_XSPHY
> tristate "MediaTek XS-PHY Driver"
> depends on ARCH_MEDIATEK || COMPILE_TEST
> depends on OF
> + depends on HAS_IOMEM
> + depends on OF_ADDRESS
Why not add them into deconfig but here? In fact I don't know which way
is better and follow the kernel rule.
Vinod and Kishon, do you have any suggestion about this?
> select GENERIC_PHY
> help
> Enable this to support the SuperSpeedPlus XS-PHY transceiver for
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-25 2:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 9:47 [PATCH] phy/mediatek: Make PHY_MTK_XSPHY depend on HAS_IOMEM and OF_ADDRESS to fix build errors Tiezhu Yang
2020-11-25 2:24 ` Chunfeng Yun [this message]
2020-11-25 3:31 ` Randy Dunlap
2020-11-25 6:27 ` Chunfeng Yun
2020-11-25 6:31 ` Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1606271044.32484.20.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=heiko@sntech.de \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lixuefeng@loongson.cn \
--cc=vkoul@kernel.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).