From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFEC2C83014 for ; Mon, 30 Nov 2020 11:28:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39BD720855 for ; Mon, 30 Nov 2020 11:28:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oHVSJtLN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="rl+/u4Qz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39BD720855 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ogY25DtDLHgKDy/RRN4AMm5mAIF+do066RpIocrJZ/Y=; b=oHVSJtLNAqPEX9eSR+Ucfm4t6 kE92Ja3pNDoHYe1n2gkH/R7IRVF0vV7mOaDloMHrqPKhxR8aABN0dbbbjhre0MYHxGQVwOvbiZceL L3dmKFsgMbidRB3XhwTO4UO0uF9tBGschd3owvI6+CS7p14acmtSfbRqIIO9L83v0GI08SBA8UaYf 8TR9Xv4VBbfjNO7EUCZY81DyTiSHbGMZK92I12cL75jRhCz9vCA1FvoAmCPyIZlRERglun+lOPMVw 8EWCZgym56f1EdXBlbNvnSiGAoghC6URp95cITQyuPxG0pxzCLTKKGa30I6ZX7MGNVgfQ4jYv1Jmf BJU3zv0gw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjhKF-000429-Sh; Mon, 30 Nov 2020 11:26:35 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjhKC-000412-8V; Mon, 30 Nov 2020 11:26:33 +0000 X-UUID: 11c7085893dc45eaa7b2d7facd567d2e-20201130 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=6tEmMPZ7/XbTZ9lNAUZkSE9umAvR1dsbc9GFoMNQrl8=; b=rl+/u4Qz5/L1LJt5CaNcX0PYZ0BlodLcSXgAJ61XZ7hVgikuv4N9SaNXkfaaZpJq0pTNWGMbe6e7o+AtWfpbdu3sKDhf0zE6cR4HIeeLw4ylQWL0WeZTTsGpG6yw3mum/ioGxWFPqUfdA26wE8dzp5wrFdiwV0K6ZWm3GtmuU4w=; X-UUID: 11c7085893dc45eaa7b2d7facd567d2e-20201130 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 651885090; Mon, 30 Nov 2020 03:26:21 -0800 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 30 Nov 2020 03:16:22 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 30 Nov 2020 19:16:22 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 30 Nov 2020 19:16:21 +0800 Message-ID: <1606734983.24689.1.camel@mtksdaap41> Subject: Re: [PATCH v3] arm64: dts: mediatek: Add mt8192 power domains controller From: Weiyi Lu To: Matthias Brugger Date: Mon, 30 Nov 2020 19:16:23 +0800 In-Reply-To: <1f25cc3f-324a-0020-7bf2-e5a915291522@gmail.com> References: <1605782884-19741-1-git-send-email-weiyi.lu@mediatek.com> <1605791419.19819.4.camel@mtksdaap41> <1f25cc3f-324a-0020-7bf2-e5a915291522@gmail.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201130_062632_495948_5FF06AE4 X-CRM114-Status: GOOD ( 20.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Nicolas Boichat , srv_heupstream , "devicetree@vger.kernel.org" , Enric Balletbo Serra , linux-kernel , "moderated list:ARM/Mediatek SoC support" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2020-11-27 at 13:42 +0100, Matthias Brugger wrote: > > On 19/11/2020 15:13, Enric Balletbo Serra wrote: > > Hi Weiyi, > > > > Missatge de Weiyi Lu del dia dj., 19 de nov. > > 2020 a les 14:10: > >> > >> On Thu, 2020-11-19 at 13:13 +0100, Enric Balletbo Serra wrote: > >>> Hi Weiyi, > >>> > >>> Thank you for the patch > >>> > >>> Missatge de Weiyi Lu del dia dj., 19 de nov. > >>> 2020 a les 11:48: > >>>> > >>>> Add power domains controller node for SoC mt8192 > >>>> > >>>> Signed-off-by: Weiyi Lu > >>>> --- > [...] > >>>> + /* System Power Manager */ > >>>> + spm: power-controller { > >>>> + compatible = "mediatek,mt8192-power-controller"; > >>>> + #address-cells = <1>; > >>>> + #size-cells = <0>; > >>>> + #power-domain-cells = <1>; > >>>> + > >>>> + /* power domain of the SoC */ > >>>> + audio@MT8192_POWER_DOMAIN_AUDIO { > >>> > >>> If you run the dt_bindings_check it should return some errors, as all > >>> these node names should be 'power-domain@'. Which is a bit annoying > >>> because then you will get a bunch of errors like this: > >>> > >>> [ 1.969110] debugfs: Directory 'power-domain' with parent > >>> 'pm_genpd' already present! > >>> [ 1.976997] debugfs: Directory 'power-domain' with parent > >>> 'pm_genpd' already present! > >>> [ 1.984828] debugfs: Directory 'power-domain' with parent > >>> 'pm_genpd' already present! > >>> [ 1.992657] debugfs: Directory 'power-domain' with parent > >>> 'pm_genpd' already present! > >>> [ 2.000685] debugfs: Directory 'power-domain' with parent > >>> 'pm_genpd' already present! > >>> [ 2.008566] debugfs: Directory 'power-domain' with parent > >>> 'pm_genpd' already present! > >>> [ 2.016395] debugfs: Directory 'power-domain' with parent > >>> 'pm_genpd' already present! > >>> [ 2.024221] debugfs: Directory 'power-domain' with parent > >>> 'pm_genpd' already present! > >>> [ 2.032049] debugfs: Directory 'power-domain' with parent > >>> 'pm_genpd' already present! > >>> [ 2.039874] debugfs: Directory 'power-domain' with parent > >>> 'pm_genpd' already present! > >>> [ 2.047699] debugfs: Directory 'power-domain' with parent > >>> 'pm_genpd' already present! > >>> [ 2.055524] debugfs: Directory 'power-domain' with parent > >>> 'pm_genpd' already present! > >>> [ 2.063352] debugfs: Directory 'power-domain' with parent > >>> 'pm_genpd' already present! > >>> [ 2.071176] debugfs: Directory 'power-domain' with parent > >>> 'pm_genpd' already present! > >>> > >>> But that's another problem that should be handled in debugfs system. > >>> > >> > >> Indeed...so I chose to use different name in dts to avoid problems in > >> debugfs. It does violate the naming rules. > >> > > > > But your binding will not pass (or trigger warnings) the dtb check > > then. Rob was clear that names should be generic. Proper fix is fix > > debugfs not the binding. > > > > By the way, is anybody working on this debugfs issue? > I think we can solve this problem by adding "name" to the struct scpsys_domain_data and use this domain_data->name as the genpd.name. This is very simple. But I want to know if you both like it? > Regards, > Matthias _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel