linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mt76: Fixed kernel test robot warning
@ 2020-12-09 19:36 Souptick Joarder
       [not found] ` <87ft4e9lmg.fsf@codeaurora.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Souptick Joarder @ 2020-12-09 19:36 UTC (permalink / raw)
  To: nbd, lorenzo.bianconi83, ryder.lee, kvalo, davem, kuba,
	matthias.bgg
  Cc: netdev, linux-wireless, linux-kernel, linux-mediatek,
	Souptick Joarder, linux-arm-kernel

Kernel test robot throws below warning ->

   drivers/net/wireless/mediatek/mt76/tx.c: In function
'mt76_txq_schedule':
>> drivers/net/wireless/mediatek/mt76/tx.c:499:21: warning: variable 'q'
>> set but not used [-Wunused-but-set-variable]
     499 |  struct mt76_queue *q;
         |                     ^

This patch will silence this warning.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
 drivers/net/wireless/mediatek/mt76/tx.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/wireless/mediatek/mt76/tx.c b/drivers/net/wireless/mediatek/mt76/tx.c
index 1e20afb..25627e7 100644
--- a/drivers/net/wireless/mediatek/mt76/tx.c
+++ b/drivers/net/wireless/mediatek/mt76/tx.c
@@ -504,14 +504,11 @@ void mt76_tx_complete_skb(struct mt76_dev *dev, u16 wcid_idx, struct sk_buff *sk
 
 void mt76_txq_schedule(struct mt76_phy *phy, enum mt76_txq_id qid)
 {
-	struct mt76_queue *q;
 	int len;
 
 	if (qid >= 4)
 		return;
 
-	q = phy->q_tx[qid];
-
 	rcu_read_lock();
 
 	do {
-- 
1.9.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mt76: Fixed kernel test robot warning
       [not found] ` <87ft4e9lmg.fsf@codeaurora.org>
@ 2020-12-11  6:51   ` Souptick Joarder
  0 siblings, 0 replies; 2+ messages in thread
From: Souptick Joarder @ 2020-12-11  6:51 UTC (permalink / raw)
  To: Kalle Valo
  Cc: ryder.lee, netdev, linux-wireless, linux-kernel, Matthias Brugger,
	linux-mediatek, lorenzo.bianconi83, kuba, David S. Miller,
	linux-arm-kernel, nbd

On Thu, Dec 10, 2020 at 12:46 PM Kalle Valo <kvalo@codeaurora.org> wrote:
>
> Souptick Joarder <jrdr.linux@gmail.com> writes:
>
> > Kernel test robot throws below warning ->
> >
> >    drivers/net/wireless/mediatek/mt76/tx.c: In function
> > 'mt76_txq_schedule':
> >>> drivers/net/wireless/mediatek/mt76/tx.c:499:21: warning: variable 'q'
> >>> set but not used [-Wunused-but-set-variable]
> >      499 |  struct mt76_queue *q;
> >          |                     ^
> >
> > This patch will silence this warning.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>
> I would like to take this directly to wireless-drivers-next, ok?

Ok.
>
> I'll also change the title to:
>
> mt76: remove unused variable q
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-11  6:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-09 19:36 [PATCH] mt76: Fixed kernel test robot warning Souptick Joarder
     [not found] ` <87ft4e9lmg.fsf@codeaurora.org>
2020-12-11  6:51   ` Souptick Joarder

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).