From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAC7DC433DB for ; Wed, 6 Jan 2021 08:44:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42CE023107 for ; Wed, 6 Jan 2021 08:44:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42CE023107 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oKx9mz2HmJettvKbRqIKKrXsV+9w4jeBO76Uf6LVSrI=; b=wqepHjBGAjQtSU9p8wM8SCOrA 7cmUHT0R+s210ai5hW+Q+IM5vnvf6gQ7Ubg+xsmwlN/j8QhlEVLoarqB2KPV2XeqB6q2kUUAZ/gzW xAy+ICAtL/5WG8ym0/1DGvoW0e0VZlkZU+1WWV+fzsrhABLvHeT5dHEB/92q/cMsx/QG6YQDYaXZm C8/wkxelKwl71u5fpr3AdjVIN9w4DUc4dD/gsIlYDzK3nyXpaX0gtteymx+92hjVaVwP8tmIdgrMp wqQlWxZdOMfDpIPLixrHcyzHm+kQtP02u9mXaOI7BOBUd/sNtFcGz34rWDI+NPOFSBCo3g63uNDwZ GEhumI5fw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kx4OP-0003wJ-IH; Wed, 06 Jan 2021 08:42:09 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kx4OM-0003uj-8o; Wed, 06 Jan 2021 08:42:07 +0000 X-UUID: 617c578dcd5a49798bec551490ec4eae-20210106 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=HjDudKT6CirLj9XUT1/FsMduOj9/1XKYdNqPso3wAXI=; b=mbKCxtnYMIQHllRr295ViEQF+UZ4SJZ4cCY6PiSDHDNTopS6ohevVcvHM7B2uM3HzEzJjC9Rn28jJBVjJ3VmbzLiepZvB5dNe8EXy5wGdjXTC58cGWljyFhrKlpb4AmN2PadQSYNBeRgW9Tk1izF0pibt4vVIIsHvZhhyonjBH0=; X-UUID: 617c578dcd5a49798bec551490ec4eae-20210106 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 967271068; Wed, 06 Jan 2021 00:41:58 -0800 Received: from MTKMBS02N1.mediatek.inc (172.21.101.77) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 6 Jan 2021 00:41:56 -0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 6 Jan 2021 16:41:54 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 6 Jan 2021 16:41:55 +0800 Message-ID: <1609922515.18506.17.camel@mtksdaap41> Subject: Re: [PATCH v10 3/7] [v10, 3/7]: soc: mediatek: SVS: introduce MTK SVS engine From: Roger Lu To: Nicolas Boichat Date: Wed, 6 Jan 2021 16:41:55 +0800 In-Reply-To: <1609750266.20758.40.camel@mtksdaap41> References: <20201227105449.11452-1-roger.lu@mediatek.com> <20201227105449.11452-4-roger.lu@mediatek.com> <1609750266.20758.40.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210106_034206_611296_CEB69818 X-CRM114-Status: GOOD ( 12.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nicolas Boichat , Nishanth Menon , "open list:THERMAL" , Enric Balletbo Serra , Kevin Hilman , Angus Lin , Xiaoqing Liu , lkml , Stephen Boyd , Devicetree List , Rob Herring , "moderated list:ARM/Mediatek SoC support" , HenryC Chen , Philipp Zabel , Charles Yang , Matthias Brugger , YT Lee , Fan Chen , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nicolas, [snip] > > > > > + > > > + /* Svs efuse parsing */ > > > + ft_pgm = (svsp->efuse[0] >> 4) & GENMASK(3, 0); > > > + > > > + for (idx = 0; idx < svsp->bank_num; idx++) { > > > + svsb = &svsp->banks[idx]; > > > + > > > + if (ft_pgm <= 1) > > > + svsb->init01_volt_flag = SVSB_INIT01_VOLT_IGNORE; > > > + > > > + switch (svsb->sw_id) { > > > + case SVSB_CPU_LITTLE: > > > + svsb->bdes = svsp->efuse[16] & GENMASK(7, 0); > > > + svsb->mdes = (svsp->efuse[16] >> 8) & GENMASK(7, 0); > > > + svsb->dcbdet = (svsp->efuse[16] >> 16) & GENMASK(7, 0); > > > + svsb->dcmdet = (svsp->efuse[16] >> 24) & GENMASK(7, 0); > > > + svsb->mtdes = (svsp->efuse[17] >> 16) & GENMASK(7, 0); > > > > Again, if all of those values were u8, there'd be no need for these GENMASK > > Ok, I'll use u8 instead of GENMASK. Thanks. After refining the codes, I think it's much explicit to assign the bits I want by GENMASK() and will remove other GENMASK() that are repetitive like in svs_set_bank_phase() or svs_set_freqs_pct_v2(). [snip] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel