From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42FA1C433E0 for ; Fri, 8 Jan 2021 01:50:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD92123435 for ; Fri, 8 Jan 2021 01:50:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD92123435 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:Reply-To:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3CfU6rfbJzbXYxo4rB3JNJ3EWDPuVuyZ8mZkagDfZpo=; b=Bnheh6orE1mzAvr3Bg+F0xLunh j1RsWEAalHmJ3kR8mDzpmQe71fMCFM4SV5RBlAoR9oNjY+2mS+wiSCZwMGjDnKds9o4fxvaTav64H 8V74vRSfxHk/k8l4Enuz5q5Rf5AUscW5fUh6uUn7BIx+Yaf5VnG2l6R/NKdo328xYjzYKXnShXaN+ wSW5hdAhA45bRKMKUqm6PZw1tHC8jR3PcGVQak18VR/ZmdyvSP1UmpEROVAReLElzuaK9KG7r8FLa fsoUCj94TcWYGUjtj5hDUq0WTH55gCYmokwLFr5UwX2CAmxM+vQS8qopO0Nw1s9N2SvduJlN8Jf7v YO061rpQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxgt0-00032R-Cc; Fri, 08 Jan 2021 01:48:18 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxgsw-00031n-77; Fri, 08 Jan 2021 01:48:16 +0000 X-UUID: 93772fedc67e4b1ab6981dcdb9b88470-20210107 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:Reply-To:From:Subject:Message-ID; bh=NPP5jpMnteAgsJpkoNqsMUTLM/8AlhOp/XPWd4WayzM=; b=NnIqDoqCBW6k0ASGhfpyLv7K4K2NQSOy9yfwmRGy/qi/JF519rN7XfY5/EaXJKlxA6wvMoypcijilnc0oLF/jvIljlESnfTJ7zfiaUIw2t5jcqkgm4tzEzRqa8EzVVdlw8esR7ST1JjGh7ngavB1dG+EJq4UFQ7W3vOAmeMYJDc=; X-UUID: 93772fedc67e4b1ab6981dcdb9b88470-20210107 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1242243831; Thu, 07 Jan 2021 17:48:11 -0800 Received: from mtkmbs08n2.mediatek.inc (172.21.101.56) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 7 Jan 2021 17:48:09 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by mtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 8 Jan 2021 09:48:06 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 8 Jan 2021 09:48:05 +0800 Message-ID: <1610070485.1574.10.camel@mhfsdcap03> Subject: Re: [PATCH v2] soc: mediatek: cmdq: add address shift in jump From: Yongqiang Niu To: CK Hu , Jassi Brar Date: Fri, 8 Jan 2021 09:48:05 +0800 In-Reply-To: <1608712499-24956-2-git-send-email-yongqiang.niu@mediatek.com> References: <1608712499-24956-1-git-send-email-yongqiang.niu@mediatek.com> <1608712499-24956-2-git-send-email-yongqiang.niu@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 68847612D0C798759DAC2DE39BDF7DDFAD4EDA6D3284292B08F310D98A8DC2A62000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210107_204815_383429_EE606889 X-CRM114-Status: GOOD ( 18.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Yongqiang Niu Cc: Mark Rutland , devicetree@vger.kernel.org, Philipp Zabel , Chun-Kuang Hu , David Airlie , dennis-yc.hsieh@mediatek.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Project_Global_Chrome_Upstream_Group@mediatek.com, Rob Herring , linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , damon.chu@mediatek.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2020-12-23 at 16:34 +0800, Yongqiang Niu wrote: > Add address shift when compose jump instruction > to compatible with 35bit format. > > Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform") > > Signed-off-by: Yongqiang Niu > Reviewed-by: Nicolas Boichat > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c > index 5665b6e..75378e3 100644 > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > @@ -168,7 +168,8 @@ static void cmdq_task_insert_into_thread(struct cmdq_task *task) > dma_sync_single_for_cpu(dev, prev_task->pa_base, > prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE); > prev_task_base[CMDQ_NUM_CMD(prev_task->pkt) - 1] = > - (u64)CMDQ_JUMP_BY_PA << 32 | task->pa_base; > + (u64)CMDQ_JUMP_BY_PA << 32 | > + (task->pa_base >> task->cmdq->shift_pa); > dma_sync_single_for_device(dev, prev_task->pa_base, > prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE); > hi jassi please confirm is there any question about this patch. if not, please apply this into next version, tks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel