From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B3D3C433DB for ; Sun, 24 Jan 2021 12:24:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF225229C6 for ; Sun, 24 Jan 2021 12:24:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF225229C6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:MIME-Version:In-Reply-To:References:To: Subject:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Q3ARLNeVUCrua+vp+NdJkQu3aAtnBgYTShxkUXyPsBY=; b=k6QltN54oAuNOWcRoLSl+HD3M HY7hzd0KK7ZIVDyquQ3ae9OIO/1J/wd8Ma2hd8uYLBHMeoLXTAMQE0SJnSze0yVYIfTZX/Pn+ViDT q9OMvIto72Gj+OFpjbMNJ1KSk6FquYMzd8VeaEYqfEjbK2yUn5RRTVfMdOsfYbnBLPw1bDSEfYpcg IvecX7U4m3dLNg0hdpxysaWLWgevprDC2uitgGNCQmt6jhryovgTjgmETjR8yefHCaEGbm+7F/P1g wNZWdcvDLESzxwMxy0FobVdGCS6hjuOWnfODg7gB4ce2hXBYPGwlLBVDc+OKOOIU9kCeRfIQHblFr jiUNoYI5Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3ePa-0005oZ-47; Sun, 24 Jan 2021 12:22:34 +0000 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3ePX-0005nG-5q for linux-arm-kernel@lists.infradead.org; Sun, 24 Jan 2021 12:22:32 +0000 Received: by mail-pl1-x630.google.com with SMTP id d13so151783plg.0 for ; Sun, 24 Jan 2021 04:22:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=CRaVGlQqRX3eurTgpUbO4LACsIgYJz7bYMhi3+skM5w=; b=bKuMIpY94qcNZor5JJbg9y1rkV+5c8vEcy8sNNmZrJUwLgNFSRZhf+all1fV932huz wST13It32l8icQp15BnImsizqjvbJQLYNhoL7x7ZRkgBgcOfNuR8Oy0kVPUtgd1ORKS6 JEyqT1VlF3ILsaDXQZtPvomWZNaQJnlMIURLJq0oMoqXmWEnsJ9AEU7HJ5sPiJoq/dOm vwEBo/rNNqQJZ9HFhwjQUVLozjNpoyus8kim5gwC4+mChA5Y9Kan3xIm7TjU2jav6WrC 5DV23rzG1YktYfARiBniJtFxlEvfZYmXbYjVn2fO51jteM+KsG+O3Dr62VcXSAjmPccp gqtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=CRaVGlQqRX3eurTgpUbO4LACsIgYJz7bYMhi3+skM5w=; b=fs66OO7z3SXhLUJ/MyBpt1KutUstNMVKInGdc949+ULcdWVrMf5tJ+D/kosR7zIcMk 7lzAEbftWmcQoFWjWzj7FN9W2+aI9dQct8jOxd72ia+9mVKa3SSJg7bNPYWLbB9VucHd A9Sezl/Dau6CVjHUyezld6lSHe6BO0LXrpU7NWx6d8QxAw3U5cGo5ODnyCugBOEuWQzq +J53BYm2l+I6cnVvfcPGcEq9tpwv/xGz/8zd16J67DIjhrkZtdo4XafUE4yIX+Gql3Di R3bHuVJ9+hziI72SbGfjTRp21Mn671tsfjs0x4S65I6gMoyS4iB/9yOn4JUqNN3vVyXX Qohg== X-Gm-Message-State: AOAM5300Evo2vAH1v6P1cuOjdvVBEsu5N0FmbO0Lsn40UBnAOgbzR0jm +M7tKukvAUxh7ejNcLC4ehQ= X-Google-Smtp-Source: ABdhPJy/cCBq2SaALYuvfokncGx1EYWoF3TIXnlyNQ1FvlbAreoJvYPu98Y/UK3bgTxLg0uNGqM4cA== X-Received: by 2002:a17:90a:de97:: with SMTP id n23mr7464729pjv.216.1611490949139; Sun, 24 Jan 2021 04:22:29 -0800 (PST) Received: from localhost ([124.170.13.62]) by smtp.gmail.com with ESMTPSA id 5sm13830020pff.125.2021.01.24.04.22.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Jan 2021 04:22:28 -0800 (PST) Date: Sun, 24 Jan 2021 22:22:22 +1000 From: Nicholas Piggin Subject: Re: [PATCH v10 05/12] mm: HUGE_VMAP arch support cleanup To: Christoph Hellwig References: <20210124082230.2118861-1-npiggin@gmail.com> <20210124082230.2118861-6-npiggin@gmail.com> <20210124114008.GE694255@infradead.org> In-Reply-To: <20210124114008.GE694255@infradead.org> MIME-Version: 1.0 Message-Id: <1611489959.87u9aj91nf.astroid@bobo.none> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210124_072231_288248_580502B7 X-CRM114-Status: GOOD ( 14.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, Thomas Gleixner , Will Deacon , Catalin Marinas , Ding Tianhong , linux-kernel@vger.kernel.org, Christophe Leroy , linux-mm@kvack.org, Zefan Li , Borislav Petkov , Jonathan Cameron , "H. Peter Anvin" , Andrew Morton , Rick Edgecombe , linuxppc-dev@lists.ozlabs.org, Ingo Molnar , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Excerpts from Christoph Hellwig's message of January 24, 2021 9:40 pm: >> diff --git a/arch/arm64/include/asm/vmalloc.h b/arch/arm64/include/asm/vmalloc.h >> index 2ca708ab9b20..597b40405319 100644 >> --- a/arch/arm64/include/asm/vmalloc.h >> +++ b/arch/arm64/include/asm/vmalloc.h >> @@ -1,4 +1,12 @@ >> #ifndef _ASM_ARM64_VMALLOC_H >> #define _ASM_ARM64_VMALLOC_H >> >> +#include >> + >> +#ifdef CONFIG_HAVE_ARCH_HUGE_VMAP >> +bool arch_vmap_p4d_supported(pgprot_t prot); >> +bool arch_vmap_pud_supported(pgprot_t prot); >> +bool arch_vmap_pmd_supported(pgprot_t prot); >> +#endif > > Shouldn't the be inlines or macros? Also it would be useful > if the architectures would not have to override all functions > but just those that are it actually implements? It gets better in the next patches. I did it this way again to avoid moving a lot of code at the same time as changing name / prototype slightly. I didn't see individual generic fallbacks being all that useful really at this scale. I don't mind keeping the explicit false. > Also lots of > 80 char lines in the patch. Yeah there's a few, I can reduce those. Thanks, Nick _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel