From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD31BC433DB for ; Mon, 25 Jan 2021 09:29:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50901224B1 for ; Mon, 25 Jan 2021 09:29:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50901224B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TfUyuzeY0CnG4m6K2ukz/05J00hBh9p/Zi77yHETRIM=; b=P3hAPp4QPe8CERwzvNQPyZ0d4 D2tKbttfHCSFAPUrYi3R9ZvHBeDTY1GfeWe+ajjBlDrJJp9IPNgTH4xP0yzoG5kCP4G54lLCVViCE u25ZwglBoJqq09NF+Ezmkcw1vdEk6p9BFBoz5hbfuVuuXgQZVqeplnfuUz5yRtrvnemaw7S8N0J6F F9CU+YY17qrRXI/RjzSIo4AiMP5Xtb3Y+x7MkBVDVYepRxnsc525SngnO9sb4HtBoJHKw0eREu+Q7 RwPHZ/sH1LITBBXEOotqLz2c5kuuO5++V8plcqqYVtx7FQTufZT1n5iMq724mcpNDEnKE6Up7gPa1 ICKGFX+pg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3yAX-0001KC-EX; Mon, 25 Jan 2021 09:28:21 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3yAS-0001J5-KO; Mon, 25 Jan 2021 09:28:18 +0000 X-UUID: 087abb3927e34c82af1da3cb1723e661-20210125 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=lhVwgct1qLRIqISTHiQUau/q2BPFUpBPawwGht04g0o=; b=RwR1V1RqOveP8POX8YO8ywuUu3IaAhVQNmHeWdNErZayhycocdVhppF5T9p+rU7FGEbeCFkNFDwumjuzHBhgToC+506Qog7xTF8yehibAEB5QKvaAm177+c6YpV+hViOotcWvS2lLXh4AAZTWGp3tRbTrpdc9sDjWb2iwBIrW1E=; X-UUID: 087abb3927e34c82af1da3cb1723e661-20210125 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 314269313; Mon, 25 Jan 2021 01:28:11 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 25 Jan 2021 01:28:10 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 25 Jan 2021 17:28:05 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 25 Jan 2021 17:28:05 +0800 Message-ID: <1611566885.5302.4.camel@mhfsdcap03> Subject: Re: [PATCH 2/3] memory: mtk-smi: Add module_exit and module_license From: Yong Wu To: Krzysztof Kozlowski Date: Mon, 25 Jan 2021 17:28:05 +0800 In-Reply-To: <20210125084051.ipgeu2ksucdag2u4@kozik-lap> References: <20210121062429.26504-1-yong.wu@mediatek.com> <20210121062429.26504-3-yong.wu@mediatek.com> <20210122213427.mwjyjn2wsgnko7mk@kozik-lap> <1611557381.3184.21.camel@mhfsdcap03> <20210125084051.ipgeu2ksucdag2u4@kozik-lap> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: CC098342C3475A3A19CA0E3E9BC4E530FBE4967BF1BA6A79FDA7BE926AEE12612000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210125_042816_901985_F85D0063 X-CRM114-Status: GOOD ( 30.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, anan.sun@mediatek.com, Nicolas Boichat , srv_heupstream@mediatek.com, Robin Murphy , Joerg Roedel , linux-kernel@vger.kernel.org, yi.kuo@mediatek.com, Tomasz Figa , iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, Matthias Brugger , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2021-01-25 at 09:40 +0100, Krzysztof Kozlowski wrote: > On Mon, Jan 25, 2021 at 02:49:41PM +0800, Yong Wu wrote: > > On Fri, 2021-01-22 at 22:34 +0100, Krzysztof Kozlowski wrote: > > > On Thu, Jan 21, 2021 at 02:24:28PM +0800, Yong Wu wrote: > > > > The config MTK_SMI always depends on MTK_IOMMU which is built-in > > > > currently. Thus we don't have module_exit before. This patch adds > > > > module_exit and module_license. It is a preparing patch for supporting > > > > MTK_SMI could been built as a module. > > > > > > > > Signed-off-by: Yong Wu > > > > --- > > > > drivers/memory/mtk-smi.c | 10 ++++++++++ > > > > 1 file changed, 10 insertions(+) > > > > > > > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > > > > index e2aebd2bfa8e..aa2a25abf04f 100644 > > > > --- a/drivers/memory/mtk-smi.c > > > > +++ b/drivers/memory/mtk-smi.c > > > > @@ -597,3 +597,13 @@ static int __init mtk_smi_init(void) > > > > return platform_register_drivers(smidrivers, ARRAY_SIZE(smidrivers)); > > > > } > > > > module_init(mtk_smi_init); > > > > + > > > > +static void __exit mtk_smi_exit(void) > > > > +{ > > > > + platform_unregister_drivers(smidrivers, ARRAY_SIZE(smidrivers)); > > > > +} > > > > +module_exit(mtk_smi_exit); > > > > + > > > > +MODULE_DESCRIPTION("MediaTek SMI driver"); > > > > +MODULE_ALIAS("platform:MediaTek-SMI"); > > > > > > Drivers do not use capital letters, so I have doubts whether this alias > > > is correct. > > > > I didn't care the upper/lower-case. I will change to lower case in next > > time. > > Then why do you need the alias? The name does not match driver name, so > what's the purpose of this alias/ I think it is not so necessary for us. I will delete this line in next version. Only curious what's alias is fit in our case? normally it should be the file name: mtk-smi? > > > > > MODULE_ALIAS("platform:MediaTek-smi") > > > > > > > > Adding all these should be squashed with changing Kconfig into tristate. > > > It does not have sense on its own. > > > > Thanks very much for review. > > > > Only confirm: Squash whole this patch or only squash the MODULE_x into > > the next patch? > > This entire patch 2/3 should be with 3/3. Thanks for the confirm. > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel