From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4616BC433DB for ; Thu, 28 Jan 2021 08:33:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0FC364DBD for ; Thu, 28 Jan 2021 08:33:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0FC364DBD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:Reply-To:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dng5Ezq8r6WSuY50QzVmxUPGEfijjzdypUteXpQy+VE=; b=3MRik5GzPQKJXpiy0kN/Lbs0RT TI6CM4KLrvmQqNN9Yk12/2DgUac2oS099Ad1N7ajou4Z8lMPSP8O1A+mHwSF5C4b7uQnVRXo+/dBO QnBuz0M1al0H4Dz6Or32i4wiN6SMbaLpflcHHkRA3QlQPpQy8/Ex1M0rn1IwxpyDOtoYH29VAIuFy 1sXzI7HvRF8GW6hrP2k54+aGvdpFQ7AiJt8+QVluZQa/il9SEvv8d+YFPkqktzEwiX24NNWkQ78Nc bYrxvS4oRK7tOeioGx+A+xRIcPYaeW1uPwOIRgMbPZu9P5qokWy3pog6a3i0hdVRoOqnxCJzrTXmu 17o6JMQg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l52iy-000362-B9; Thu, 28 Jan 2021 08:32:20 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l52it-00034v-Lk; Thu, 28 Jan 2021 08:32:17 +0000 X-UUID: 9264bfb4337746659b401e5f23ae4833-20210128 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:Reply-To:From:Subject:Message-ID; bh=1Sbm2bZx8k7nPtcDPxuTnvVWvjkL3PfNcHBHr0kDrP4=; b=XgOom+NZuSw6GbO1v+oy48NVP6zKz/qGNZGx9JElnks5YNK7LMOm57zCVGGpM0Hkxvws+VGWjA2XxuxzjEY60hFEZTmZXp2WXh9jM3vv6WgdqO6ct0ZYFrjqmWmdq5I2f4obfazqtTyCbzS/DK5Itf4DrKuh7nXCHwANKWBGrjg=; X-UUID: 9264bfb4337746659b401e5f23ae4833-20210128 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 201340565; Thu, 28 Jan 2021 00:32:13 -0800 Received: from mtkmbs05n1.mediatek.inc (172.21.101.15) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 28 Jan 2021 00:32:11 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 28 Jan 2021 16:32:10 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 28 Jan 2021 16:32:09 +0800 Message-ID: <1611822729.1947.14.camel@mhfsdcap03> Subject: Re: [PATCH v11 7/9] drm/mediatek: enable dither function From: Yongqiang Niu To: CK Hu Date: Thu, 28 Jan 2021 16:32:09 +0800 In-Reply-To: <1611822524.23925.4.camel@mtksdaap41> References: <20210128072802.830971-1-hsinyi@chromium.org> <20210128072802.830971-8-hsinyi@chromium.org> <1611819766.16091.4.camel@mtksdaap41> <1611820770.1947.8.camel@mhfsdcap03> <1611821233.18369.4.camel@mtksdaap41> <1611821396.1947.10.camel@mhfsdcap03> <1611822524.23925.4.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210128_033215_950053_32D131BE X-CRM114-Status: GOOD ( 34.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Yongqiang Niu Cc: Mark Rutland , Devicetree List , Philipp Zabel , David Airlie , lkml , dri-devel , "moderated list:ARM/Mediatek SoC support" , Daniel Vetter , Hsin-Yi Wang , Matthias Brugger , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2021-01-28 at 16:28 +0800, CK Hu wrote: > On Thu, 2021-01-28 at 16:18 +0800, Hsin-Yi Wang wrote: > > On Thu, Jan 28, 2021 at 4:10 PM Yongqiang Niu > > wrote: > > > > > > On Thu, 2021-01-28 at 16:07 +0800, CK Hu wrote: > > > > On Thu, 2021-01-28 at 15:59 +0800, Yongqiang Niu wrote: > > > > > On Thu, 2021-01-28 at 15:42 +0800, CK Hu wrote: > > > > > > Hi, Hsin-Yi: > > > > > > > > > > > > On Thu, 2021-01-28 at 15:28 +0800, Hsin-Yi Wang wrote: > > > > > > > From: Yongqiang Niu > > > > > > > > > > > > > > for 5 or 6 bpc panel, we need enable dither function > > > > > > > to improve the display quality > > > > > > > > > > > > > > Signed-off-by: Yongqiang Niu > > > > > > > Signed-off-by: Hsin-Yi Wang > > > > > > > --- > > > > > > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 44 ++++++++++++++++++++- > > > > > > > 1 file changed, 43 insertions(+), 1 deletion(-) > > > > > > > > > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > > > > > index 8173f709272be..e85625704d611 100644 > > > > > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > > > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > > > > > @@ -53,7 +53,9 @@ > > > > > > > #define DITHER_EN BIT(0) > > > > > > > #define DISP_DITHER_CFG 0x0020 > > > > > > > #define DITHER_RELAY_MODE BIT(0) > > > > > > > +#define DITHER_ENGINE_EN BIT(1) > > > > > > > #define DISP_DITHER_SIZE 0x0030 > > > > > > > +#define DITHER_REG(idx) (0x100 + (idx) * 4) > > > > > > > > > > > > > > #define LUT_10BIT_MASK 0x03ff > > > > > > > > > > > > > > @@ -313,8 +315,48 @@ static void mtk_dither_config(struct device *dev, unsigned int w, > > > > > > > { > > > > > > > struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev); > > > > > > > > > > > > > > + bool enable = false; > > > > > > > + > > > > > > > + /* default value for dither reg 5 to 14 */ > > > > > > > + const u32 dither_setting[] = { > > > > > > > + 0x00000000, /* 5 */ > > > > > > > + 0x00003002, /* 6 */ > > > > > > > + 0x00000000, /* 7 */ > > > > > > > + 0x00000000, /* 8 */ > > > > > > > + 0x00000000, /* 9 */ > > > > > > > + 0x00000000, /* 10 */ > > > > > > > + 0x00000000, /* 11 */ > > > > > > > + 0x00000011, /* 12 */ > > > > > > > + 0x00000000, /* 13 */ > > > > > > > + 0x00000000, /* 14 */ > > > > > > > > > > > > Could you explain what is this? > > > > > > > > > > this is dither 5 to dither 14 setting > > > > > this will be useless, we just need set dither 5 and dither 7 like > > > > > mtk_ddp_write(cmdq_pkt, 0, comp, DISP_DITHER_5); > > > > > mtk_ddp_write(cmdq_pkt, 0, comp, DISP_DITHER_7); > > > > > other value is same with hardware default value. > > > > > > > > > > > > > > > > > > > > > > > + }; > > > > > > > + > > > > > > > + if (bpc == 5 || bpc == 6) { > > > > > > > + enable = true; > > > > > > > + mtk_ddp_write(cmdq_pkt, > > > > > > > + DITHER_LSB_ERR_SHIFT_R(MTK_MAX_BPC - bpc) | > > > > > > > + DITHER_ADD_LSHIFT_R(MTK_MAX_BPC - bpc) | > > > > > > > + DITHER_NEW_BIT_MODE, > > > > > > > + &priv->cmdq_reg, priv->regs, DITHER_REG(15)); > > > > > > > + mtk_ddp_write(cmdq_pkt, > > > > > > > + DITHER_LSB_ERR_SHIFT_B(MTK_MAX_BPC - bpc) | > > > > > > > + DITHER_ADD_LSHIFT_B(MTK_MAX_BPC - bpc) | > > > > > > > + DITHER_LSB_ERR_SHIFT_G(MTK_MAX_BPC - bpc) | > > > > > > > + DITHER_ADD_LSHIFT_G(MTK_MAX_BPC - bpc), > > > > > > > > > > > > This result in 0x50505050, but previous version is 0x50504040, so this > > > > > > version is correct and previous version is incorrect? > > > > > > > > > > the new version set r g b 3 channel same, seams more reasonable > > > > > > > > > > > > > > > > > > So all the setting of DISP_DITHER_5, DISP_DITHER_7, DISP_DITHER_15, > > > > DISP_DITHER_16 is identical to mtk_dither_set(), so call > > > > mtk_dither_set() instead of duplication here. > > > > > > > > > > dither enable set in mtk_dither_set is > > > mtk_ddp_write(cmdq_pkt, DISP_DITHERING, comp, CFG); > > > > > > that is different 8183 and mt8192. > > > mt8173 dither enable in gamma is bit2 > > > mt8183 and mt8192 dither engine enable is bit 1 > > > > > > > > > > We can still call mtk_dither_set() for bpc is 5 or 6 here, though it > > will be set to bit2, > > but later in mtk_ddp_write(cmdq_pkt, enable ? DITHER_ENGINE_EN : > > DITHER_RELAY_MODE, &priv->cmdq_reg, priv->regs, DISP_DITHER_CFG); it > > will be correct back to bit 1. > > > > Is this reasonable? > > Looks weird. Maybe pass some information into mtk_dither_set() to set > DISP_DITHERING correctly. > > I find one thing need to be fixed. CFG should be lower case. we could modify this like this: void mtk_dither_set(struct mtk_ddp_comp *comp, unsigned int bpc, unsigned int cfg, u32 dither_enable, struct cmdq_pkt *cmdq_pkt) mtk_ddp_write(cmdq_pkt, dither_enable, comp, cfg); > > Regards, > CK > > > > > > > Regards, > > > > CK > > > > > > > > > > > > Regards, > > > > > > CK > > > > > > > > > > > > > + &priv->cmdq_reg, priv->regs, DITHER_REG(16)); > > > > > > > + } > > > > > > > + > > > > > > > + > > > > > > > + if (enable) { > > > > > > > + u32 idx; > > > > > > > + > > > > > > > + for (idx = 0; idx < ARRAY_SIZE(dither_setting); idx++) > > > > > > > + mtk_ddp_write(cmdq_pkt, dither_setting[idx], &priv->cmdq_reg, priv->regs, > > > > > > > + DITHER_REG(idx + 5)); > > > > > > > + } > > > > > > > + > > > > > > > mtk_ddp_write(cmdq_pkt, h << 16 | w, &priv->cmdq_reg, priv->regs, DISP_DITHER_SIZE); > > > > > > > - mtk_ddp_write(cmdq_pkt, DITHER_RELAY_MODE, &priv->cmdq_reg, priv->regs, DISP_DITHER_CFG); > > > > > > > + mtk_ddp_write(cmdq_pkt, enable ? DITHER_ENGINE_EN : DITHER_RELAY_MODE, &priv->cmdq_reg, priv->regs, DISP_DITHER_CFG); > > > > > > > } > > > > > > > > > > > > > > static void mtk_dither_start(struct device *dev) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel