From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C432FC433DB for ; Wed, 3 Mar 2021 16:25:06 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B54DB64EED for ; Wed, 3 Mar 2021 16:25:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B54DB64EED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qUyrN0jKP4N8uj96ET4Tj9tw2gPxYG37GBAOqMObTLw=; b=io8EIgCxEaz8mbLze/634oa8Z /0h4WlHgzu5J1Q87hkrFXxLyX3lW9XjcrdLR4mjZNqSAExgYYn+w27uvd7oq+4hwdpfX2CgfbOZu/ zqvWoO15/G167+BL3K6MzJ09hce3kA/yIptD7nrn/xS4scv3KXPvVwR4niQoJDs8oyAsJA7/Yfn4g IWShULA6/UsD9bFM0L3VprT732vCLKViPSCQQL2l64EVD5cNFO2TyQ6K9WcqwlVc5irNLxc7vDiP/ f5OJyCoiGjPozrRlmEHiDnh8lkiaoTGxsW44rvxxrY3fXvem7Sa/0MMRQjlGFflN991CMkNjGgJW7 qAuu8mn+w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHUHh-005aS2-B2; Wed, 03 Mar 2021 16:23:37 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHSAh-00544B-7K for linux-arm-kernel@desiato.infradead.org; Wed, 03 Mar 2021 14:08:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=r1TLyM2KdO4Z5v8rpB0N5N3VTfrMOHx7GJrLDQHfqgE=; b=g8OAPkw6v4rerIUkbYk19g3jhz HsAeE2B1iV9xVvbLdVeLdMOONk9p1xI1m7O/8eEOBjDOCNNolnFlHS/Hh4ZcB0BSIFjD9HaSMTyQr Kyj5vQrJIG8kx5/ta+WFFaN6SdXMie3u8eXY9NGmUxb0knn4keOosY4hjvHbtdKNcGiM+yCC+ocws ZpQhl7x17D2/qewRj77YcOEAWmUdtIf0Ky1tWSBzCc0cHAmU+N0jYnY0H24N7F7lAv6psF2esEI9Z n3et83cuAB2zdxJtfkzVw+Po1AuSm0M48d33M8mKOkjgU6HNwk9UOs05hL3dTKnduiVgl2y3LFL6U 21hW2U7A==; Received: from mail.kernel.org ([198.145.29.99]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHAD7-0006uX-1e for linux-arm-kernel@lists.infradead.org; Tue, 02 Mar 2021 18:57:33 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4024264F30; Tue, 2 Mar 2021 18:57:26 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=hot-poop.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lHACy-00GmGh-Fa; Tue, 02 Mar 2021 18:57:24 +0000 From: Marc Zyngier To: kvmarm@lists.cs.columbia.edu, Will Deacon Cc: kernel-team@android.com, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: Avoid corrupting vCPU context register in guest exit Date: Tue, 2 Mar 2021 18:57:12 +0000 Message-Id: <161471117621.3770794.6810105085499786951.b4-ty@kernel.org> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210226181211.14542-1-will@kernel.org> References: <20210226181211.14542-1-will@kernel.org> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: kvmarm@lists.cs.columbia.edu, will@kernel.org, kernel-team@android.com, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210302_185733_837727_9AFCA5AF X-CRM114-Status: GOOD ( 10.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 26 Feb 2021 18:12:11 +0000, Will Deacon wrote: > Commit 7db21530479f ("KVM: arm64: Restore hyp when panicking in guest > context") tracks the currently running vCPU, clearing the pointer to > NULL on exit from a guest. > > Unfortunately, the use of 'set_loaded_vcpu' clobbers x1 to point at the > kvm_hyp_ctxt instead of the vCPU context, causing the subsequent RAS > code to go off into the weeds when it saves the DISR assuming that the > CPU context is embedded in a struct vCPU. > > [...] Applied to kvmarm-master/fixes, thanks! [1/1] KVM: arm64: Avoid corrupting vCPU context register in guest exit commit: a8a0f5dbcdf57d89bb8d555c6423763d99a156c1 Cheers, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel