From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C362AC433C1 for ; Tue, 30 Mar 2021 02:44:54 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3026761554 for ; Tue, 30 Mar 2021 02:44:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3026761554 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:CC:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JkTAPrUmsLLjqDh84H5CqMWKCIe2P92MnjpNpfdZWgM=; b=OYKP7s/tim53H0pW1d9577F+I o1lCIivOwP2TUkWu2W1LDl+gfBeDlrUnVgPvO7/DXazTO25j/EPmIkJXoQ1fIU1OefZEx0psKbKfp 8tqtrrAcTpkN4fbFlMSXdz2fpC5QKthWALHPcK5xtdoq2sP40vhYHhrCyDlSt7a1MNiYkuZwJUVDm uTG3777+U1ocqfphQMBjfsdPx9//A6AZa2EUgK9IZhB9TJ3BxfFctCLzy7Dn33iEu70WGloHdf27V NaO/6rBwpMBqS4khODxH0y+Z+TPgEq6GiRkd58dij9XTu8cl1h7TMceeydfEV3orsI8FAhZKDHz4/ p78Tu0ZAQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lR4Kd-002T8B-Qg; Tue, 30 Mar 2021 02:42:16 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lR4Iv-002Sxe-I1; Tue, 30 Mar 2021 02:41:08 +0000 X-UUID: cd62354bbfb946e4b8940b3d25333174-20210329 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=onvG+jm0TSO5bAQ9iZKLOhQSnF3vE0np9PNSB36Y7Ek=; b=QzpGYQsJCmLzRmbJcQqXoBc7F4Fd7wWLjLPdqbd/9k6gahIGCNhhDFXIzu7Ox3aDxQ7aAHbiVElXE+pQ6dekA0LO02iWjNQTuNTnMXaGB76a6HxALKV5IRj9dRxti29IV/5Pfg0LBZ8FZDrMh+lQnjn62+rp1VCYlaLq10m25NY=; X-UUID: cd62354bbfb946e4b8940b3d25333174-20210329 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 714366371; Mon, 29 Mar 2021 18:40:23 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 29 Mar 2021 19:40:21 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 30 Mar 2021 10:40:20 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 30 Mar 2021 10:40:19 +0800 Message-ID: <1617072020.25009.0.camel@mtksdaap41> Subject: Re: [PATCH v6 8/8] arm64: dts: mt6359: add PMIC MT6359 related nodes From: Hsin-hsiung Wang To: Matthias Brugger CC: Lee Jones , Rob Herring , "Liam Girdwood" , Mark Brown , "Eddie Huang" , Sean Wang , Alessandro Zummo , Alexandre Belloni , Nicolas Boichat , Yingjoe Chen , Fei Shao , "Ran Bi" , , , , , , , , Wen Su Date: Tue, 30 Mar 2021 10:40:20 +0800 In-Reply-To: <54050d27-49f1-1c62-49d7-66b761fbb450@gmail.com> References: <1615829757-3223-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1615829757-3223-9-git-send-email-hsin-hsiung.wang@mediatek.com> <54050d27-49f1-1c62-49d7-66b761fbb450@gmail.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210330_034105_027395_1E0CD7E9 X-CRM114-Status: GOOD ( 21.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon, 2021-03-29 at 17:24 +0200, Matthias Brugger wrote: > > On 15/03/2021 18:35, Hsin-Hsiung Wang wrote: > > From: Wen Su > > > > add PMIC MT6359 related nodes which is for MT6779 platform > > > > Signed-off-by: Wen Su > > Signed-off-by: Hsin-Hsiung Wang > > --- > > changes since v5: > > - update file date. > > --- > > arch/arm64/boot/dts/mediatek/mt6359.dtsi | 298 ++++++++++++++++++++ > > arch/arm64/boot/dts/mediatek/mt8192-evb.dts | 1 + > > 2 files changed, 299 insertions(+) > > create mode 100644 arch/arm64/boot/dts/mediatek/mt6359.dtsi > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt6359.dtsi b/arch/arm64/boot/dts/mediatek/mt6359.dtsi > > new file mode 100644 > > index 000000000000..84235db460f8 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/mediatek/mt6359.dtsi > > @@ -0,0 +1,298 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (c) 2021 MediaTek Inc. > > + */ > > + > > +&pwrap { > > + pmic: pmic { > > + compatible = "mediatek,mt6359"; > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + > > + mt6359codec: mt6359codec { > > + }; > > + > > + mt6359regulator: regulators { > > should be just: > regulators { > > Other than that looks good to me. > Thanks for the review. I will update it in next patch. > Regards, > Matthias > > > + mt6359_vs1_buck_reg: buck_vs1 { > > + regulator-name = "vs1"; > > + regulator-min-microvolt = <800000>; > > + regulator-max-microvolt = <2200000>; > > + regulator-enable-ramp-delay = <0>; > > + regulator-always-on; > > + }; > > + mt6359_vgpu11_buck_reg: buck_vgpu11 { > > + regulator-name = "vgpu11"; > > + regulator-min-microvolt = <400000>; > > + regulator-max-microvolt = <1193750>; > > + regulator-ramp-delay = <5000>; > > + regulator-enable-ramp-delay = <200>; > > + regulator-allowed-modes = <0 1 2>; > > + }; > > + mt6359_vmodem_buck_reg: buck_vmodem { > > + regulator-name = "vmodem"; > > + regulator-min-microvolt = <400000>; > > + regulator-max-microvolt = <1100000>; > > + regulator-ramp-delay = <10760>; > > + regulator-enable-ramp-delay = <200>; > > + }; > > + mt6359_vpu_buck_reg: buck_vpu { > > + regulator-name = "vpu"; > > + regulator-min-microvolt = <400000>; > > + regulator-max-microvolt = <1193750>; > > + regulator-ramp-delay = <5000>; > > + regulator-enable-ramp-delay = <200>; > > + regulator-allowed-modes = <0 1 2>; > > + }; > > + mt6359_vcore_buck_reg: buck_vcore { > > + regulator-name = "vcore"; > > + regulator-min-microvolt = <400000>; > > + regulator-max-microvolt = <1300000>; > > + regulator-ramp-delay = <5000>; > > + regulator-enable-ramp-delay = <200>; > > + regulator-allowed-modes = <0 1 2>; > > + }; > > + mt6359_vs2_buck_reg: buck_vs2 { > > + regulator-name = "vs2"; > > + regulator-min-microvolt = <800000>; > > + regulator-max-microvolt = <1600000>; > > + regulator-enable-ramp-delay = <0>; > > + regulator-always-on; > > + }; > > + mt6359_vpa_buck_reg: buck_vpa { > > + regulator-name = "vpa"; > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <3650000>; > > + regulator-enable-ramp-delay = <300>; > > + }; > > + mt6359_vproc2_buck_reg: buck_vproc2 { > > + regulator-name = "vproc2"; > > + regulator-min-microvolt = <400000>; > > + regulator-max-microvolt = <1193750>; > > + regulator-ramp-delay = <7500>; > > + regulator-enable-ramp-delay = <200>; > > + regulator-allowed-modes = <0 1 2>; > > + }; > > + mt6359_vproc1_buck_reg: buck_vproc1 { > > + regulator-name = "vproc1"; > > + regulator-min-microvolt = <400000>; > > + regulator-max-microvolt = <1193750>; > > + regulator-ramp-delay = <7500>; > > + regulator-enable-ramp-delay = <200>; > > + regulator-allowed-modes = <0 1 2>; > > + }; > > + mt6359_vcore_sshub_buck_reg: buck_vcore_sshub { > > + regulator-name = "vcore_sshub"; > > + regulator-min-microvolt = <400000>; > > + regulator-max-microvolt = <1193750>; > > + }; > > + mt6359_vgpu11_sshub_buck_reg: buck_vgpu11_sshub { > > + regulator-name = "vgpu11_sshub"; > > + regulator-min-microvolt = <400000>; > > + regulator-max-microvolt = <1193750>; > > + }; > > + mt6359_vaud18_ldo_reg: ldo_vaud18 { > > + regulator-name = "vaud18"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-enable-ramp-delay = <240>; > > + }; > > + mt6359_vsim1_ldo_reg: ldo_vsim1 { > > + regulator-name = "vsim1"; > > + regulator-min-microvolt = <1700000>; > > + regulator-max-microvolt = <3100000>; > > + }; > > + mt6359_vibr_ldo_reg: ldo_vibr { > > + regulator-name = "vibr"; > > + regulator-min-microvolt = <1200000>; > > + regulator-max-microvolt = <3300000>; > > + }; > > + mt6359_vrf12_ldo_reg: ldo_vrf12 { > > + regulator-name = "vrf12"; > > + regulator-min-microvolt = <1100000>; > > + regulator-max-microvolt = <1300000>; > > + }; > > + mt6359_vusb_ldo_reg: ldo_vusb { > > + regulator-name = "vusb"; > > + regulator-min-microvolt = <3000000>; > > + regulator-max-microvolt = <3000000>; > > + regulator-enable-ramp-delay = <960>; > > + regulator-always-on; > > + }; > > + mt6359_vsram_proc2_ldo_reg: ldo_vsram_proc2 { > > + regulator-name = "vsram_proc2"; > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <1293750>; > > + regulator-ramp-delay = <7500>; > > + regulator-enable-ramp-delay = <240>; > > + regulator-always-on; > > + }; > > + mt6359_vio18_ldo_reg: ldo_vio18 { > > + regulator-name = "vio18"; > > + regulator-min-microvolt = <1700000>; > > + regulator-max-microvolt = <1900000>; > > + regulator-enable-ramp-delay = <960>; > > + regulator-always-on; > > + }; > > + mt6359_vcamio_ldo_reg: ldo_vcamio { > > + regulator-name = "vcamio"; > > + regulator-min-microvolt = <1700000>; > > + regulator-max-microvolt = <1900000>; > > + }; > > + mt6359_vcn18_ldo_reg: ldo_vcn18 { > > + regulator-name = "vcn18"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-enable-ramp-delay = <240>; > > + }; > > + mt6359_vfe28_ldo_reg: ldo_vfe28 { > > + regulator-name = "vfe28"; > > + regulator-min-microvolt = <2800000>; > > + regulator-max-microvolt = <2800000>; > > + regulator-enable-ramp-delay = <120>; > > + }; > > + mt6359_vcn13_ldo_reg: ldo_vcn13 { > > + regulator-name = "vcn13"; > > + regulator-min-microvolt = <900000>; > > + regulator-max-microvolt = <1300000>; > > + }; > > + mt6359_vcn33_1_bt_ldo_reg: ldo_vcn33_1_bt { > > + regulator-name = "vcn33_1_bt"; > > + regulator-min-microvolt = <2800000>; > > + regulator-max-microvolt = <3500000>; > > + }; > > + mt6359_vcn33_1_wifi_ldo_reg: ldo_vcn33_1_wifi { > > + regulator-name = "vcn33_1_wifi"; > > + regulator-min-microvolt = <2800000>; > > + regulator-max-microvolt = <3500000>; > > + }; > > + mt6359_vaux18_ldo_reg: ldo_vaux18 { > > + regulator-name = "vaux18"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-enable-ramp-delay = <240>; > > + regulator-always-on; > > + }; > > + mt6359_vsram_others_ldo_reg: ldo_vsram_others { > > + regulator-name = "vsram_others"; > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <1293750>; > > + regulator-ramp-delay = <5000>; > > + regulator-enable-ramp-delay = <240>; > > + }; > > + mt6359_vefuse_ldo_reg: ldo_vefuse { > > + regulator-name = "vefuse"; > > + regulator-min-microvolt = <1700000>; > > + regulator-max-microvolt = <2000000>; > > + }; > > + mt6359_vxo22_ldo_reg: ldo_vxo22 { > > + regulator-name = "vxo22"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <2200000>; > > + regulator-always-on; > > + }; > > + mt6359_vrfck_ldo_reg: ldo_vrfck { > > + regulator-name = "vrfck"; > > + regulator-min-microvolt = <1500000>; > > + regulator-max-microvolt = <1700000>; > > + }; > > + mt6359_vrfck_1_ldo_reg: ldo_vrfck_1 { > > + regulator-name = "vrfck"; > > + regulator-min-microvolt = <1240000>; > > + regulator-max-microvolt = <1600000>; > > + }; > > + mt6359_vbif28_ldo_reg: ldo_vbif28 { > > + regulator-name = "vbif28"; > > + regulator-min-microvolt = <2800000>; > > + regulator-max-microvolt = <2800000>; > > + regulator-enable-ramp-delay = <240>; > > + }; > > + mt6359_vio28_ldo_reg: ldo_vio28 { > > + regulator-name = "vio28"; > > + regulator-min-microvolt = <2800000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-always-on; > > + }; > > + mt6359_vemc_ldo_reg: ldo_vemc { > > + regulator-name = "vemc"; > > + regulator-min-microvolt = <2900000>; > > + regulator-max-microvolt = <3300000>; > > + }; > > + mt6359_vemc_1_ldo_reg: ldo_vemc_1 { > > + regulator-name = "vemc"; > > + regulator-min-microvolt = <2500000>; > > + regulator-max-microvolt = <3300000>; > > + }; > > + mt6359_vcn33_2_bt_ldo_reg: ldo_vcn33_2_bt { > > + regulator-name = "vcn33_2_bt"; > > + regulator-min-microvolt = <2800000>; > > + regulator-max-microvolt = <3500000>; > > + }; > > + mt6359_vcn33_2_wifi_ldo_reg: ldo_vcn33_2_wifi { > > + regulator-name = "vcn33_2_wifi"; > > + regulator-min-microvolt = <2800000>; > > + regulator-max-microvolt = <3500000>; > > + }; > > + mt6359_va12_ldo_reg: ldo_va12 { > > + regulator-name = "va12"; > > + regulator-min-microvolt = <1200000>; > > + regulator-max-microvolt = <1300000>; > > + regulator-always-on; > > + }; > > + mt6359_va09_ldo_reg: ldo_va09 { > > + regulator-name = "va09"; > > + regulator-min-microvolt = <800000>; > > + regulator-max-microvolt = <1200000>; > > + }; > > + mt6359_vrf18_ldo_reg: ldo_vrf18 { > > + regulator-name = "vrf18"; > > + regulator-min-microvolt = <1700000>; > > + regulator-max-microvolt = <1810000>; > > + }; > > + mt6359_vsram_md_ldo_reg: ldo_vsram_md { > > + regulator-name = "vsram_md"; > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <1293750>; > > + regulator-ramp-delay = <10760>; > > + regulator-enable-ramp-delay = <240>; > > + }; > > + mt6359_vufs_ldo_reg: ldo_vufs { > > + regulator-name = "vufs"; > > + regulator-min-microvolt = <1700000>; > > + regulator-max-microvolt = <1900000>; > > + }; > > + mt6359_vm18_ldo_reg: ldo_vm18 { > > + regulator-name = "vm18"; > > + regulator-min-microvolt = <1700000>; > > + regulator-max-microvolt = <1900000>; > > + regulator-always-on; > > + }; > > + mt6359_vbbck_ldo_reg: ldo_vbbck { > > + regulator-name = "vbbck"; > > + regulator-min-microvolt = <1100000>; > > + regulator-max-microvolt = <1200000>; > > + }; > > + mt6359_vsram_proc1_ldo_reg: ldo_vsram_proc1 { > > + regulator-name = "vsram_proc1"; > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <1293750>; > > + regulator-ramp-delay = <7500>; > > + regulator-enable-ramp-delay = <240>; > > + regulator-always-on; > > + }; > > + mt6359_vsim2_ldo_reg: ldo_vsim2 { > > + regulator-name = "vsim2"; > > + regulator-min-microvolt = <1700000>; > > + regulator-max-microvolt = <3100000>; > > + }; > > + mt6359_vsram_others_sshub_ldo: ldo_vsram_others_sshub { > > + regulator-name = "vsram_others_sshub"; > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <1293750>; > > + }; > > + }; > > + > > + mt6359rtc: mt6359rtc { > > + compatible = "mediatek,mt6358-rtc"; > > + }; > > + }; > > +}; > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192-evb.dts b/arch/arm64/boot/dts/mediatek/mt8192-evb.dts > > index 0205837fa698..808be492e970 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8192-evb.dts > > +++ b/arch/arm64/boot/dts/mediatek/mt8192-evb.dts > > @@ -5,6 +5,7 @@ > > */ > > /dts-v1/; > > #include "mt8192.dtsi" > > +#include "mt6359.dtsi" > > > > / { > > model = "MediaTek MT8192 evaluation board"; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel